HBase
  1. HBase
  2. HBASE-11631

Wait a little till server is online in assigning meta

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.99.0, 2.0.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In assigning the meta to a regionserver not the master, the regionserver could have not processed the reportForDuty response yet. This happens a lot in unit tests. It's better to wait a little bit.

        Issue Links

          Activity

          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12658950/hbase-11631.patch
          against trunk revision .
          ATTACHMENT ID: 12658950

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.client.TestReplicasClient
          org.apache.hadoop.hbase.master.TestRestartCluster
          org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
          org.apache.hadoop.hbase.regionserver.TestRegionReplicas
          org.apache.hadoop.hbase.TestIOFencing

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10245//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10245//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10245//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10245//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10245//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10245//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10245//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10245//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10245//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10245//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10245//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12658950/hbase-11631.patch against trunk revision . ATTACHMENT ID: 12658950 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestReplicasClient org.apache.hadoop.hbase.master.TestRestartCluster org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction org.apache.hadoop.hbase.regionserver.TestRegionReplicas org.apache.hadoop.hbase.TestIOFencing Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10245//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10245//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10245//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10245//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10245//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10245//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10245//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10245//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10245//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10245//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10245//console This message is automatically generated.
          Hide
          stack added a comment -

          What do you see with this patch in place Jimmy? For the usual case, no wait but when hiccup we stick around a little till RS is up?

          Patch lgtm.

          Show
          stack added a comment - What do you see with this patch in place Jimmy? For the usual case, no wait but when hiccup we stick around a little till RS is up? Patch lgtm.
          Hide
          Jimmy Xiang added a comment -

          I am working on HBASE-11604. I found many unit test failures due to meta assignment failed because the region server has reported to the master but hasn't processed the response yet. With this patch, things are much better. For now, we only stick around a little for meta assignment. Perhaps we can stick around a little for all regions since master knows that the regionserver is already up.

          Show
          Jimmy Xiang added a comment - I am working on HBASE-11604 . I found many unit test failures due to meta assignment failed because the region server has reported to the master but hasn't processed the response yet. With this patch, things are much better. For now, we only stick around a little for meta assignment. Perhaps we can stick around a little for all regions since master knows that the regionserver is already up.
          Hide
          stack added a comment -

          Suggest committing this for now and then in a new issue we discuss the thorny issue of cluster start waiting on regionservers to check in. We had something that was crass but basically worked previously but the character of the participants has changed pretty radically so we should do a bit of fresh thinking (wait a 'long' time for first RS to come in and as soon as we have one, assign a portion of regions in the hope that other RS will show up meantime....)

          Show
          stack added a comment - Suggest committing this for now and then in a new issue we discuss the thorny issue of cluster start waiting on regionservers to check in. We had something that was crass but basically worked previously but the character of the participants has changed pretty radically so we should do a bit of fresh thinking (wait a 'long' time for first RS to come in and as soon as we have one, assign a portion of regions in the hope that other RS will show up meantime....)
          Hide
          Jimmy Xiang added a comment -

          OK, integrated into branch 1 and master. Thanks.

          Show
          Jimmy Xiang added a comment - OK, integrated into branch 1 and master. Thanks.
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #5362 (See https://builds.apache.org/job/HBase-TRUNK/5362/)
          HBASE-11631 Wait a little till server is online in assigning meta (jxiang: rev 111636c0e7dcfa0727887a6084c44348ce34c2fc)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5362 (See https://builds.apache.org/job/HBase-TRUNK/5362/ ) HBASE-11631 Wait a little till server is online in assigning meta (jxiang: rev 111636c0e7dcfa0727887a6084c44348ce34c2fc) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-1.0 #81 (See https://builds.apache.org/job/HBase-1.0/81/)
          HBASE-11631 Wait a little till server is online in assigning meta (jxiang: rev 7b3d0add6067dc935684e9a9c47a8fca8eb1c23d)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-1.0 #81 (See https://builds.apache.org/job/HBase-1.0/81/ ) HBASE-11631 Wait a little till server is online in assigning meta (jxiang: rev 7b3d0add6067dc935684e9a9c47a8fca8eb1c23d) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
          Hide
          Enis Soztutar added a comment -

          Closing this issue after 0.99.0 release.

          Show
          Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

            People

            • Assignee:
              Jimmy Xiang
              Reporter:
              Jimmy Xiang
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development