HBase
  1. HBase
  2. HBASE-11606

Enable ZK-less region assignment by default

    Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      By default, we don't use ZK for region assignment now. To fall back to the old way, you can set hbase.assignment.usezk to true.

      Description

      Let's enable ZK-less region assignment by default in the master branch.

        Activity

        Hide
        Jimmy Xiang added a comment -

        I see. I attached a patch for HBASE-11611, with which I have verified that our internal jenkins is green. We should keep jenkins ok.

        Show
        Jimmy Xiang added a comment - I see. I attached a patch for HBASE-11611 , with which I have verified that our internal jenkins is green. We should keep jenkins ok.
        Hide
        Devaraj Das added a comment -

        The full suite never ran. Look at https://builds.apache.org/job/HBase-TRUNK/5352/testReport/ .. you will see 1411 tests ran and took 4 minutes or so to run (top right hand corner). Under normal circumstances 3000+ tests should run.

        Show
        Devaraj Das added a comment - The full suite never ran. Look at https://builds.apache.org/job/HBase-TRUNK/5352/testReport/ .. you will see 1411 tests ran and took 4 minutes or so to run (top right hand corner). Under normal circumstances 3000+ tests should run.
        Hide
        Jimmy Xiang added a comment -

        I only see these test failures

        org.apache.hadoop.hbase.master.TestClockSkewDetection
        org.apache.hadoop.hbase.procedure.TestProcedureManager
        org.apache.hadoop.hbase.ipc.TestIPC

        They are ok locally, seems not related to this change.

        Show
        Jimmy Xiang added a comment - I only see these test failures org.apache.hadoop.hbase.master.TestClockSkewDetection org.apache.hadoop.hbase.procedure.TestProcedureManager org.apache.hadoop.hbase.ipc.TestIPC They are ok locally, seems not related to this change.
        Hide
        Jimmy Xiang added a comment -

        Will fix those tests in a separate issue.

        Show
        Jimmy Xiang added a comment - Will fix those tests in a separate issue.
        Hide
        Devaraj Das added a comment -

        Seems like the unit tests didn't complete with this patch - this is the build with the patch https://builds.apache.org/job/HBase-TRUNK/5352/ All replica related tests would probably fail.

        Show
        Devaraj Das added a comment - Seems like the unit tests didn't complete with this patch - this is the build with the patch https://builds.apache.org/job/HBase-TRUNK/5352/ All replica related tests would probably fail.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #5352 (See https://builds.apache.org/job/HBase-TRUNK/5352/)
        HBASE-11606 Enable ZK-less region assignment by default (jxiang: rev 7f9ec95831d2a5f8a17b45f3bf91d7bd441153a1)

        • hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/util/ConfigUtil.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5352 (See https://builds.apache.org/job/HBase-TRUNK/5352/ ) HBASE-11606 Enable ZK-less region assignment by default (jxiang: rev 7f9ec95831d2a5f8a17b45f3bf91d7bd441153a1) hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java hbase-server/src/main/java/org/apache/hadoop/hbase/util/ConfigUtil.java
        Hide
        Jimmy Xiang added a comment -

        Integrated into master. Thanks.

        Show
        Jimmy Xiang added a comment - Integrated into master. Thanks.
        Hide
        stack added a comment -

        Needs a release note.

        Show
        stack added a comment - Needs a release note.
        Hide
        stack added a comment -

        +1

        Failures are not yours.

        Show
        stack added a comment - +1 Failures are not yours.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12658486/hbase-11606.patch
        against trunk revision .
        ATTACHMENT ID: 12658486

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.regionserver.compactions.TestStripeCompactionPolicy
        org.apache.hadoop.hbase.regionserver.TestDefaultCompactSelection

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10217//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10217//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10217//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10217//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10217//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10217//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10217//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10217//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10217//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10217//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10217//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12658486/hbase-11606.patch against trunk revision . ATTACHMENT ID: 12658486 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.compactions.TestStripeCompactionPolicy org.apache.hadoop.hbase.regionserver.TestDefaultCompactSelection Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10217//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10217//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10217//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10217//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10217//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10217//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10217//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10217//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10217//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10217//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10217//console This message is automatically generated.
        Hide
        Mikhail Antonov added a comment -

        Looks good to me. No changes in tests are needed, when this value is used? Like TestMasterFailover?

        Show
        Mikhail Antonov added a comment - Looks good to me. No changes in tests are needed, when this value is used? Like TestMasterFailover?
        Hide
        Mikhail Antonov added a comment -

        Like this idea.

        Show
        Mikhail Antonov added a comment - Like this idea.

          People

          • Assignee:
            Jimmy Xiang
            Reporter:
            Jimmy Xiang
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development