Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0, 1.1.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      We should be handling flushes and compactions from the primary region replica being replayed to the secondary region replica via HBASE-11568.

      Some initial thoughts for how can this be done is discussed in HBASE-11183. More details will come together with the patch.

      1. hbase-11569-master-v3.patch
        142 kB
        Enis Soztutar
      2. hbase-11569-v5.patch
        156 kB
        Enis Soztutar

        Issue Links

          Activity

          Hide
          Enis Soztutar added a comment -

          Linking review.

          Show
          Enis Soztutar added a comment - Linking review.
          Hide
          Enis Soztutar added a comment -

          RB does not work for me it seems.

          I am attaching an updated and rebased patch here instead. I'll put it up to github or Phabricator if RB is not fixed.

          A bit of explanation for the patch is needed.

          When the primary region server executes flushes, compactions and opens / closes the region, it is written to WAL (HBASE-11511, HBASE-11512, HBASE-2231) and these event edits are also being sent using the async wal replication using HBASE-11568 to the secondary region replica.

          In this patch, we replay flushes from primary region replica by creating a corresponding snapshot with the same seqId from the primary. On replaying the flush commit marker, we find out the previous flush prepare and drop the memstore snapshots and pick up the new files.

          Region open events are used as coordination points, where all the region's flush files are written to the WAL when primary opens it. Replaying that event on the secondary will also pick those files up, and clean the memstore states accordingly (see patch).

          Since replication can deliver events out of order, region open event markers are used so that whenever we replay a region open event, we skip all previous entries so that flush / compaction markers from previous seqId's do not mess up the state.

          Some earlier discussions about issues related to this patch can also be found at the design doc at HBASE-11183.

          The meat of the changes are in HRegion. We have split the internalFlushCache() method into two. The first part does prepare, second part does flush and commit. These two parts are used from replaying flush start and flush commit events coming from the primary region replica. Some changes are there for handling the seqId's from the replayed WAL edits. Since the secondaries track the primary with the same seqId, they also track their sequenceId atomicLong and also memstore read points. Finally, TestHRegionReplayEvents.java adds a lot of tests for handling different scenarios (see comment in the test).

          Show
          Enis Soztutar added a comment - RB does not work for me it seems. I am attaching an updated and rebased patch here instead. I'll put it up to github or Phabricator if RB is not fixed. A bit of explanation for the patch is needed. When the primary region server executes flushes, compactions and opens / closes the region, it is written to WAL ( HBASE-11511 , HBASE-11512 , HBASE-2231 ) and these event edits are also being sent using the async wal replication using HBASE-11568 to the secondary region replica. In this patch, we replay flushes from primary region replica by creating a corresponding snapshot with the same seqId from the primary. On replaying the flush commit marker, we find out the previous flush prepare and drop the memstore snapshots and pick up the new files. Region open events are used as coordination points, where all the region's flush files are written to the WAL when primary opens it. Replaying that event on the secondary will also pick those files up, and clean the memstore states accordingly (see patch). Since replication can deliver events out of order, region open event markers are used so that whenever we replay a region open event, we skip all previous entries so that flush / compaction markers from previous seqId's do not mess up the state. Some earlier discussions about issues related to this patch can also be found at the design doc at HBASE-11183 . The meat of the changes are in HRegion. We have split the internalFlushCache() method into two. The first part does prepare, second part does flush and commit. These two parts are used from replaying flush start and flush commit events coming from the primary region replica. Some changes are there for handling the seqId's from the replayed WAL edits. Since the secondaries track the primary with the same seqId, they also track their sequenceId atomicLong and also memstore read points. Finally, TestHRegionReplayEvents.java adds a lot of tests for handling different scenarios (see comment in the test).
          Hide
          Enis Soztutar added a comment -

          We can do the reviews here, until RB works again: https://github.com/enis/hbase/commit/c8cd3bd0271895178595e020f0af702c23b83811.

          Show
          Enis Soztutar added a comment - We can do the reviews here, until RB works again: https://github.com/enis/hbase/commit/c8cd3bd0271895178595e020f0af702c23b83811 .
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12696569/hbase-11569-master-v3.patch
          against master branch at commit 4f472062a436726f686608023126dd8d5cc9c9bc.
          ATTACHMENT ID: 12696569

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 5 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

          -1 checkstyle. The applied patch generated 1943 checkstyle errors (more than the master's current 1941 errors).

          -1 findbugs. The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + new java.lang.String[]

          { "Action", "TableName", "EncodedRegionName", "FlushSequenceNumber", "StoreFlushes", "RegionName", }

          );
          + new java.lang.String[]

          { "EventType", "TableName", "EncodedRegionName", "LogSequenceNumber", "Stores", "Server", "RegionName", }

          );
          + + prepareFlushResult.flushOpSeqId + ". Picking up new file, but not dropping prepared"

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.regionserver.TestPerColumnFamilyFlush

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12696569/hbase-11569-master-v3.patch against master branch at commit 4f472062a436726f686608023126dd8d5cc9c9bc. ATTACHMENT ID: 12696569 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 5 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 2 warning messages. -1 checkstyle . The applied patch generated 1943 checkstyle errors (more than the master's current 1941 errors). -1 findbugs . The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + new java.lang.String[] { "Action", "TableName", "EncodedRegionName", "FlushSequenceNumber", "StoreFlushes", "RegionName", } ); + new java.lang.String[] { "EventType", "TableName", "EncodedRegionName", "LogSequenceNumber", "Stores", "Server", "RegionName", } ); + + prepareFlushResult.flushOpSeqId + ". Picking up new file, but not dropping prepared" +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestPerColumnFamilyFlush Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12692//console This message is automatically generated.
          Hide
          Jeffrey Zhong added a comment -

          Looks good to me(+1). I posted few minor comments in the review board. Thanks.

          Show
          Jeffrey Zhong added a comment - Looks good to me(+1). I posted few minor comments in the review board. Thanks.
          Hide
          Enis Soztutar added a comment -

          Attaching patch to address Jeffrey's comments from RB, and javadoc fixes. Will commit if hadoopqa passes.

          Show
          Enis Soztutar added a comment - Attaching patch to address Jeffrey's comments from RB, and javadoc fixes. Will commit if hadoopqa passes.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12698629/hbase-11569-v5.patch
          against master branch at commit 7561ae6d1257b51c0bb1ef46e52d8ede2c7c926f.
          ATTACHMENT ID: 12698629

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.
          +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + new java.lang.String[]

          { "Action", "TableName", "EncodedRegionName", "FlushSequenceNumber", "StoreFlushes", "RegionName", }

          );
          + new java.lang.String[]

          { "EventType", "TableName", "EncodedRegionName", "LogSequenceNumber", "Stores", "Server", "RegionName", }

          );

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:

          -1 core zombie tests. There are 1 zombie test(s):

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12698629/hbase-11569-v5.patch against master branch at commit 7561ae6d1257b51c0bb1ef46e52d8ede2c7c926f. ATTACHMENT ID: 12698629 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + new java.lang.String[] { "Action", "TableName", "EncodedRegionName", "FlushSequenceNumber", "StoreFlushes", "RegionName", } ); + new java.lang.String[] { "EventType", "TableName", "EncodedRegionName", "LogSequenceNumber", "Stores", "Server", "RegionName", } ); +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: -1 core zombie tests . There are 1 zombie test(s): Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12817//console This message is automatically generated.
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #6127 (See https://builds.apache.org/job/HBase-TRUNK/6127/)
          HBASE-11569 Flush / Compaction handling from secondary region replicas (enis: rev 3e10e6e1a61aa2a481a1450fecb94bce23809dfe)

          • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
          • hbase-protocol/src/main/protobuf/WAL.proto
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ReplayHLogKey.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFlushContext.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/util/ServerRegionReplicaUtil.java
          • hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/WALProtos.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RegionReplicaReplicationEndpoint.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultMemStore.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPerColumnFamilyFlush.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #6127 (See https://builds.apache.org/job/HBase-TRUNK/6127/ ) HBASE-11569 Flush / Compaction handling from secondary region replicas (enis: rev 3e10e6e1a61aa2a481a1450fecb94bce23809dfe) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java hbase-protocol/src/main/protobuf/WAL.proto hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ReplayHLogKey.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFlushContext.java hbase-server/src/main/java/org/apache/hadoop/hbase/util/ServerRegionReplicaUtil.java hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/WALProtos.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RegionReplicaReplicationEndpoint.java hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultMemStore.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPerColumnFamilyFlush.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
          Hide
          Enis Soztutar added a comment -

          I've committed the patch to branch-1 and master. Thanks Jeff.

          Show
          Enis Soztutar added a comment - I've committed the patch to branch-1 and master. Thanks Jeff.
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-1.1 #176 (See https://builds.apache.org/job/HBase-1.1/176/)
          HBASE-11569 Flush / Compaction handling from secondary region replicas (enis: rev 36e76c4be61465afde6440b3426eace0f25c7aa8)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultMemStore.java
          • hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/WALProtos.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          • hbase-protocol/src/main/protobuf/WAL.proto
          • hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RegionReplicaReplicationEndpoint.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/util/ServerRegionReplicaUtil.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPerColumnFamilyFlush.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFlushContext.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ReplayHLogKey.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-1.1 #176 (See https://builds.apache.org/job/HBase-1.1/176/ ) HBASE-11569 Flush / Compaction handling from secondary region replicas (enis: rev 36e76c4be61465afde6440b3426eace0f25c7aa8) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultMemStore.java hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/WALProtos.java hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java hbase-protocol/src/main/protobuf/WAL.proto hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RegionReplicaReplicationEndpoint.java hbase-server/src/main/java/org/apache/hadoop/hbase/util/ServerRegionReplicaUtil.java hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPerColumnFamilyFlush.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFlushContext.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ReplayHLogKey.java

            People

            • Assignee:
              Enis Soztutar
              Reporter:
              Enis Soztutar
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development