Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0, 1.1.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Similar to writing flush (HBASE-11511), compaction(HBASE-2231) to WAL and region open/close (HBASE-11512) , we should persist bulk load events to WAL.
      This is especially important for secondary region replicas, since we can use this information to pick up primary regions' files from secondary replicas.

      A design doc for secondary replica replication can be found at HBASE-11183.

      1. hbase-11567-branch-1.0-partial.patch
        109 kB
        Enis Soztutar
      2. HBASE-11567-v1.patch
        79 kB
        Alex Newman
      3. HBASE-11567-v2.patch
        114 kB
        Alex Newman
      4. hbase-11567-v3.patch
        244 kB
        Jeffrey Zhong
      5. hbase-11567-v4.patch
        249 kB
        Jeffrey Zhong
      6. HBASE-11567-v4-rebase.patch
        199 kB
        Jeffrey Zhong

        Activity

        Hide
        Alex Newman added a comment -

        I would love to take this up.

        Show
        Alex Newman added a comment - I would love to take this up.
        Hide
        Enis Soztutar added a comment -

        Sure thing. You can look at HBASE-11511, and HBASE-11512 as a template for code.

        Show
        Enis Soztutar added a comment - Sure thing. You can look at HBASE-11511 , and HBASE-11512 as a template for code.
        Hide
        Alex Newman added a comment -

        OK here is my first pass at it. I talked to stack offline about the jmock changes. I actually think we should break this up into three commits

        1. JMock changes to pom
        2. Protobuf changes (and generated files)
        3. The actual changes

        But I'll do it as one patch first.

        Show
        Alex Newman added a comment - OK here is my first pass at it. I talked to stack offline about the jmock changes. I actually think we should break this up into three commits 1. JMock changes to pom 2. Protobuf changes (and generated files) 3. The actual changes But I'll do it as one patch first.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12658800/HBASE-11567-v1.patch
        against trunk revision .
        ATTACHMENT ID: 12658800

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        -1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings).

        -1 lineLengths. The patch introduces the following lines longer than 100:
        + * Generates a marker for the WAL so that we propagate the notion of a bulk region load throughout the WAL.
        + * @param familyPaths A list of pairs which maps the name of the column family to the location on disk where it is
        + * @param assignSeqId Whether or not to assign a new sequence ID (by way of calling flush) or to use the one provided
        + List<Pair<byte[], String>> familyPaths,
        + new java.lang.String[]

        { "TableName", "EncodedRegionName", "FamilyPath", "AssignSeqNum", }

        );
        + WALProtos.BulkLoadDescriptor loadDescriptor = ProtobufUtil.toBulkLoadDescriptor(this.getRegionInfo().getTable(),
        + * @param sequenceId The current sequenceId in the log at the time when we were to write the bulk load marker.
        + public static WALEdit createBulkLoadEvent(HRegionInfo hri, WALProtos.BulkLoadDescriptor bulkLoadDescriptor) {
        + testRegionWithFamilies(family1, family2).bulkLoadHFiles(withFamilyPathsFor(family1, family2), false);
        + public void bulkHLogShouldThrowErrorWhenFamilySpecifiedAndHFileExistsButNotInTableDescriptor() throws IOException {

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.TestIOFencing
        org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
        org.apache.hadoop.hbase.regionserver.TestRegionReplicas
        org.apache.hadoop.hbase.migration.TestNamespaceUpgrade
        org.apache.hadoop.hbase.client.TestReplicasClient
        org.apache.hadoop.hbase.master.TestRestartCluster

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10237//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10237//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12658800/HBASE-11567-v1.patch against trunk revision . ATTACHMENT ID: 12658800 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. -1 release audit . The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings). -1 lineLengths . The patch introduces the following lines longer than 100: + * Generates a marker for the WAL so that we propagate the notion of a bulk region load throughout the WAL. + * @param familyPaths A list of pairs which maps the name of the column family to the location on disk where it is + * @param assignSeqId Whether or not to assign a new sequence ID (by way of calling flush) or to use the one provided + List<Pair<byte[], String>> familyPaths, + new java.lang.String[] { "TableName", "EncodedRegionName", "FamilyPath", "AssignSeqNum", } ); + WALProtos.BulkLoadDescriptor loadDescriptor = ProtobufUtil.toBulkLoadDescriptor(this.getRegionInfo().getTable(), + * @param sequenceId The current sequenceId in the log at the time when we were to write the bulk load marker. + public static WALEdit createBulkLoadEvent(HRegionInfo hri, WALProtos.BulkLoadDescriptor bulkLoadDescriptor) { + testRegionWithFamilies(family1, family2).bulkLoadHFiles(withFamilyPathsFor(family1, family2), false); + public void bulkHLogShouldThrowErrorWhenFamilySpecifiedAndHFileExistsButNotInTableDescriptor() throws IOException { +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.TestIOFencing org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction org.apache.hadoop.hbase.regionserver.TestRegionReplicas org.apache.hadoop.hbase.migration.TestNamespaceUpgrade org.apache.hadoop.hbase.client.TestReplicasClient org.apache.hadoop.hbase.master.TestRestartCluster Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10237//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10237//console This message is automatically generated.
        Hide
        ryan rawson added a comment -

        Good generally speaking.

        The bulk load tests should really verify more behavior. In the 'successful' cases, what kind of behavior has changed about the HRegion that we could check? (if anything - it might not be feasible since HRegion isn't SOLID)

        I also could imagine a series of integration tests that verify that the data in the bulk loaded file is readable. There is also some stress tests that involve loading during concurrent operations and what should happen in those cases. That is a separate integration test.

        commented on 154f10b hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java:L2748:
        I want to see a space between ){

        commented on 154f10b hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java:L2750:
        what's the line length max? Are we on Java7, can we use diamonds now?

        commented on 154f10b hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java:L2751:
        spacing here, between the : and the ){

        commented on 154f10b hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEdit.java:L322:
        im a little vaugely unhappy how creating all these structures is spread about, but that is a greater issue, and we cant fix it now.

        commented on 154f10b hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:L3667:
        spacing here:
        if (log != null) {

        commented on 154f10b hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:L3672 :
        so the log doesnt really know how to write business logicy entries, so we have a utility class that does it. So who is really responsible for doing these things? The obvious design solution is a wrapper around HLog which allows pluggable log under it, we should file a new HBase JIRA.
        one thing that bothers me about this line is we are hiding a pretty heavy duty IO event, and its not really apparent, maybe change the name to HLogUtil.writeBulkLoadMarkerAndSync() so its apparent

        commented on 154f10b hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoad.java:L46 :
        writes to files = not unit test

        commented on 154f10b hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoad.java:L64:
        are these constants? if so, final them, upcaps them

        commented on 154f10b hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoad.java:L76:
        Isn't there already a constant that has this in it somewhere else?
        the answer is yes, a package protected one in WALEdit - lets not copy magic constants about, DRY that up

        commented on 154f10b hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoad.java:L121:
        hide this (and others like this) behind a static function

        commented on 154f10b hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoad.java:L144 :
        space

        commented on 154f10b hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoad.java:L168:
        maybe call this
        bulkLogWalEditType – it might read better when it's being used.

        Show
        ryan rawson added a comment - Good generally speaking. The bulk load tests should really verify more behavior. In the 'successful' cases, what kind of behavior has changed about the HRegion that we could check? (if anything - it might not be feasible since HRegion isn't SOLID) I also could imagine a series of integration tests that verify that the data in the bulk loaded file is readable. There is also some stress tests that involve loading during concurrent operations and what should happen in those cases. That is a separate integration test. commented on 154f10b hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java:L2748: I want to see a space between ){ commented on 154f10b hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java:L2750: what's the line length max? Are we on Java7, can we use diamonds now? commented on 154f10b hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java:L2751: spacing here, between the : and the ){ commented on 154f10b hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEdit.java:L322: im a little vaugely unhappy how creating all these structures is spread about, but that is a greater issue, and we cant fix it now. commented on 154f10b hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:L3667: spacing here: if (log != null) { commented on 154f10b hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:L3672 : so the log doesnt really know how to write business logicy entries, so we have a utility class that does it. So who is really responsible for doing these things? The obvious design solution is a wrapper around HLog which allows pluggable log under it, we should file a new HBase JIRA. one thing that bothers me about this line is we are hiding a pretty heavy duty IO event, and its not really apparent, maybe change the name to HLogUtil.writeBulkLoadMarkerAndSync() so its apparent commented on 154f10b hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoad.java:L46 : writes to files = not unit test commented on 154f10b hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoad.java:L64: are these constants? if so, final them, upcaps them commented on 154f10b hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoad.java:L76: Isn't there already a constant that has this in it somewhere else? the answer is yes, a package protected one in WALEdit - lets not copy magic constants about, DRY that up commented on 154f10b hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoad.java:L121: hide this (and others like this) behind a static function commented on 154f10b hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoad.java:L144 : space commented on 154f10b hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoad.java:L168: maybe call this bulkLogWalEditType – it might read better when it's being used.
        Hide
        ryan rawson added a comment -

        also what's up with the failing tests, how could this patch conceivably affect org.apache.hadoop.hbase.migration.TestNamespaceUpgrade

        Just a general expression of annoyance at test brittleness

        Show
        ryan rawson added a comment - also what's up with the failing tests, how could this patch conceivably affect org.apache.hadoop.hbase.migration.TestNamespaceUpgrade Just a general expression of annoyance at test brittleness
        Hide
        Alex Newman added a comment -

        OK I addressed everything I could. Next step jiras are probably

        • SOLID-IFY HRegion, verify testing behavior (We will actually have to have a user story here I think)
        • With the above user story, we need more integration tests. I added some integration with an existing test to make sure the marker is being made however.
        • Change the HFile /HFile load API so we can test it without writing out files
        • Improve HLog pluggability (This is important for a bunch of reason)

        There's another thing. I am convinced that this should be 5 patches, but I am not sure how we want to do it. The patch comments are a little wonkly but here it is nonetheless
        https://github.com/posix4e/hbase/pull/1. I will attach a combined one to this jira as well.

        ryan rawson for the sake of doing things in an impartial way perhaps we should get a non wandisco employee to the next round of reviews.

        Show
        Alex Newman added a comment - OK I addressed everything I could. Next step jiras are probably SOLID-IFY HRegion, verify testing behavior (We will actually have to have a user story here I think) With the above user story, we need more integration tests. I added some integration with an existing test to make sure the marker is being made however. Change the HFile /HFile load API so we can test it without writing out files Improve HLog pluggability (This is important for a bunch of reason) There's another thing. I am convinced that this should be 5 patches, but I am not sure how we want to do it. The patch comments are a little wonkly but here it is nonetheless https://github.com/posix4e/hbase/pull/1 . I will attach a combined one to this jira as well. ryan rawson for the sake of doing things in an impartial way perhaps we should get a non wandisco employee to the next round of reviews.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12659013/HBASE-11567-v2.patch
        against trunk revision .
        ATTACHMENT ID: 12659013

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 12 new or modified tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 lineLengths. The patch introduces the following lines longer than 100:
        + new java.lang.String[]

        { "TableName", "EncodedRegionName", "FamilyPath", "AssignSeqNum", }

        );
        + * @param assignSeqId Force a flush, get it's sequenceId to preserve the guarantee that all the
        + * edits lower than the highest sequential ID from all the HFiles are flushed

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.client.TestReplicasClient
        org.apache.hadoop.hbase.master.TestRestartCluster
        org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
        org.apache.hadoop.hbase.regionserver.TestRegionReplicas
        org.apache.hadoop.hbase.TestIOFencing

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10252//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10252//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10252//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10252//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10252//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10252//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10252//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10252//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10252//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10252//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10252//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12659013/HBASE-11567-v2.patch against trunk revision . ATTACHMENT ID: 12659013 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 12 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + new java.lang.String[] { "TableName", "EncodedRegionName", "FamilyPath", "AssignSeqNum", } ); + * @param assignSeqId Force a flush, get it's sequenceId to preserve the guarantee that all the + * edits lower than the highest sequential ID from all the HFiles are flushed +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestReplicasClient org.apache.hadoop.hbase.master.TestRestartCluster org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction org.apache.hadoop.hbase.regionserver.TestRegionReplicas org.apache.hadoop.hbase.TestIOFencing Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10252//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10252//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10252//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10252//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10252//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10252//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10252//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10252//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10252//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10252//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10252//console This message is automatically generated.
        Hide
        Alex Newman added a comment -

        I think we should wait to commit this until the reader side is done. I think figuring out those tests are important for the acceptability of this patch. That being said, I hope this is a useful first step for whoever (most likely me) has to do it.

        Show
        Alex Newman added a comment - I think we should wait to commit this until the reader side is done. I think figuring out those tests are important for the acceptability of this patch. That being said, I hope this is a useful first step for whoever (most likely me) has to do it.
        Hide
        stack added a comment -

        Took a quick look. Looks good to me. We could commit this but agree probably better if read-side goes in around same time.

        Show
        stack added a comment - Took a quick look. Looks good to me. We could commit this but agree probably better if read-side goes in around same time.
        Hide
        Alex Newman added a comment -

        Daww thanks stack. One question I have is, currently I am logging the request by the user for HBase HFile bulk loading. That being said, does it make sense to have a different WAL entry when it completes successfully?

        Show
        Alex Newman added a comment - Daww thanks stack. One question I have is, currently I am logging the request by the user for HBase HFile bulk loading. That being said, does it make sense to have a different WAL entry when it completes successfully?
        Hide
        stack added a comment -

        Alex Newman Yes. Can you include files that were bulk loaded in the list? Thats what the read replicas fellas would like if I were to guess so they know what to open on the slave on completion. Maybe wait on Enis Soztutar or one of the other lads for confirmation before doing work.

        Show
        stack added a comment - Alex Newman Yes. Can you include files that were bulk loaded in the list? Thats what the read replicas fellas would like if I were to guess so they know what to open on the slave on completion. Maybe wait on Enis Soztutar or one of the other lads for confirmation before doing work.
        Hide
        stack added a comment -

        Oh, also, make case for the new dependency here and up in release notes.

        Show
        stack added a comment - Oh, also, make case for the new dependency here and up in release notes.
        Hide
        Alex Newman added a comment -

        Good news

        message FamilyPath

        { required bytes family = 1; required string path = 2; }

        includes the path for the file. It's a bit annoying but I wanted to reuse the FamilyPath proto

        Also I am meeting with horton next week in person. So yea I'll double check my work with them.

        Show
        Alex Newman added a comment - Good news message FamilyPath { required bytes family = 1; required string path = 2; } includes the path for the file. It's a bit annoying but I wanted to reuse the FamilyPath proto Also I am meeting with horton next week in person. So yea I'll double check my work with them.
        Hide
        ryan rawson added a comment -

        JMock has a few features that helps us keep our tests clean. First it only mocks interfaces, encouraging good interface-driven design. Secondly JMock has a nice little mini DSL which reads nicely. Lastly, JMock is a very strict mocker, it doesnt requires a separate validation step and requires complete specification of dependent calls.

        Mockito and JMock are slightly different tools, and have their purposes each. I'd prefer new tests be done with JMock, and using mockito to leverage older code into a newer style over time.

        Since the dependency is test-only, there is no run-time impact.

        Show
        ryan rawson added a comment - JMock has a few features that helps us keep our tests clean. First it only mocks interfaces, encouraging good interface-driven design. Secondly JMock has a nice little mini DSL which reads nicely. Lastly, JMock is a very strict mocker, it doesnt requires a separate validation step and requires complete specification of dependent calls. Mockito and JMock are slightly different tools, and have their purposes each. I'd prefer new tests be done with JMock, and using mockito to leverage older code into a newer style over time. Since the dependency is test-only, there is no run-time impact.
        Hide
        Alex Newman added a comment -

        Thanks Ryan. To double up, JMock makes creating our own testing DSLs really easy. We learned from C5, once you get enough of this infrastructure in place, testing becomes a great pleasure.

        Show
        Alex Newman added a comment - Thanks Ryan. To double up, JMock makes creating our own testing DSLs really easy. We learned from C5, once you get enough of this infrastructure in place, testing becomes a great pleasure.
        Hide
        Enis Soztutar added a comment -

        One question I have is, currently I am logging the request by the user for HBase HFile bulk loading. That being said, does it make sense to have a different WAL entry when it completes successfully?

        Indeed. The whole point of this issue is to add a WAL marker for the COMMIT of files for bulk load. Since we cannot do an atomic commit of bulk load files in the FS and also in WAL, we can do the commit in FS first, then write the WAL entry next, failing the RS if the WAL sync fails.

        Show
        Enis Soztutar added a comment - One question I have is, currently I am logging the request by the user for HBase HFile bulk loading. That being said, does it make sense to have a different WAL entry when it completes successfully? Indeed. The whole point of this issue is to add a WAL marker for the COMMIT of files for bulk load. Since we cannot do an atomic commit of bulk load files in the FS and also in WAL, we can do the commit in FS first, then write the WAL entry next, failing the RS if the WAL sync fails.
        Hide
        Enis Soztutar added a comment -

        I would also say that logging the request for bulk load is not as important as logging the bulk load commit. I do not think of any use for the bulk load request wal marker.

        Do you mind putting an RB for easier review.

        I think we would like to use BULK_LOAD for being consistent:

        +  static final byte [] BULK = Bytes.toBytes("HBASE::BULK");
        

        About jmock it should be ok, but we may want to the escalate the discussion to dev@ so that other devs are aware.

        Show
        Enis Soztutar added a comment - I would also say that logging the request for bulk load is not as important as logging the bulk load commit. I do not think of any use for the bulk load request wal marker. Do you mind putting an RB for easier review. I think we would like to use BULK_LOAD for being consistent: + static final byte [] BULK = Bytes.toBytes( "HBASE::BULK" ); About jmock it should be ok, but we may want to the escalate the discussion to dev@ so that other devs are aware.
        Hide
        Alex Newman added a comment -

        Sounds good

        What do you mean failing the RS if the Wal sync fails?

        Show
        Alex Newman added a comment - Sounds good What do you mean failing the RS if the Wal sync fails?
        Hide
        Enis Soztutar added a comment -

        After the bulk load files are committed to the region, we will call writeBulkLoadMarkerAndSync(). But if that fails with IOException or smt, then we should abort the region server similar to what we do for exception handling in flush event markers in HBASE-11511.

        Show
        Enis Soztutar added a comment - After the bulk load files are committed to the region, we will call writeBulkLoadMarkerAndSync(). But if that fails with IOException or smt, then we should abort the region server similar to what we do for exception handling in flush event markers in HBASE-11511 .
        Hide
        Jeffrey Zhong added a comment -

        Hey Alex Newman, I have updated your patch slightly as following because we need it internally: (The actual changes are trivial and most of patch are PB generated contents)

        1) Write bulk_load event after bulk load is done instead of before with loaded store file names & bulk load SeqId so that we can replay bulk load event on a region replica.
        2) Move tests back to region server package as I think the BulkLoad tests should be in region server level.

        Please take a look at it and change where you think it's needed. So we can get this in soon. Thanks.

        Show
        Jeffrey Zhong added a comment - Hey Alex Newman , I have updated your patch slightly as following because we need it internally: (The actual changes are trivial and most of patch are PB generated contents) 1) Write bulk_load event after bulk load is done instead of before with loaded store file names & bulk load SeqId so that we can replay bulk load event on a region replica. 2) Move tests back to region server package as I think the BulkLoad tests should be in region server level. Please take a look at it and change where you think it's needed. So we can get this in soon. Thanks.
        Hide
        Alex Newman added a comment -

        +1 overall (although my vote doesn't count). Sorry for not getting this done sooner, I have been distracted trying to make the build cleaner.

        On your comments
        1) agreed
        2) That makes sense, I did to avoid making fields public. I am down either way

        • Overall it looks good however i have some concerns.
        • It seems as though the formatting is wrong in some places. Please double check that you autoindent everything
        • I am curious if we should add a unit test (as opposed to regression or acceptance test) so that the wal entry is only written if everything succeeds. It would verify that your change is successful.
        Show
        Alex Newman added a comment - +1 overall (although my vote doesn't count). Sorry for not getting this done sooner, I have been distracted trying to make the build cleaner. On your comments 1) agreed 2) That makes sense, I did to avoid making fields public. I am down either way Overall it looks good however i have some concerns. It seems as though the formatting is wrong in some places. Please double check that you autoindent everything I am curious if we should add a unit test (as opposed to regression or acceptance test) so that the wal entry is only written if everything succeeds. It would verify that your change is successful.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12663565/hbase-11567-v3.patch
        against trunk revision .
        ATTACHMENT ID: 12663565

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 11 new or modified tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 javadoc. The javadoc tool appears to have generated 6 warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 lineLengths. The patch introduces the following lines longer than 100:
        + new java.lang.String[]

        { "TableName", "EncodedRegionName", "Stores", "BulkloadSeqNum", }

        );
        + * @param assignSeqId Force a flush, get it's sequenceId to preserve the guarantee that all the
        + * edits lower than the highest sequential ID from all the HFiles are flushed

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10531//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10531//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10531//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10531//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10531//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10531//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10531//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10531//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10531//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10531//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10531//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12663565/hbase-11567-v3.patch against trunk revision . ATTACHMENT ID: 12663565 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 11 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 6 warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + new java.lang.String[] { "TableName", "EncodedRegionName", "Stores", "BulkloadSeqNum", } ); + * @param assignSeqId Force a flush, get it's sequenceId to preserve the guarantee that all the + * edits lower than the highest sequential ID from all the HFiles are flushed +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10531//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10531//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10531//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10531//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10531//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10531//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10531//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10531//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10531//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10531//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10531//console This message is automatically generated.
        Hide
        Jeffrey Zhong added a comment -

        Thanks Alex Newman for the comments. The v4 tries to address your concerns. Thanks.

        Show
        Jeffrey Zhong added a comment - Thanks Alex Newman for the comments. The v4 tries to address your concerns. Thanks.
        Hide
        Alex Newman added a comment -

        Sounds good, although I can't really +1 since I am not a committer. But upon brief glance, it seems as though you have. Good on you!

        Show
        Alex Newman added a comment - Sounds good, although I can't really +1 since I am not a committer. But upon brief glance, it seems as though you have. Good on you!
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12663781/hbase-11567-v4.patch
        against trunk revision .
        ATTACHMENT ID: 12663781

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 11 new or modified tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 lineLengths. The patch introduces the following lines longer than 100:
        + new java.lang.String[]

        { "TableName", "EncodedRegionName", "Stores", "BulkloadSeqNum", }

        );
        + * @param assignSeqId Force a flush, get it's sequenceId to preserve the guarantee that all the
        + * edits lower than the highest sequential ID from all the HFiles are flushed

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.TestRegionRebalancing

        -1 core zombie tests. There are 1 zombie test(s): at org.apache.hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations.testClusterIdMismatchAtStartupWithHA(TestDataNodeMultipleRegistrations.java:249)

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10544//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10544//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10544//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10544//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10544//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10544//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10544//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10544//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10544//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10544//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10544//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12663781/hbase-11567-v4.patch against trunk revision . ATTACHMENT ID: 12663781 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 11 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + new java.lang.String[] { "TableName", "EncodedRegionName", "Stores", "BulkloadSeqNum", } ); + * @param assignSeqId Force a flush, get it's sequenceId to preserve the guarantee that all the + * edits lower than the highest sequential ID from all the HFiles are flushed +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.TestRegionRebalancing -1 core zombie tests . There are 1 zombie test(s): at org.apache.hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations.testClusterIdMismatchAtStartupWithHA(TestDataNodeMultipleRegistrations.java:249) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10544//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10544//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10544//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10544//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10544//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10544//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10544//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10544//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10544//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10544//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10544//console This message is automatically generated.
        Hide
        Alex Newman added a comment -

        Can this be closed?

        Show
        Alex Newman added a comment - Can this be closed?
        Hide
        stack added a comment -

        Can this be closed?

        Is it committed? It doesn't seem to be.

        Show
        stack added a comment - Can this be closed? Is it committed? It doesn't seem to be.
        Hide
        Jeffrey Zhong added a comment -

        rebased the v4 patch against master. The patch is long due. Enis Soztutar could u please give a quick review? I think the old v4 patch is in "ready" state but somehow it's left over. Thanks.

        Show
        Jeffrey Zhong added a comment - rebased the v4 patch against master. The patch is long due. Enis Soztutar could u please give a quick review? I think the old v4 patch is in "ready" state but somehow it's left over. Thanks.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12696622/HBASE-11567-v4-rebase.patch
        against master branch at commit 8aeb3acaf959e2905191fd6c92fa56300f7d3597.
        ATTACHMENT ID: 12696622

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 11 new or modified tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 checkstyle. The applied patch generated 1946 checkstyle errors (more than the master's current 1941 errors).

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 lineLengths. The patch introduces the following lines longer than 100:
        + new java.lang.String[]

        { "TableName", "EncodedRegionName", "Stores", "BulkloadSeqNum", }

        );
        + * @param assignSeqId Force a flush, get it's sequenceId to preserve the guarantee that all the
        + * edits lower than the highest sequential ID from all the HFiles are flushed
        + list.append("\n").append(Bytes.toString(p.getFirst())).append(" : ").append(p.getSecond());

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles

        -1 core zombie tests. There are 1 zombie test(s): at org.apache.camel.component.jetty.jettyproducer.HttpJettyProducerRecipientListCustomThreadPoolTest.testRecipientList(HttpJettyProducerRecipientListCustomThreadPoolTest.java:40)

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
        Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//artifact/patchprocess/checkstyle-aggregate.html

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12696622/HBASE-11567-v4-rebase.patch against master branch at commit 8aeb3acaf959e2905191fd6c92fa56300f7d3597. ATTACHMENT ID: 12696622 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 11 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 checkstyle . The applied patch generated 1946 checkstyle errors (more than the master's current 1941 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + new java.lang.String[] { "TableName", "EncodedRegionName", "Stores", "BulkloadSeqNum", } ); + * @param assignSeqId Force a flush, get it's sequenceId to preserve the guarantee that all the + * edits lower than the highest sequential ID from all the HFiles are flushed + list.append("\n").append(Bytes.toString(p.getFirst())).append(" : ").append(p.getSecond()); +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles -1 core zombie tests . There are 1 zombie test(s): at org.apache.camel.component.jetty.jettyproducer.HttpJettyProducerRecipientListCustomThreadPoolTest.testRecipientList(HttpJettyProducerRecipientListCustomThreadPoolTest.java:40) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12700//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12696680/HBASE-11567-v4-rebase.patch
        against master branch at commit 8aeb3acaf959e2905191fd6c92fa56300f7d3597.
        ATTACHMENT ID: 12696680

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 11 new or modified tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//artifact/patchprocess/checkstyle-aggregate.html

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12696680/HBASE-11567-v4-rebase.patch against master branch at commit 8aeb3acaf959e2905191fd6c92fa56300f7d3597. ATTACHMENT ID: 12696680 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 11 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12705//console This message is automatically generated.
        Hide
        Enis Soztutar added a comment -

        One unfortunate thing is that the refactor of {{message StoreDescriptor }} may not be compatible. It seems that branch-1.0 contains the RegionEventDescriptor. If 1.0.0 does not sink, we may not be able to do that change. Let me check that.

        Show
        Enis Soztutar added a comment - One unfortunate thing is that the refactor of {{message StoreDescriptor }} may not be compatible. It seems that branch-1.0 contains the RegionEventDescriptor. If 1.0.0 does not sink, we may not be able to do that change. Let me check that.
        Hide
        Enis Soztutar added a comment -

        Can you change this following:

        +    WALKey key = new WALKey(info.getEncodedNameAsBytes(), tn);
        

        to

            // we use HLogKey here instead of WALKey directly to support legacy coprocessors.
            WALKey key = new HLogKey(info.getEncodedNameAsBytes(), tn);
        

        The other similar methods in WALUtil (writeCompactionMarker) does that. Other than that +1.
        I have checked the PB refactor I was talking about earlier. It seems it is compatible in wire format, and I also tried manually serializing and deserializing with this change.

        Show
        Enis Soztutar added a comment - Can you change this following: + WALKey key = new WALKey(info.getEncodedNameAsBytes(), tn); to // we use HLogKey here instead of WALKey directly to support legacy coprocessors. WALKey key = new HLogKey(info.getEncodedNameAsBytes(), tn); The other similar methods in WALUtil (writeCompactionMarker) does that. Other than that +1. I have checked the PB refactor I was talking about earlier. It seems it is compatible in wire format, and I also tried manually serializing and deserializing with this change.
        Hide
        Enis Soztutar added a comment -

        I'll commit the attached partial patch to branch-1.0 as well to be on the safe side for the PB changes. It is trivial changes moving the PB inner message object to the outer scope.

        Show
        Enis Soztutar added a comment - I'll commit the attached partial patch to branch-1.0 as well to be on the safe side for the PB changes. It is trivial changes moving the PB inner message object to the outer scope.
        Hide
        Jeffrey Zhong added a comment -

        Thanks Alex Newman for the contributions! I've integrated the v4-rebase patch into master and branch-1.

        Show
        Jeffrey Zhong added a comment - Thanks Alex Newman for the contributions! I've integrated the v4-rebase patch into master and branch-1.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12697205/hbase-11567-branch-1.0-partial.patch
        against branch-1.0 branch at commit 7f4146bf4d4df84041b284a76d917d602b5531da.
        ATTACHMENT ID: 12697205

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 javadoc. The javadoc tool appears to have generated 9 warning messages.

        +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
        Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/checkstyle-aggregate.html

        Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/patchJavadocWarnings.txt
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12697205/hbase-11567-branch-1.0-partial.patch against branch-1.0 branch at commit 7f4146bf4d4df84041b284a76d917d602b5531da. ATTACHMENT ID: 12697205 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 9 warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12730//console This message is automatically generated.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-1.0 #720 (See https://builds.apache.org/job/HBase-1.0/720/)
        HBASE-11567 Write bulk load COMMIT events to WAL (Only partial patch containing PB changes) (enis: rev 2395d69c23dccba029659a5f28d72631494fee8f)

        • hbase-protocol/src/main/protobuf/WAL.proto
        • hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/VisibilityLabelsProtos.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
        • hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/WALProtos.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-1.0 #720 (See https://builds.apache.org/job/HBase-1.0/720/ ) HBASE-11567 Write bulk load COMMIT events to WAL (Only partial patch containing PB changes) (enis: rev 2395d69c23dccba029659a5f28d72631494fee8f) hbase-protocol/src/main/protobuf/WAL.proto hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/VisibilityLabelsProtos.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/WALProtos.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #6103 (See https://builds.apache.org/job/HBase-TRUNK/6103/)
        HBASE-11567 Write bulk load COMMIT events to WAL (Alex Newman, Jeffrey Zhong) (jeffreyz: rev 3f4427739d9ff698d39f2687f11f65967c67340d)

        • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoad.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEdit.java
        • hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/FilterProtos.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALActionsListener.java
        • pom.xml
        • hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/VisibilityLabelsProtos.java
        • hbase-protocol/src/main/protobuf/WAL.proto
        • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALUtil.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        • hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/WALProtos.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #6103 (See https://builds.apache.org/job/HBase-TRUNK/6103/ ) HBASE-11567 Write bulk load COMMIT events to WAL (Alex Newman, Jeffrey Zhong) (jeffreyz: rev 3f4427739d9ff698d39f2687f11f65967c67340d) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoad.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEdit.java hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/FilterProtos.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALActionsListener.java pom.xml hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/VisibilityLabelsProtos.java hbase-protocol/src/main/protobuf/WAL.proto hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALUtil.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/WALProtos.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-1.1 #154 (See https://builds.apache.org/job/HBase-1.1/154/)
        HBASE-11567 Write bulk load COMMIT events to WAL (jeffreyz: rev b0b0a74fef6382643c6ff8d07167ad90ff0d7c43)

        • hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/FilterProtos.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        • pom.xml
        • hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/WALProtos.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALUtil.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEdit.java
        • hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/VisibilityLabelsProtos.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoad.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
        • hbase-protocol/src/main/protobuf/WAL.proto
        • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALActionsListener.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-1.1 #154 (See https://builds.apache.org/job/HBase-1.1/154/ ) HBASE-11567 Write bulk load COMMIT events to WAL (jeffreyz: rev b0b0a74fef6382643c6ff8d07167ad90ff0d7c43) hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/FilterProtos.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java pom.xml hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/WALProtos.java hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALUtil.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEdit.java hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/VisibilityLabelsProtos.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoad.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java hbase-protocol/src/main/protobuf/WAL.proto hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALActionsListener.java
        Hide
        Nick Dimiduk added a comment -

        Closing issues released in 1.1.0.

        Show
        Nick Dimiduk added a comment - Closing issues released in 1.1.0.

          People

          • Assignee:
            Alex Newman
            Reporter:
            Enis Soztutar
          • Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development