HBase
  1. HBase
  2. HBASE-11535

ReplicationPeer map is not thread safe

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.98.4
    • Fix Version/s: 0.99.0, 2.0.0, 0.98.6
    • Component/s: Replication
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      ReplicationPeersZKImpl has a map of Peer id to ReplicationPeer which is accessed by replication source threads through getStatusOfPeer(). So, it needs to be thread safe.

      1. HBASE-11535.patch
        3 kB
        Virag Kothari
      2. HBASE-11535.patch
        3 kB
        Virag Kothari
      3. HBASE-11535_98.patch
        3 kB
        Virag Kothari

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12656234/HBASE-11535.patch
        against trunk revision .
        ATTACHMENT ID: 12656234

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.mapred.TestTableSnapshotInputFormat

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10106//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10106//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10106//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10106//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10106//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10106//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10106//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10106//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10106//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10106//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10106//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12656234/HBASE-11535.patch against trunk revision . ATTACHMENT ID: 12656234 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.mapred.TestTableSnapshotInputFormat Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10106//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10106//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10106//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10106//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10106//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10106//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10106//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10106//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10106//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10106//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10106//console This message is automatically generated.
        Hide
        Andrew Purtell added a comment -

        lgtm

        Show
        Andrew Purtell added a comment - lgtm
        Hide
        Jonathan Hsieh added a comment -

        hi Virag Kothari, i think you missed the usage in peerRemoved (need to use the atomic remove method there). Also though this applies to trunk and branch-1 it does not to 0.98. If you want the fix there it would be great if you could provide a 0.98 version of the patch as well.

        Show
        Jonathan Hsieh added a comment - hi Virag Kothari , i think you missed the usage in peerRemoved (need to use the atomic remove method there). Also though this applies to trunk and branch-1 it does not to 0.98. If you want the fix there it would be great if you could provide a 0.98 version of the patch as well.
        Hide
        Virag Kothari added a comment -

        Thanks for pointing that Jonathan Hsieh. Updated based on your comments and also provided a 0.98 patch

        Show
        Virag Kothari added a comment - Thanks for pointing that Jonathan Hsieh . Updated based on your comments and also provided a 0.98 patch
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12660179/HBASE-11535_98.patch
        against trunk revision .
        ATTACHMENT ID: 12660179

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10322//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12660179/HBASE-11535_98.patch against trunk revision . ATTACHMENT ID: 12660179 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10322//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12660177/HBASE-11535.patch
        against trunk revision .
        ATTACHMENT ID: 12660177

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.procedure.TestProcedureManager
        org.apache.hadoop.hbase.ipc.TestIPC
        org.apache.hadoop.hbase.master.TestClockSkewDetection

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10321//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10321//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10321//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10321//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10321//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10321//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10321//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10321//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10321//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10321//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10321//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12660177/HBASE-11535.patch against trunk revision . ATTACHMENT ID: 12660177 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.procedure.TestProcedureManager org.apache.hadoop.hbase.ipc.TestIPC org.apache.hadoop.hbase.master.TestClockSkewDetection Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10321//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10321//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10321//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10321//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10321//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10321//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10321//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10321//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10321//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10321//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10321//console This message is automatically generated.
        Hide
        Jonathan Hsieh added a comment -

        +1.

        Thanks for the patch virag! The patches had essentially 2 +1's and shouldn't affect cause problems so I've committed to 0.98, branch-1 and master.

        Show
        Jonathan Hsieh added a comment - +1. Thanks for the patch virag! The patches had essentially 2 +1's and shouldn't affect cause problems so I've committed to 0.98, branch-1 and master.
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98 #438 (See https://builds.apache.org/job/HBase-0.98/438/)
        HBASE-11535 ReplicationPeer map is not thread safe (Virag Kothari) (jon: rev c8812737bb53016ec18738061b9c2a18ca8c0ad8)

        • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #438 (See https://builds.apache.org/job/HBase-0.98/438/ ) HBASE-11535 ReplicationPeer map is not thread safe (Virag Kothari) (jon: rev c8812737bb53016ec18738061b9c2a18ca8c0ad8) hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #5375 (See https://builds.apache.org/job/HBase-TRUNK/5375/)
        HBASE-11535 ReplicationPeer map is not thread safe (Virag Kothari) (jmhsieh: rev 6dee406bf359eec31883cdb2714399a8161a4c26)

        • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5375 (See https://builds.apache.org/job/HBase-TRUNK/5375/ ) HBASE-11535 ReplicationPeer map is not thread safe (Virag Kothari) (jmhsieh: rev 6dee406bf359eec31883cdb2714399a8161a4c26) hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-1.0 #88 (See https://builds.apache.org/job/HBase-1.0/88/)
        HBASE-11535 ReplicationPeer map is not thread safe (Virag Kothari) (jmhsieh: rev 058ac502f367cbaf1a44db9d9d0b0a112b00c5c5)

        • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-1.0 #88 (See https://builds.apache.org/job/HBase-1.0/88/ ) HBASE-11535 ReplicationPeer map is not thread safe (Virag Kothari) (jmhsieh: rev 058ac502f367cbaf1a44db9d9d0b0a112b00c5c5) hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #413 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/413/)
        HBASE-11535 ReplicationPeer map is not thread safe (Virag Kothari) (jon: rev c8812737bb53016ec18738061b9c2a18ca8c0ad8)

        • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #413 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/413/ ) HBASE-11535 ReplicationPeer map is not thread safe (Virag Kothari) (jon: rev c8812737bb53016ec18738061b9c2a18ca8c0ad8) hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java
        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

          People

          • Assignee:
            Virag Kothari
            Reporter:
            Virag Kothari
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development