HBase
  1. HBase
  2. HBASE-11534

Remove broken JAVA_HOME autodetection in hbase-config.sh

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.99.0, 0.98.5, 2.0.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      This change removes old and increasingly useless JAVA_HOME autodetection that looks for Java 6 runtimes in various locations. Ensure that JAVA_HOME is correctly set in the environment before launching HBase daemons.

      Description

      Allen Wittenauer mentioned on Twitter that the old JAVA_HOME autodetection script we have in hbase-config.sh is very unlikely to do the right thing now. Rip it out.

      1. HBASE-11534.patch
        1 kB
        Esteban Gutierrez

        Activity

        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98 #405 (See https://builds.apache.org/job/HBase-0.98/405/)
        HBASE-11534 Remove broken JAVA_HOME autodetection in hbase-config.sh (Esteban Gutierrez) (apurtell: rev 1627b16160be8619922defefefad1761f20d9b5b)

        • bin/hbase-config.sh
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #405 (See https://builds.apache.org/job/HBase-0.98/405/ ) HBASE-11534 Remove broken JAVA_HOME autodetection in hbase-config.sh (Esteban Gutierrez) (apurtell: rev 1627b16160be8619922defefefad1761f20d9b5b) bin/hbase-config.sh
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-1.0 #56 (See https://builds.apache.org/job/HBase-1.0/56/)
        HBASE-11534 Remove broken JAVA_HOME autodetection in hbase-config.sh (Esteban Gutierrez) (apurtell: rev f6fad0a2b971fc70f48618e18811c3de4909d5a7)

        • bin/hbase-config.sh
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-1.0 #56 (See https://builds.apache.org/job/HBase-1.0/56/ ) HBASE-11534 Remove broken JAVA_HOME autodetection in hbase-config.sh (Esteban Gutierrez) (apurtell: rev f6fad0a2b971fc70f48618e18811c3de4909d5a7) bin/hbase-config.sh
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #385 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/385/)
        HBASE-11534 Remove broken JAVA_HOME autodetection in hbase-config.sh (Esteban Gutierrez) (apurtell: rev 1627b16160be8619922defefefad1761f20d9b5b)

        • bin/hbase-config.sh
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #385 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/385/ ) HBASE-11534 Remove broken JAVA_HOME autodetection in hbase-config.sh (Esteban Gutierrez) (apurtell: rev 1627b16160be8619922defefefad1761f20d9b5b) bin/hbase-config.sh
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #5322 (See https://builds.apache.org/job/HBase-TRUNK/5322/)
        HBASE-11534 Remove broken JAVA_HOME autodetection in hbase-config.sh (Esteban Gutierrez) (apurtell: rev a030b17ba7e4061215f6e2f6d6f9de54ba950bed)

        • bin/hbase-config.sh
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5322 (See https://builds.apache.org/job/HBase-TRUNK/5322/ ) HBASE-11534 Remove broken JAVA_HOME autodetection in hbase-config.sh (Esteban Gutierrez) (apurtell: rev a030b17ba7e4061215f6e2f6d6f9de54ba950bed) bin/hbase-config.sh
        Hide
        Andrew Purtell added a comment -

        Committed to 0.98+. Thanks for the patch Esteban Gutierrez!

        Show
        Andrew Purtell added a comment - Committed to 0.98+. Thanks for the patch Esteban Gutierrez !
        Hide
        Andrew Purtell added a comment -

        I disagree about 0.98 but will leave out 0.94 and 0.96.

        Show
        Andrew Purtell added a comment - I disagree about 0.98 but will leave out 0.94 and 0.96.
        Hide
        Esteban Gutierrez added a comment -

        +1 Lars Hofhansl and I'd say we should have it only for 0.99 and trunk. I think is too late for this change in 0.98.x and 0.96.x. Also we need to make sure that the release notes consider this as an major change that might break some environments if JAVA_HOME is not defined.

        Show
        Esteban Gutierrez added a comment - +1 Lars Hofhansl and I'd say we should have it only for 0.99 and trunk. I think is too late for this change in 0.98.x and 0.96.x. Also we need to make sure that the release notes consider this as an major change that might break some environments if JAVA_HOME is not defined.
        Hide
        Lars Hofhansl added a comment -

        Let's not change this in 0.94. It might accidentally be doing the right thing for some folks.

        Show
        Lars Hofhansl added a comment - Let's not change this in 0.94. It might accidentally be doing the right thing for some folks.
        Hide
        Enis Soztutar added a comment -

        +1.

        Show
        Enis Soztutar added a comment - +1.
        Hide
        Andrew Purtell added a comment -

        Going to commit in a few hours unless objection.

        Show
        Andrew Purtell added a comment - Going to commit in a few hours unless objection.
        Hide
        Allen Wittenauer added a comment -

        FWIW, I'm a big fan of "Let the installer figure this out." i.e., this is one place where having a distribution (bigtop or otherwise) is ideal because they can get away with taking a lot of time to configure and tune the system as a one-time operation. Taking the hit every time is...excessive.

        Anyway, kudos for fixing this.

        Show
        Allen Wittenauer added a comment - FWIW, I'm a big fan of "Let the installer figure this out." i.e., this is one place where having a distribution (bigtop or otherwise) is ideal because they can get away with taking a lot of time to configure and tune the system as a one-time operation. Taking the hit every time is...excessive. Anyway, kudos for fixing this.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12656230/HBASE-11534.patch
        against trunk revision .
        ATTACHMENT ID: 12656230

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10105//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12656230/HBASE-11534.patch against trunk revision . ATTACHMENT ID: 12656230 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10105//console This message is automatically generated.
        Hide
        Andrew Purtell added a comment -
        Show
        Andrew Purtell added a comment - +1 Ping Lars Hofhansl , Enis Soztutar
        Hide
        Esteban Gutierrez added a comment -

        Good call! attached patch.

        Show
        Esteban Gutierrez added a comment - Good call! attached patch.
        Hide
        Andrew Purtell added a comment -

        I don't see why we just don't require JAVA_HOME to be set up in the environment. Then we are sure we are executing the desired JVM.

        Show
        Andrew Purtell added a comment - I don't see why we just don't require JAVA_HOME to be set up in the environment. Then we are sure we are executing the desired JVM.
        Show
        Esteban Gutierrez added a comment - What about using the same script from Bigtop? https://github.com/apache/bigtop/blob/master/bigtop-packages/src/common/bigtop-utils/bigtop-detect-javahome

          People

          • Assignee:
            Esteban Gutierrez
            Reporter:
            Andrew Purtell
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development