HBase
  1. HBase
  2. HBASE-11527

Cluster free memory limit check should consider L2 block cache size also when L2 cache is onheap.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.99.0, 2.0.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      The sum of the heap size % used by Memstore (Configured using 'hbase.regionserver.global.memstore.size' and defaults to 40%) and the that of block cache (Configured using 'hfile.block.cache.size' and defaults to 40%) should leave enough heap size for other normal operations of RS. This is 20%. Also to be noted that when the L2 block cache (ie. Bucket cache) is configured to be on heap, the size of that also comes into this size math. So in that case the sum of memstore heap size, L1 block cache size and L2 cache size (Configured using 'hbase.bucketcache.size')can be at max 80%.
      When automatic tuning of heap memory is enabled (HBASE-5349) at point of time this 80% cap should hold.
      Show
      The sum of the heap size % used by Memstore (Configured using 'hbase.regionserver.global.memstore.size' and defaults to 40%) and the that of block cache (Configured using 'hfile.block.cache.size' and defaults to 40%) should leave enough heap size for other normal operations of RS. This is 20%. Also to be noted that when the L2 block cache (ie. Bucket cache) is configured to be on heap, the size of that also comes into this size math. So in that case the sum of memstore heap size, L1 block cache size and L2 cache size (Configured using 'hbase.bucketcache.size')can be at max 80%. When automatic tuning of heap memory is enabled ( HBASE-5349 ) at point of time this 80% cap should hold.
    1. HBASE-11527_addendum.patch
      8 kB
      Anoop Sam John
    2. HBASE-11527_0.99.patch
      36 kB
      Anoop Sam John
    3. HBASE-11527.patch
      30 kB
      Anoop Sam John

      Activity

      Hide
      Enis Soztutar added a comment -

      Closing this issue after 0.99.0 release.

      Show
      Enis Soztutar added a comment - Closing this issue after 0.99.0 release.
      Hide
      Enis Soztutar added a comment -

      late +1 for branch-1. Thanks Anoop, Stack.

      Show
      Enis Soztutar added a comment - late +1 for branch-1. Thanks Anoop, Stack.
      Hide
      Hudson added a comment -

      FAILURE: Integrated in HBase-1.0 #93 (See https://builds.apache.org/job/HBase-1.0/93/)
      HBASE-11527 Cluster free memory limit check should consider L2 block cache size also when L2 cache is onheap. (Anoop) (anoopsamjohn: rev 886ae4691f03afa29d24102f18d7f8545ea1791c)

      • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
      • hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java
      • hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestBlockCacheReporting.java
      • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemoryManager.java
      • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultHeapMemoryTuner.java
      • hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseConfiguration.java
      • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
      • hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
      • hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheConfig.java
      • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreChunkPool.java
      • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHeapMemoryManager.java
      • hbase-common/src/main/java/org/apache/hadoop/hbase/io/util/HeapMemorySizeUtil.java
      Show
      Hudson added a comment - FAILURE: Integrated in HBase-1.0 #93 (See https://builds.apache.org/job/HBase-1.0/93/ ) HBASE-11527 Cluster free memory limit check should consider L2 block cache size also when L2 cache is onheap. (Anoop) (anoopsamjohn: rev 886ae4691f03afa29d24102f18d7f8545ea1791c) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestBlockCacheReporting.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemoryManager.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultHeapMemoryTuner.java hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseConfiguration.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheConfig.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreChunkPool.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHeapMemoryManager.java hbase-common/src/main/java/org/apache/hadoop/hbase/io/util/HeapMemorySizeUtil.java
      Hide
      Anoop Sam John added a comment -

      Looks like Enis Soztutar is still away. As this is a bug fix, I am going ahead with commit to branch-1 also.

      Show
      Anoop Sam John added a comment - Looks like Enis Soztutar is still away. As this is a bug fix, I am going ahead with commit to branch-1 also.
      Hide
      Hudson added a comment -

      FAILURE: Integrated in HBase-TRUNK #5386 (See https://builds.apache.org/job/HBase-TRUNK/5386/)
      HBASE-11527 Cluster free memory limit check should consider L2 block cache size also when L2 cache is onheap. (Anoop) (anoopsamjohn: rev d7011a9dcc7050d7eaaffcfb78b308a07ff4bdfe)

      • hbase-common/src/main/java/org/apache/hadoop/hbase/io/util/HeapMemorySizeUtil.java
      • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemoryManager.java
      • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHeapMemoryManager.java
      Show
      Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5386 (See https://builds.apache.org/job/HBase-TRUNK/5386/ ) HBASE-11527 Cluster free memory limit check should consider L2 block cache size also when L2 cache is onheap. (Anoop) (anoopsamjohn: rev d7011a9dcc7050d7eaaffcfb78b308a07ff4bdfe) hbase-common/src/main/java/org/apache/hadoop/hbase/io/util/HeapMemorySizeUtil.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemoryManager.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHeapMemoryManager.java
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12660627/HBASE-11527_addendum.patch
      against trunk revision .
      ATTACHMENT ID: 12660627

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified tests.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 lineLengths. The patch does not introduce lines longer than 100

      +1 site. The mvn site goal succeeds with this patch.

      -1 core tests. The patch failed these unit tests:

      -1 core zombie tests. There are 1 zombie test(s): at org.apache.hadoop.hbase.client.TestCloneSnapshotFromClient.testCloneSnapshot(TestCloneSnapshotFromClient.java:176)
      at org.apache.hadoop.hbase.client.TestCloneSnapshotFromClient.testCloneSnapshotCrossNamespace(TestCloneSnapshotFromClient.java:190)

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10352//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10352//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10352//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10352//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10352//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10352//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10352//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10352//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10352//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10352//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10352//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12660627/HBASE-11527_addendum.patch against trunk revision . ATTACHMENT ID: 12660627 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: -1 core zombie tests . There are 1 zombie test(s): at org.apache.hadoop.hbase.client.TestCloneSnapshotFromClient.testCloneSnapshot(TestCloneSnapshotFromClient.java:176) at org.apache.hadoop.hbase.client.TestCloneSnapshotFromClient.testCloneSnapshotCrossNamespace(TestCloneSnapshotFromClient.java:190) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10352//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10352//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10352//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10352//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10352//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10352//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10352//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10352//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10352//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10352//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10352//console This message is automatically generated.
      Hide
      Anoop Sam John added a comment -

      getL2BlockCacheHeapPercent returns 0 if l2 is offheap?

      Yes Stack.
      Will commit addendum to master.
      Ping Enis Soztutar for commit to branch-1

      Show
      Anoop Sam John added a comment - getL2BlockCacheHeapPercent returns 0 if l2 is offheap? Yes Stack. Will commit addendum to master. Ping Enis Soztutar for commit to branch-1
      Hide
      stack added a comment -

      getL2BlockCacheHeapPercent returns 0 if l2 is offheap? If so +1. Nice test Anoop Sam John

      Show
      stack added a comment - getL2BlockCacheHeapPercent returns 0 if l2 is offheap? If so +1. Nice test Anoop Sam John
      Hide
      Anoop Sam John added a comment -

      master addendum with a test

      Show
      Anoop Sam John added a comment - master addendum with a test
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12660394/HBASE-11527_addendum.patch
      against trunk revision .
      ATTACHMENT ID: 12660394

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

      +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 lineLengths. The patch does not introduce lines longer than 100

      +1 site. The mvn site goal succeeds with this patch.

      +1 core tests. The patch passed unit tests in .

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10339//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10339//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10339//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10339//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10339//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10339//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10339//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10339//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10339//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10339//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10339//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12660394/HBASE-11527_addendum.patch against trunk revision . ATTACHMENT ID: 12660394 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10339//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10339//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10339//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10339//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10339//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10339//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10339//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10339//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10339//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10339//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10339//console This message is automatically generated.
      Hide
      Anoop Sam John added a comment -

      Yes on heap. I can add a test to TestHeapMemoryManager where L2 heap cache is also present. Let me check. Will give patch tomorrow boss.

      Show
      Anoop Sam John added a comment - Yes on heap. I can add a test to TestHeapMemoryManager where L2 heap cache is also present. Let me check. Will give patch tomorrow boss.
      Hide
      stack added a comment -

      Anoop Sam John This calculation is only for the onheap right? patch looks good but how about a test?

      Show
      stack added a comment - Anoop Sam John This calculation is only for the onheap right? patch looks good but how about a test?
      Hide
      Anoop Sam John added a comment -

      I have missed considering the L2 block cache heap size in checking the size rule for max memstore heap vs min block cache heap and min memstore heap vs max block cache heap. This addendum is fixes that. Will give branch-1 patch also soon.

      Show
      Anoop Sam John added a comment - I have missed considering the L2 block cache heap size in checking the size rule for max memstore heap vs min block cache heap and min memstore heap vs max block cache heap. This addendum is fixes that. Will give branch-1 patch also soon.
      Hide
      Anoop Sam John added a comment -

      Sure let me make patch for branch-1 as well. Reopening the jira.

      Show
      Anoop Sam John added a comment - Sure let me make patch for branch-1 as well. Reopening the jira.
      Hide
      stack added a comment -

      Anoop Sam John Can you add release note sir? Should this come back into branch-1 as addition to our ergonomic story where mem sizing shifts with work load?

      Show
      stack added a comment - Anoop Sam John Can you add release note sir? Should this come back into branch-1 as addition to our ergonomic story where mem sizing shifts with work load?
      Hide
      Hudson added a comment -

      FAILURE: Integrated in HBase-TRUNK #5378 (See https://builds.apache.org/job/HBase-TRUNK/5378/)
      HBASE-11527 Cluster free memory limit check should consider L2 block cache size also when L2 cache is onheap. (Anoop) (anoopsamjohn: rev 12d9697d934df90e0ed0261aa20446120c1086a6)

      • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreChunkPool.java
      • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
      • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
      • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultHeapMemoryTuner.java
      • hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
      • hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseConfiguration.java
      • hbase-common/src/main/java/org/apache/hadoop/hbase/io/util/HeapMemorySizeUtil.java
      • hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestBlockCacheReporting.java
      • hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheConfig.java
      • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemoryManager.java
      • hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java
      Show
      Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5378 (See https://builds.apache.org/job/HBase-TRUNK/5378/ ) HBASE-11527 Cluster free memory limit check should consider L2 block cache size also when L2 cache is onheap. (Anoop) (anoopsamjohn: rev 12d9697d934df90e0ed0261aa20446120c1086a6) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreChunkPool.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultHeapMemoryTuner.java hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseConfiguration.java hbase-common/src/main/java/org/apache/hadoop/hbase/io/util/HeapMemorySizeUtil.java hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestBlockCacheReporting.java hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheConfig.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemoryManager.java hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java
      Hide
      Anoop Sam John added a comment -

      Thanks Stack for the review. I have added a TODO in HConstants as suggested.
      Pushed to master.

      Show
      Anoop Sam John added a comment - Thanks Stack for the review. I have added a TODO in HConstants as suggested. Pushed to master.
      Hide
      stack added a comment -

      I don't like your moving block cache implementation detail up out of io.hfile package up into the global HConstants mess but I like the rest of your patch more than I dislike this violation of encapsulation. +1 to commit if on commit you add TODO in HConstants that admits these added defines violations and suggests moving block-cache to hbase-commons or some such (it'd be kinda cool if block cache implementations could be detached from hbase-server and hfiles.....).

      Good work Anoop Sam John

      Show
      stack added a comment - I don't like your moving block cache implementation detail up out of io.hfile package up into the global HConstants mess but I like the rest of your patch more than I dislike this violation of encapsulation. +1 to commit if on commit you add TODO in HConstants that admits these added defines violations and suggests moving block-cache to hbase-commons or some such (it'd be kinda cool if block cache implementations could be detached from hbase-server and hfiles.....). Good work Anoop Sam John
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12659110/HBASE-11527.patch
      against trunk revision .
      ATTACHMENT ID: 12659110

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 6 new or modified tests.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 lineLengths. The patch does not introduce lines longer than 100

      +1 site. The mvn site goal succeeds with this patch.

      -1 core tests. The patch failed these unit tests:
      org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas
      org.apache.hadoop.hbase.regionserver.TestHRegion
      org.apache.hadoop.hbase.master.TestZKLessAMOnCluster
      org.apache.hadoop.hbase.TestRegionRebalancing
      org.apache.hadoop.hbase.regionserver.TestRegionReplicas
      org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
      org.apache.hadoop.hbase.master.TestRestartCluster
      org.apache.hadoop.hbase.client.TestReplicasClient
      org.apache.hadoop.hbase.TestIOFencing

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10260//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10260//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10260//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10260//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10260//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10260//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10260//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10260//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10260//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10260//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10260//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12659110/HBASE-11527.patch against trunk revision . ATTACHMENT ID: 12659110 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas org.apache.hadoop.hbase.regionserver.TestHRegion org.apache.hadoop.hbase.master.TestZKLessAMOnCluster org.apache.hadoop.hbase.TestRegionRebalancing org.apache.hadoop.hbase.regionserver.TestRegionReplicas org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction org.apache.hadoop.hbase.master.TestRestartCluster org.apache.hadoop.hbase.client.TestReplicasClient org.apache.hadoop.hbase.TestIOFencing Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10260//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10260//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10260//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10260//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10260//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10260//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10260//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10260//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10260//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10260//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10260//console This message is automatically generated.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12658668/HBASE-11527.patch
      against trunk revision .
      ATTACHMENT ID: 12658668

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 6 new or modified tests.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

      +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 lineLengths. The patch does not introduce lines longer than 100

      +1 site. The mvn site goal succeeds with this patch.

      -1 core tests. The patch failed these unit tests:
      org.apache.hadoop.hbase.TestIOFencing
      org.apache.hadoop.hbase.master.TestRestartCluster
      org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
      org.apache.hadoop.hbase.regionserver.TestRegionReplicas
      org.apache.hadoop.hbase.client.TestReplicasClient
      org.apache.hadoop.hbase.migration.TestNamespaceUpgrade
      org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10227//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10227//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10227//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10227//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10227//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10227//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10227//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10227//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10227//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10227//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10227//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12658668/HBASE-11527.patch against trunk revision . ATTACHMENT ID: 12658668 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.TestIOFencing org.apache.hadoop.hbase.master.TestRestartCluster org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction org.apache.hadoop.hbase.regionserver.TestRegionReplicas org.apache.hadoop.hbase.client.TestReplicasClient org.apache.hadoop.hbase.migration.TestNamespaceUpgrade org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10227//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10227//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10227//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10227//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10227//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10227//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10227//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10227//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10227//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10227//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10227//console This message is automatically generated.
      Hide
      Anoop Sam John added a comment -

      Only nit is your moving of CacheConfig Constants up to HConstant. Do you have to?

      Because referring that in HeapMemorySizeUtil also and this needs to be in hbase-common. So we can not refer to CacheConfig as that is in hbase-server.

      Show
      Anoop Sam John added a comment - Only nit is your moving of CacheConfig Constants up to HConstant. Do you have to? Because referring that in HeapMemorySizeUtil also and this needs to be in hbase-common. So we can not refer to CacheConfig as that is in hbase-server.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12658589/HBASE-11527.patch
      against trunk revision .
      ATTACHMENT ID: 12658589

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 6 new or modified tests.

      -1 patch. The patch command could not apply the patch.

      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10221//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12658589/HBASE-11527.patch against trunk revision . ATTACHMENT ID: 12658589 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10221//console This message is automatically generated.
      Hide
      stack added a comment -

      Retry

      Show
      stack added a comment - Retry
      Hide
      stack added a comment -

      Very nice. Only nit is your moving of CacheConfig Constants up to HConstant. Do you have to? Rerun through hadoopqa again too boss to be sure.

      Show
      stack added a comment - Very nice. Only nit is your moving of CacheConfig Constants up to HConstant. Do you have to? Rerun through hadoopqa again too boss to be sure.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12657585/HBASE-11527.patch
      against trunk revision .
      ATTACHMENT ID: 12657585

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 6 new or modified tests.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

      +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 lineLengths. The patch does not introduce lines longer than 100

      +1 site. The mvn site goal succeeds with this patch.

      -1 core tests. The patch failed these unit tests:

      -1 core zombie tests. There are 1 zombie test(s):

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10176//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10176//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10176//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10176//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10176//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10176//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10176//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10176//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10176//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10176//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10176//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12657585/HBASE-11527.patch against trunk revision . ATTACHMENT ID: 12657585 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: -1 core zombie tests . There are 1 zombie test(s): Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10176//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10176//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10176//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10176//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10176//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10176//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10176//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10176//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10176//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10176//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10176//console This message is automatically generated.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12657584/HBASE-11527.patch
      against trunk revision .
      ATTACHMENT ID: 12657584

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 6 new or modified tests.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

      +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 lineLengths. The patch does not introduce lines longer than 100

      +1 site. The mvn site goal succeeds with this patch.

      -1 core tests. The patch failed these unit tests:
      org.apache.hadoop.hbase.regionserver.TestHeapMemoryManager
      org.apache.hadoop.hbase.io.hfile.TestCacheConfig

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10175//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10175//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10175//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10175//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10175//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10175//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10175//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10175//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10175//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10175//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10175//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12657584/HBASE-11527.patch against trunk revision . ATTACHMENT ID: 12657584 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestHeapMemoryManager org.apache.hadoop.hbase.io.hfile.TestCacheConfig Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10175//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10175//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10175//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10175//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10175//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10175//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10175//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10175//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10175//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10175//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10175//console This message is automatically generated.
      Hide
      Anoop Sam John added a comment -

      Rebased patch

      Show
      Anoop Sam John added a comment - Rebased patch
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12657560/HBASE-11527.patch
      against trunk revision .
      ATTACHMENT ID: 12657560

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 6 new or modified tests.

      -1 patch. The patch command could not apply the patch.

      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10174//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12657560/HBASE-11527.patch against trunk revision . ATTACHMENT ID: 12657560 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10174//console This message is automatically generated.
      Hide
      Anoop Sam John added a comment -

      Avoid some code duplication also.

      Ping stack

      Show
      Anoop Sam John added a comment - Avoid some code duplication also. Ping stack

        People

        • Assignee:
          Anoop Sam John
          Reporter:
          Anoop Sam John
        • Votes:
          0 Vote for this issue
          Watchers:
          7 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development