Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-11513

Combine SingleMultiple Queue RpcExecutor into a single class

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.99.0, 0.98.4, 2.0.0
    • Fix Version/s: 0.99.0, 0.98.4, 2.0.0
    • Component/s: io, regionserver
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Its a little odd that we use multiple classes, leading to mutliple if-else conditions for rpc execution when we could just combine them into one. Makes the logic and also puts the code into one place

      1. HBASE-11513.patch
        13 kB
        Andrew Purtell
      2. HBASE-11513-0.98.patch
        12 kB
        Andrew Purtell
      3. hbase-11513-v0.patch
        12 kB
        Jesse Yates

        Issue Links

          Activity

          Hide
          jesse_yates Jesse Yates added a comment -

          Combining the SingleQueueExecutor and MultipleQueueExecutor into a single class that manages the balancing internally. Minor improvement, but makes the code a bit simpler int he RpcScheduler.

          Matteo Bertozzi mind taking a look?

          Show
          jesse_yates Jesse Yates added a comment - Combining the SingleQueueExecutor and MultipleQueueExecutor into a single class that manages the balancing internally. Minor improvement, but makes the code a bit simpler int he RpcScheduler. Matteo Bertozzi mind taking a look?
          Hide
          mbertozzi Matteo Bertozzi added a comment -

          +1

          Show
          mbertozzi Matteo Bertozzi added a comment - +1
          Hide
          apurtell Andrew Purtell added a comment -

          +1

          Ping Enis Soztutar for branch-1.

          Will commit this just after HBASE-11497 later today.

          Show
          apurtell Andrew Purtell added a comment - +1 Ping Enis Soztutar for branch-1. Will commit this just after HBASE-11497 later today.
          Hide
          enis Enis Soztutar added a comment -

          Looks good for branch-1.

          Show
          enis Enis Soztutar added a comment - Looks good for branch-1.
          Hide
          jesse_yates Jesse Yates added a comment -

          Hmm, thought mine was on top of 0.98... oh well, thanks andy!

          Show
          jesse_yates Jesse Yates added a comment - Hmm, thought mine was on top of 0.98... oh well, thanks andy!
          Hide
          apurtell Andrew Purtell added a comment -

          Hmm, thought mine was on top of 0.98

          It was. I ported to master, cherry picked back to branch-1, then did so again to 0.98 because I changed whitespace. Committing momentarily. IPC tests pass locally Waiting for client tests to finish.

          Show
          apurtell Andrew Purtell added a comment - Hmm, thought mine was on top of 0.98 It was. I ported to master, cherry picked back to branch-1, then did so again to 0.98 because I changed whitespace. Committing momentarily. IPC tests pass locally Waiting for client tests to finish.
          Hide
          apurtell Andrew Purtell added a comment -

          Also will add missing file headers on commit.

          Show
          apurtell Andrew Purtell added a comment - Also will add missing file headers on commit.
          Hide
          jesse_yates Jesse Yates added a comment -

          You're the man! thanks

          Show
          jesse_yates Jesse Yates added a comment - You're the man! thanks
          Hide
          apurtell Andrew Purtell added a comment -

          Committed to 0.98+

          Show
          apurtell Andrew Purtell added a comment - Committed to 0.98+
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #5302 (See https://builds.apache.org/job/HBase-TRUNK/5302/)
          HBASE-11513 Combine SingleMultiple Queue RpcExecutor into a single class (Jesse Yates) (apurtell: rev 4824b0dea721790f7ff14af317620d26d931a18e)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SingleQueueRpcExecutor.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/BalancedQueueRpcExecutor.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MultipleQueueRpcExecutor.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5302 (See https://builds.apache.org/job/HBase-TRUNK/5302/ ) HBASE-11513 Combine SingleMultiple Queue RpcExecutor into a single class (Jesse Yates) (apurtell: rev 4824b0dea721790f7ff14af317620d26d931a18e) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SingleQueueRpcExecutor.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/BalancedQueueRpcExecutor.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MultipleQueueRpcExecutor.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-0.98 #399 (See https://builds.apache.org/job/HBase-0.98/399/)
          HBASE-11513 Combine SingleMultiple Queue RpcExecutor into a single class (Jesse Yates) (apurtell: rev 19fa2e346ce4386adfbd43516079157436b585d2)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SingleQueueRpcExecutor.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MultipleQueueRpcExecutor.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/BalancedQueueRpcExecutor.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-0.98 #399 (See https://builds.apache.org/job/HBase-0.98/399/ ) HBASE-11513 Combine SingleMultiple Queue RpcExecutor into a single class (Jesse Yates) (apurtell: rev 19fa2e346ce4386adfbd43516079157436b585d2) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SingleQueueRpcExecutor.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MultipleQueueRpcExecutor.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/BalancedQueueRpcExecutor.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #379 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/379/)
          HBASE-11513 Combine SingleMultiple Queue RpcExecutor into a single class (Jesse Yates) (apurtell: rev 19fa2e346ce4386adfbd43516079157436b585d2)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SingleQueueRpcExecutor.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MultipleQueueRpcExecutor.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/BalancedQueueRpcExecutor.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #379 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/379/ ) HBASE-11513 Combine SingleMultiple Queue RpcExecutor into a single class (Jesse Yates) (apurtell: rev 19fa2e346ce4386adfbd43516079157436b585d2) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SingleQueueRpcExecutor.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MultipleQueueRpcExecutor.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/BalancedQueueRpcExecutor.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.0 #41 (See https://builds.apache.org/job/HBase-1.0/41/)
          HBASE-11513 Combine SingleMultiple Queue RpcExecutor into a single class (Jesse Yates) (apurtell: rev 22f205b09b3f4c43a2ef95a177b9c66f4614cde4)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/BalancedQueueRpcExecutor.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SingleQueueRpcExecutor.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MultipleQueueRpcExecutor.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.0 #41 (See https://builds.apache.org/job/HBase-1.0/41/ ) HBASE-11513 Combine SingleMultiple Queue RpcExecutor into a single class (Jesse Yates) (apurtell: rev 22f205b09b3f4c43a2ef95a177b9c66f4614cde4) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/BalancedQueueRpcExecutor.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SingleQueueRpcExecutor.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MultipleQueueRpcExecutor.java
          Hide
          enis Enis Soztutar added a comment -

          Closing this issue after 0.99.0 release.

          Show
          enis Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

            People

            • Assignee:
              jesse_yates Jesse Yates
              Reporter:
              jesse_yates Jesse Yates
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development