HBase
  1. HBase
  2. HBASE-11491

Add an option to sleep randomly during the tests with the PE tool

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.99.0
    • Fix Version/s: 0.99.0, 2.0.0
    • Component/s: test
    • Labels:
      None

      Description

      This allows to find some interesting bugs....

      1. 11491.v1.withp1.patch
        8 kB
        Nicolas Liochon
      2. 11491.v1.patch
        8 kB
        Nicolas Liochon

        Activity

        Hide
        Ted Yu added a comment -

        lgtm

        Show
        Ted Yu added a comment - lgtm
        Hide
        Nick Dimiduk added a comment -

        I'm a little surprised/concerned these changes were necessary

        +      final HConnection con = HConnectionManager.createConnection(conf);
        

        +1

        Patch was taken from the wrong base, probably buildbot cannot apply it. I had to cd hbase-server ; patch -p1 < /tmp/11491.v1.patch

        Show
        Nick Dimiduk added a comment - I'm a little surprised/concerned these changes were necessary + final HConnection con = HConnectionManager.createConnection(conf); +1 Patch was taken from the wrong base, probably buildbot cannot apply it. I had to cd hbase-server ; patch -p1 < /tmp/11491.v1.patch
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12655193/11491.v1.withp1.patch
        against trunk revision .
        ATTACHMENT ID: 12655193

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 findbugs. The patch appears to introduce 4 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.master.TestDistributedLogSplitting

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10032//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10032//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10032//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10032//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10032//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10032//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10032//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10032//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10032//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10032//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10032//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12655193/11491.v1.withp1.patch against trunk revision . ATTACHMENT ID: 12655193 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 findbugs . The patch appears to introduce 4 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.master.TestDistributedLogSplitting Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10032//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10032//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10032//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10032//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10032//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10032//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10032//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10032//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10032//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10032//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10032//console This message is automatically generated.
        Hide
        Nicolas Liochon added a comment -

        Committed to master & branch-1, thanks for the review Nick and Ted.

        I'm a little surprised/concerned these changes were necessary

        I haven't looked in the details, but yes it was needed to have a single con (the 'oneCon' setting was broken')

        Show
        Nicolas Liochon added a comment - Committed to master & branch-1, thanks for the review Nick and Ted. I'm a little surprised/concerned these changes were necessary I haven't looked in the details, but yes it was needed to have a single con (the 'oneCon' setting was broken')
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-1.0 #27 (See https://builds.apache.org/job/HBase-1.0/27/)
        HBASE-11491 Add an option to sleep randomly during the tests with the PE tool (nkeywal: rev 9a74122a5c3aacd4c7f107bd8027c4a28fc2f561)

        • hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-1.0 #27 (See https://builds.apache.org/job/HBase-1.0/27/ ) HBASE-11491 Add an option to sleep randomly during the tests with the PE tool (nkeywal: rev 9a74122a5c3aacd4c7f107bd8027c4a28fc2f561) hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #5287 (See https://builds.apache.org/job/HBase-TRUNK/5287/)
        HBASE-11491 Add an option to sleep randomly during the tests with the PE tool (nkeywal: rev 4f3d5bbab960ac7502fb0c6d9bdb8982b97333c3)

        • hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5287 (See https://builds.apache.org/job/HBase-TRUNK/5287/ ) HBASE-11491 Add an option to sleep randomly during the tests with the PE tool (nkeywal: rev 4f3d5bbab960ac7502fb0c6d9bdb8982b97333c3) hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
        Hide
        Enis Soztutar added a comment -

        Resolving since it is committed. I've set the fix versions as well.

        Show
        Enis Soztutar added a comment - Resolving since it is committed. I've set the fix versions as well.
        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

          People

          • Assignee:
            Nicolas Liochon
            Reporter:
            Nicolas Liochon
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development