HBase
  1. HBase
  2. HBASE-11450

Improve file size info in SnapshotInfo tool

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.99.0
    • Fix Version/s: 0.99.0, 0.98.4, 0.94.22, 2.0.0
    • Component/s: snapshots
    • Labels:
      None

      Description

      Add a "-size-in-bytes" flag to print the file size in byte instead of the human readable format.
      and add a check on the file length between the manifest and the hfile, marking as "CORRUPTED" files with length that don't match.

      Snapshot Files
      ----------------------------------------
         4839b testtb/a81219be11ade1d0d2913267caeeb3fe/cf/bec5567b2cb04cd1a76c2f4106991de7 
             - testtb/f2622221b913c44a61a03550cb74e3a1/cf/8b02813a4f564957bd820c88fccf376a (NOT FOUND)
         4967b testtb/0cab854a3877697e726a73187fe21643/cf/7afb8fe1e2f141eb9b8e17d1f68cd576 (archive)
           12b testtb/35074c28fd4dc304930f261fa8e0ce9c/cf/fedd9b9044b74768a6631003695c2f32 (CORRUPTED)
         4839b testtb/bb2ac9c8efc5ac9077084268c60dd8da/cf/50a3144088b049d98007af331821abd7 
         4839b testtb/cda2a3ea0f5630d19018916cbe73264e/cf/da0a1008656c403cb17f37a061d04120 
         4905b testtb/5b6e6b804e075778185e2fb1a27bae90/cf/1177a58d798a46ec952a0bc19f902711 (archive)
      
      **************************************************************
      BAD SNAPSHOT: 1 hfile(s) and 0 log(s) missing.
                    1 hfile(s) corrupted.
      **************************************************************
      
      1. HBASE-11450-v1.patch
        8 kB
        Matteo Bertozzi
      2. HBASE-11450-v0.patch
        8 kB
        Matteo Bertozzi

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12653380/HBASE-11450-v0.patch
        against trunk revision .
        ATTACHMENT ID: 12653380

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 findbugs. The patch appears to introduce 13 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:

        -1 core zombie tests. There are 1 zombie test(s): at org.apache.hadoop.hbase.regionserver.TestHRegion.testFlushCacheWhileScanning(TestHRegion.java:3162)

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9921//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9921//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12653380/HBASE-11450-v0.patch against trunk revision . ATTACHMENT ID: 12653380 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 findbugs . The patch appears to introduce 13 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: -1 core zombie tests . There are 1 zombie test(s): at org.apache.hadoop.hbase.regionserver.TestHRegion.testFlushCacheWhileScanning(TestHRegion.java:3162) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9921//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9921//console This message is automatically generated.
        Hide
        stack added a comment -

        +1 Simple patch.

        If you were going to make another version of patch

        Nit: on commit change name of variable to corrupted from iscorrupted so you are javabean-style

        + private final boolean isCorrupted;

        Change method name from stateToString to getStateToString

        Thanks Matteo

        Show
        stack added a comment - +1 Simple patch. If you were going to make another version of patch Nit: on commit change name of variable to corrupted from iscorrupted so you are javabean-style + private final boolean isCorrupted; Change method name from stateToString to getStateToString Thanks Matteo
        Hide
        Matteo Bertozzi added a comment -

        v1 uses getStateToString() and corrupted

        Show
        Matteo Bertozzi added a comment - v1 uses getStateToString() and corrupted
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12653608/HBASE-11450-v1.patch
        against trunk revision .
        ATTACHMENT ID: 12653608

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 findbugs. The patch appears to introduce 13 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9938//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9938//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12653608/HBASE-11450-v1.patch against trunk revision . ATTACHMENT ID: 12653608 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 findbugs . The patch appears to introduce 13 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9938//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9938//console This message is automatically generated.
        Hide
        stack added a comment -

        +1

        Show
        stack added a comment - +1
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.94 #1382 (See https://builds.apache.org/job/HBase-0.94/1382/)
        HBASE-11450 Improve file size info in SnapshotInfo tool (matteo.bertozzi: rev 0cc71fb2e7e18b436bd6d01cabf6f0c4076d202d)

        • src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.94 #1382 (See https://builds.apache.org/job/HBase-0.94/1382/ ) HBASE-11450 Improve file size info in SnapshotInfo tool (matteo.bertozzi: rev 0cc71fb2e7e18b436bd6d01cabf6f0c4076d202d) src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.98 #372 (See https://builds.apache.org/job/HBase-0.98/372/)
        HBASE-11450 Improve file size info in SnapshotInfo tool (matteo.bertozzi: rev 180034b755370d92945ba72bb0944be0140312ec)

        • hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.98 #372 (See https://builds.apache.org/job/HBase-0.98/372/ ) HBASE-11450 Improve file size info in SnapshotInfo tool (matteo.bertozzi: rev 180034b755370d92945ba72bb0944be0140312ec) hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.94-security #495 (See https://builds.apache.org/job/HBase-0.94-security/495/)
        HBASE-11450 Improve file size info in SnapshotInfo tool (matteo.bertozzi: rev 0cc71fb2e7e18b436bd6d01cabf6f0c4076d202d)

        • src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.94-security #495 (See https://builds.apache.org/job/HBase-0.94-security/495/ ) HBASE-11450 Improve file size info in SnapshotInfo tool (matteo.bertozzi: rev 0cc71fb2e7e18b436bd6d01cabf6f0c4076d202d) src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-1.0 #8 (See https://builds.apache.org/job/HBase-1.0/8/)
        HBASE-11450 Improve file size info in SnapshotInfo tool (matteo.bertozzi: rev 39caf5757d849333b05cebad0e4b3d4528c142d7)

        • hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-1.0 #8 (See https://builds.apache.org/job/HBase-1.0/8/ ) HBASE-11450 Improve file size info in SnapshotInfo tool (matteo.bertozzi: rev 39caf5757d849333b05cebad0e4b3d4528c142d7) hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.94-JDK7 #150 (See https://builds.apache.org/job/HBase-0.94-JDK7/150/)
        HBASE-11450 Improve file size info in SnapshotInfo tool (matteo.bertozzi: rev 0cc71fb2e7e18b436bd6d01cabf6f0c4076d202d)

        • src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.94-JDK7 #150 (See https://builds.apache.org/job/HBase-0.94-JDK7/150/ ) HBASE-11450 Improve file size info in SnapshotInfo tool (matteo.bertozzi: rev 0cc71fb2e7e18b436bd6d01cabf6f0c4076d202d) src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #5265 (See https://builds.apache.org/job/HBase-TRUNK/5265/)
        HBASE-11450 Improve file size info in SnapshotInfo tool (matteo.bertozzi: rev c88b4c46a40ad8bfd29640395aee12a566080e86)

        • hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5265 (See https://builds.apache.org/job/HBase-TRUNK/5265/ ) HBASE-11450 Improve file size info in SnapshotInfo tool (matteo.bertozzi: rev c88b4c46a40ad8bfd29640395aee12a566080e86) hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #352 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/352/)
        HBASE-11450 Improve file size info in SnapshotInfo tool (matteo.bertozzi: rev 180034b755370d92945ba72bb0944be0140312ec)

        • hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #352 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/352/ ) HBASE-11450 Improve file size info in SnapshotInfo tool (matteo.bertozzi: rev 180034b755370d92945ba72bb0944be0140312ec) hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java
        Hide
        Enis Soztutar added a comment -

        Please use the fixVersion=2.0.0 when committing to master.

        Show
        Enis Soztutar added a comment - Please use the fixVersion=2.0.0 when committing to master.
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98 #464 (See https://builds.apache.org/job/HBase-0.98/464/)
        HBASE-11450 Improve file size info in SnapshotInfo tool (addendum) (matteo.bertozzi: rev 488afeb45cceaa51bc9302814c6661ec148b9d96)

        • hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #464 (See https://builds.apache.org/job/HBase-0.98/464/ ) HBASE-11450 Improve file size info in SnapshotInfo tool (addendum) (matteo.bertozzi: rev 488afeb45cceaa51bc9302814c6661ec148b9d96) hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #437 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/437/)
        HBASE-11450 Improve file size info in SnapshotInfo tool (addendum) (matteo.bertozzi: rev 488afeb45cceaa51bc9302814c6661ec148b9d96)

        • hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #437 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/437/ ) HBASE-11450 Improve file size info in SnapshotInfo tool (addendum) (matteo.bertozzi: rev 488afeb45cceaa51bc9302814c6661ec148b9d96) hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java

          People

          • Assignee:
            Matteo Bertozzi
            Reporter:
            Matteo Bertozzi
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development