HBase
  1. HBase
  2. HBASE-11394

Replication can have data loss if peer id contains hyphen "-"

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0, 0.98.8, 0.99.1
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      This is an extension to HBASE-8207. It seems that there is no check for the peer id string (which is the short name for the replication peer) format. So in case a peer id containing "-", it will cause data loss silently on server failure.

      I did not verify the claim via testing though, this is just purely from reading the code.

      1. HBASE-11394.patch
        4 kB
        Talat UYARER
      2. HBASE-11394_v2.patch
        4 kB
        Talat UYARER
      3. HBASE-11394_v2.patch
        4 kB
        stack

        Activity

        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.1 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.1 release.
        Hide
        Enis Soztutar added a comment -

        Sorry, late +1.

        Show
        Enis Soztutar added a comment - Sorry, late +1.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #563 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/563/)
        Amend HBASE-11394 Replication can have data loss if peer id contains hyphen (apurtell: rev a0d0fe9cf57dcfa71eeb52962577a2ba35f05c10)

        • hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationTrackerZKImpl.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #563 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/563/ ) Amend HBASE-11394 Replication can have data loss if peer id contains hyphen (apurtell: rev a0d0fe9cf57dcfa71eeb52962577a2ba35f05c10) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationTrackerZKImpl.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98 #592 (See https://builds.apache.org/job/HBase-0.98/592/)
        Amend HBASE-11394 Replication can have data loss if peer id contains hyphen (apurtell: rev a0d0fe9cf57dcfa71eeb52962577a2ba35f05c10)

        • hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationTrackerZKImpl.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #592 (See https://builds.apache.org/job/HBase-0.98/592/ ) Amend HBASE-11394 Replication can have data loss if peer id contains hyphen (apurtell: rev a0d0fe9cf57dcfa71eeb52962577a2ba35f05c10) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationTrackerZKImpl.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #562 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/562/)
        HBASE-11394 Replication can have data loss if peer id contains hyphen "-" (stack: rev da0af93f80a42e23fef6593d3d1523656eddbfd6)

        • hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationTrackerZKImpl.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #562 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/562/ ) HBASE-11394 Replication can have data loss if peer id contains hyphen "-" (stack: rev da0af93f80a42e23fef6593d3d1523656eddbfd6) hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationTrackerZKImpl.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-1.0 #297 (See https://builds.apache.org/job/HBase-1.0/297/)
        HBASE-11394 Replication can have data loss if peer id contains hyphen "-" (stack: rev 8c125a40bf92b19e1062d058c653ef7d6e5200f4)

        • hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationTrackerZKImpl.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-1.0 #297 (See https://builds.apache.org/job/HBase-1.0/297/ ) HBASE-11394 Replication can have data loss if peer id contains hyphen "-" (stack: rev 8c125a40bf92b19e1062d058c653ef7d6e5200f4) hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationTrackerZKImpl.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #5648 (See https://builds.apache.org/job/HBase-TRUNK/5648/)
        HBASE-11394 Replication can have data loss if peer id contains hyphen "-" (stack: rev 65ae2e51261c312a55b3f88134f1aea29177ea90)

        • hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationTrackerZKImpl.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5648 (See https://builds.apache.org/job/HBase-TRUNK/5648/ ) HBASE-11394 Replication can have data loss if peer id contains hyphen "-" (stack: rev 65ae2e51261c312a55b3f88134f1aea29177ea90) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationTrackerZKImpl.java hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.98 #591 (See https://builds.apache.org/job/HBase-0.98/591/)
        HBASE-11394 Replication can have data loss if peer id contains hyphen "-" (stack: rev da0af93f80a42e23fef6593d3d1523656eddbfd6)

        • hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationTrackerZKImpl.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.98 #591 (See https://builds.apache.org/job/HBase-0.98/591/ ) HBASE-11394 Replication can have data loss if peer id contains hyphen "-" (stack: rev da0af93f80a42e23fef6593d3d1523656eddbfd6) hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationTrackerZKImpl.java
        Hide
        stack added a comment -

        Pushed to 0.98+. Thanks for the patch Talat UYARER

        Show
        stack added a comment - Pushed to 0.98+. Thanks for the patch Talat UYARER
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12674188/HBASE-11394_v2.patch
        against trunk revision .
        ATTACHMENT ID: 12674188

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11303//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11303//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11303//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11303//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11303//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11303//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11303//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11303//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11303//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11303//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11303//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11303//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12674188/HBASE-11394_v2.patch against trunk revision . ATTACHMENT ID: 12674188 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11303//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11303//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11303//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11303//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11303//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11303//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11303//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11303//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11303//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11303//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11303//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11303//console This message is automatically generated.
        Hide
        stack added a comment -

        Retry

        Looking at console output, it looks like test rig stuck on last steps.... not much info. Doesn't look related. Retrying.

        Show
        stack added a comment - Retry Looking at console output, it looks like test rig stuck on last steps.... not much info. Doesn't look related. Retrying.
        Hide
        Talat UYARER added a comment -

        stack I think core zombie test failure does not related with me. Wdyt ?

        Show
        Talat UYARER added a comment - stack I think core zombie test failure does not related with me. Wdyt ?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12674120/HBASE-11394_v2.patch
        against trunk revision .
        ATTACHMENT ID: 12674120

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        -1 core zombie tests. There are 1 zombie test(s):

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11300//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11300//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11300//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11300//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11300//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11300//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11300//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11300//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11300//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11300//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11300//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11300//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12674120/HBASE-11394_v2.patch against trunk revision . ATTACHMENT ID: 12674120 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . -1 core zombie tests . There are 1 zombie test(s): Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11300//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11300//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11300//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11300//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11300//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11300//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11300//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11300//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11300//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11300//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11300//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11300//console This message is automatically generated.
        Hide
        Talat UYARER added a comment -

        I fixed the problem. In Last test I did not delete peer from ZK. Is it run test by turn ?

        Show
        Talat UYARER added a comment - I fixed the problem. In Last test I did not delete peer from ZK. Is it run test by turn ?
        Hide
        stack added a comment -

        Looks like failure is related Talat UYARER

        Show
        stack added a comment - Looks like failure is related Talat UYARER
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12673887/HBASE-11394.patch
        against trunk revision .
        ATTACHMENT ID: 12673887

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.replication.TestReplicationTrackerZKImpl

        -1 core zombie tests. There are 1 zombie test(s): at org.apache.hadoop.hbase.master.balancer.TestBaseLoadBalancer.testImmediateAssignment(TestBaseLoadBalancer.java:136)

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11293//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11293//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11293//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11293//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11293//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11293//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11293//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11293//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11293//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11293//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11293//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11293//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12673887/HBASE-11394.patch against trunk revision . ATTACHMENT ID: 12673887 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplicationTrackerZKImpl -1 core zombie tests . There are 1 zombie test(s): at org.apache.hadoop.hbase.master.balancer.TestBaseLoadBalancer.testImmediateAssignment(TestBaseLoadBalancer.java:136) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11293//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11293//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11293//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11293//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11293//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11293//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11293//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11293//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11293//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11293//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11293//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11293//console This message is automatically generated.
        Hide
        stack added a comment -

        Patch looks good to me. Trying against hadoopqa.

        Show
        stack added a comment - Patch looks good to me. Trying against hadoopqa.
        Hide
        Talat UYARER added a comment -

        Hi Enis Soztutar,

        I add a control into addPeer method of ReplicationPeersZKImpl. BTW I fixed tests in TestReplicationTrackerZKImpl and added a Peer Name Control Test. Is this enoug for the issue ?

        Show
        Talat UYARER added a comment - Hi Enis Soztutar , I add a control into addPeer method of ReplicationPeersZKImpl. BTW I fixed tests in TestReplicationTrackerZKImpl and added a Peer Name Control Test. Is this enoug for the issue ?
        Hide
        Andrew Purtell added a comment -

        No progress on issue. Unscheduling from < 0.99. Should a patch show up we can target the latest 0.98 SNAPSHOT.

        Show
        Andrew Purtell added a comment - No progress on issue. Unscheduling from < 0.99. Should a patch show up we can target the latest 0.98 SNAPSHOT.
        Hide
        Enis Soztutar added a comment -

        Do you have a patch? It should be easy to just do a check in addPeer().

        Show
        Enis Soztutar added a comment - Do you have a patch? It should be easy to just do a check in addPeer().
        Hide
        Jieshan Bean added a comment -

        I have the same doubt. We have added a restriction to the peer-id name in our private version.

        Show
        Jieshan Bean added a comment - I have the same doubt. We have added a restriction to the peer-id name in our private version.

          People

          • Assignee:
            Talat UYARER
            Reporter:
            Enis Soztutar
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development