Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.99.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Our bucket caches run threads in the background to log stats on a period only since we moved the log level to default INFO, these DEBUG level logs no longer show up. Make the loggings INFO level (and do some fixup to make bucket cache and lru loggings look same).

      1. 11320v2.txt
        12 kB
        stack
      2. 11320.txt
        10 kB
        stack

        Activity

        Hide
        stack added a comment -

        Ideally these should be configurable but the Configuration isn't passed in. Could fix this later.

        Show
        stack added a comment - Ideally these should be configurable but the Configuration isn't passed in. Could fix this later.
        Hide
        stack added a comment -

        Here is what it looks like:

        ...
        2014-06-10 11:58:10,672 INFO  [BucketCacheStatsExecutor] bucket.BucketCache: failedBlockAdditions=0, totalSize=817.59 MB, freeSize=817.58 MB, usedSize=15 KB, cacheSize=1.04 KB, accesses=28, hits=24, IOhitsPerSecond=0, IOTimePerHit=0.00, hitRatio=85.71%, cachingAccesses=28, cachingHits=24, cachingHitsRatio=85.71%, evictions=0, evicted=0, evictedPerRun=NaN
        2014-06-10 11:58:10,677 INFO  [LruBlockCacheStatsExecutor] hfile.LruBlockCache: totalSize=216.95 KB, freeSize=204.59 MB, max=204.80 MB, blocks=214748352, accesses=1, hits=1, hitRatio=100.00%, , cachingAccesses=1, cachingHits=1, cachingHitsRatio=100.00%, evictions=0, evicted=0, evictedPerRun=NaN
        2014-06-10 12:03:10,671 INFO  [BucketCacheStatsExecutor] bucket.BucketCache: failedBlockAdditions=0, totalSize=817.59 MB, freeSize=817.58 MB, usedSize=15 KB, cacheSize=1.04 KB, accesses=30, hits=26, IOhitsPerSecond=0, IOTimePerHit=0.00, hitRatio=86.67%, cachingAccesses=30, cachingHits=26, cachingHitsRatio=86.67%, evictions=0, evicted=0, evictedPerRun=NaN
        2014-06-10 12:03:10,677 INFO  [LruBlockCacheStatsExecutor] hfile.LruBlockCache: totalSize=216.95 KB, freeSize=204.59 MB, max=204.80 MB, blocks=214748352, accesses=1, hits=1, hitRatio=100.00%, , cachingAccesses=1, cachingHits=1, cachingHitsRatio=100.00%, evictions=0, evicted=0, evictedPerRun=NaN
        ...
        
        Show
        stack added a comment - Here is what it looks like: ... 2014-06-10 11:58:10,672 INFO [BucketCacheStatsExecutor] bucket.BucketCache: failedBlockAdditions=0, totalSize=817.59 MB, freeSize=817.58 MB, usedSize=15 KB, cacheSize=1.04 KB, accesses=28, hits=24, IOhitsPerSecond=0, IOTimePerHit=0.00, hitRatio=85.71%, cachingAccesses=28, cachingHits=24, cachingHitsRatio=85.71%, evictions=0, evicted=0, evictedPerRun=NaN 2014-06-10 11:58:10,677 INFO [LruBlockCacheStatsExecutor] hfile.LruBlockCache: totalSize=216.95 KB, freeSize=204.59 MB, max=204.80 MB, blocks=214748352, accesses=1, hits=1, hitRatio=100.00%, , cachingAccesses=1, cachingHits=1, cachingHitsRatio=100.00%, evictions=0, evicted=0, evictedPerRun=NaN 2014-06-10 12:03:10,671 INFO [BucketCacheStatsExecutor] bucket.BucketCache: failedBlockAdditions=0, totalSize=817.59 MB, freeSize=817.58 MB, usedSize=15 KB, cacheSize=1.04 KB, accesses=30, hits=26, IOhitsPerSecond=0, IOTimePerHit=0.00, hitRatio=86.67%, cachingAccesses=30, cachingHits=26, cachingHitsRatio=86.67%, evictions=0, evicted=0, evictedPerRun=NaN 2014-06-10 12:03:10,677 INFO [LruBlockCacheStatsExecutor] hfile.LruBlockCache: totalSize=216.95 KB, freeSize=204.59 MB, max=204.80 MB, blocks=214748352, accesses=1, hits=1, hitRatio=100.00%, , cachingAccesses=1, cachingHits=1, cachingHitsRatio=100.00%, evictions=0, evicted=0, evictedPerRun=NaN ...
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12649640/11320.txt
        against trunk revision .
        ATTACHMENT ID: 12649640

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:

        -1 core zombie tests. There are 1 zombie test(s): at org.apache.hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels.testMROnTable(TestImportTSVWithVisibilityLabels.java:160)

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9735//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9735//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9735//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9735//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9735//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9735//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9735//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9735//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9735//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9735//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9735//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12649640/11320.txt against trunk revision . ATTACHMENT ID: 12649640 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: -1 core zombie tests . There are 1 zombie test(s): at org.apache.hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels.testMROnTable(TestImportTSVWithVisibilityLabels.java:160) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9735//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9735//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9735//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9735//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9735//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9735//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9735//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9735//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9735//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9735//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9735//console This message is automatically generated.
        Hide
        Nick Dimiduk added a comment -

        +1

        Show
        Nick Dimiduk added a comment - +1
        Hide
        stack added a comment -

        What I committed (added fixes for javadoc warnings that were not mine)

        Show
        stack added a comment - What I committed (added fixes for javadoc warnings that were not mine)
        Hide
        stack added a comment -

        Thanks Nick Dimiduk

        Show
        stack added a comment - Thanks Nick Dimiduk
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #5193 (See https://builds.apache.org/job/HBase-TRUNK/5193/)
        HBASE-11320 Reenable bucket cache logging (stack: rev 2ab3b325caefbc649b0cea911728a4776294a76a)

        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiVersionConsistencyControl.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5193 (See https://builds.apache.org/job/HBase-TRUNK/5193/ ) HBASE-11320 Reenable bucket cache logging (stack: rev 2ab3b325caefbc649b0cea911728a4776294a76a) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiVersionConsistencyControl.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java
        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

          People

          • Assignee:
            stack
            Reporter:
            stack
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development