HBase
  1. HBase
  2. HBASE-11310

Delete's copy constructor should copy the attributes also

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.98.3
    • Fix Version/s: 0.99.0, 0.98.4
    • Component/s: mapreduce
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The constructor in Delete

        public Delete(final Delete d) {
          this.row = d.getRow();
          this.ts = d.getTimeStamp();
          this.familyMap.putAll(d.getFamilyCellMap());
          this.durability = d.durability;
        }
      

      should copy the attributes also. Similar bug was raised for Put also. I remember because I found while debugging an MR issue. Now while checking another MR issue found for delete it has not been done.

      1. HBASE-11310.patch
        0.7 kB
        ramkrishna.s.vasudevan
      2. HBASE-11310_1.patch
        4 kB
        ramkrishna.s.vasudevan
      3. 11310.addendum
        0.7 kB
        Ted Yu

        Activity

        ramkrishna.s.vasudevan created issue -
        ramkrishna.s.vasudevan made changes -
        Field Original Value New Value
        Description The constructor in Delete
        {code}
          public Delete(final Delete d) {
            this.row = d.getRow();
            this.ts = d.getTimeStamp();
            this.familyMap.putAll(d.getFamilyCellMap());
            this.durability = d.durability;
          }
        {code}
        should copy the attributes also. Similar bug was raised for Put also. I remember because I found while debugging an MR issue. Now while checking another MR issue I found for delete it has not been done.
        The constructor in Delete
        {code}
          public Delete(final Delete d) {
            this.row = d.getRow();
            this.ts = d.getTimeStamp();
            this.familyMap.putAll(d.getFamilyCellMap());
            this.durability = d.durability;
          }
        {code}
        should copy the attributes also. Similar bug was raised for Put also. I remember because I found while debugging an MR issue. Now while checking another MR issue found for delete it has not been done.
        ramkrishna.s.vasudevan made changes -
        Attachment HBASE-11310.patch [ 12649397 ]
        ramkrishna.s.vasudevan made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        ramkrishna.s.vasudevan made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        ramkrishna.s.vasudevan made changes -
        Attachment HBASE-11310_1.patch [ 12649526 ]
        ramkrishna.s.vasudevan made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        ramkrishna.s.vasudevan made changes -
        Summary Delete constructor accepting another Delete should copy the attributes also Delete's copy constructor should copy the attributes also
        ramkrishna.s.vasudevan made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Resolution Fixed [ 1 ]
        Ted Yu made changes -
        Attachment 11310.addendum [ 12649847 ]
        Enis Soztutar made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            ramkrishna.s.vasudevan
            Reporter:
            ramkrishna.s.vasudevan
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development