HBase
  1. HBase
  2. HBASE-11310

Delete's copy constructor should copy the attributes also

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.98.3
    • Fix Version/s: 0.99.0, 0.98.4
    • Component/s: mapreduce
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The constructor in Delete

        public Delete(final Delete d) {
          this.row = d.getRow();
          this.ts = d.getTimeStamp();
          this.familyMap.putAll(d.getFamilyCellMap());
          this.durability = d.durability;
        }
      

      should copy the attributes also. Similar bug was raised for Put also. I remember because I found while debugging an MR issue. Now while checking another MR issue found for delete it has not been done.

      1. HBASE-11310.patch
        0.7 kB
        ramkrishna.s.vasudevan
      2. HBASE-11310_1.patch
        4 kB
        ramkrishna.s.vasudevan
      3. 11310.addendum
        0.7 kB
        Ted Yu

        Activity

        Hide
        Nick Dimiduk added a comment -

        Would you mind doing an audit of all the client API copy-constructors for this bug, update them all in a single patch? Thanks.

        Show
        Nick Dimiduk added a comment - Would you mind doing an audit of all the client API copy-constructors for this bug, update them all in a single patch? Thanks.
        Hide
        ramkrishna.s.vasudevan added a comment -

        I checked Append, Increment, Scan and Get.
        Append and increment does not have the copy constructor.
        Scan has one but it is taking the attributes also. Get does not have a copy constructor. Is there any other Client API that we should check? As Nick said its better to address all similar cases here.

        Show
        ramkrishna.s.vasudevan added a comment - I checked Append, Increment, Scan and Get. Append and increment does not have the copy constructor. Scan has one but it is taking the attributes also. Get does not have a copy constructor. Is there any other Client API that we should check? As Nick said its better to address all similar cases here.
        Hide
        Andrew Purtell added a comment -

        I checked Append, Increment, Scan and Get.

        That is only part of the client API.

        Get does not have a copy constructor.

        Then I advocate adding one. What do you think Nick Dimiduk?

        Show
        Andrew Purtell added a comment - I checked Append, Increment, Scan and Get. That is only part of the client API. Get does not have a copy constructor. Then I advocate adding one. What do you think Nick Dimiduk ?
        Hide
        Nick Dimiduk added a comment -

        Put also has a copy constructor, it does copy attributes.

        Would be nice to have a uniform API and looks like these ctors are used by the MapReduce API. I guess they should all have it.

        Show
        Nick Dimiduk added a comment - Put also has a copy constructor, it does copy attributes. Would be nice to have a uniform API and looks like these ctors are used by the MapReduce API. I guess they should all have it.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12649397/HBASE-11310.patch
        against trunk revision .
        ATTACHMENT ID: 12649397

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9724//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9724//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9724//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9724//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9724//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9724//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9724//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9724//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9724//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9724//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9724//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12649397/HBASE-11310.patch against trunk revision . ATTACHMENT ID: 12649397 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9724//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9724//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9724//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9724//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9724//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9724//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9724//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9724//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9724//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9724//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9724//console This message is automatically generated.
        Hide
        ramkrishna.s.vasudevan added a comment -

        Updated patch. Adds copy constructor to Get, Append and Increment along with collecting the attributes in the Delete's copy-constructor.

        Show
        ramkrishna.s.vasudevan added a comment - Updated patch. Adds copy constructor to Get, Append and Increment along with collecting the attributes in the Delete's copy-constructor.
        Hide
        ramkrishna.s.vasudevan added a comment -

        Ping!!!

        Show
        ramkrishna.s.vasudevan added a comment - Ping!!!
        Hide
        Nick Dimiduk added a comment -

        Looks good to me. +1

        Show
        Nick Dimiduk added a comment - Looks good to me. +1
        Hide
        ramkrishna.s.vasudevan added a comment -

        Committed to trunk and 0.98. Thanks for the reviews.

        Show
        ramkrishna.s.vasudevan added a comment - Committed to trunk and 0.98. Thanks for the reviews.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.98 #330 (See https://builds.apache.org/job/HBase-0.98/330/)
        HBASE-11310:Delete's copy constructor should copy the attributes also (ramkrishna: rev 9b94c14fa3989a1d170749ab51f14703a1f3bd1e)

        • hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/client/Delete.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.98 #330 (See https://builds.apache.org/job/HBase-0.98/330/ ) HBASE-11310 :Delete's copy constructor should copy the attributes also (ramkrishna: rev 9b94c14fa3989a1d170749ab51f14703a1f3bd1e) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/Delete.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #5195 (See https://builds.apache.org/job/HBase-TRUNK/5195/)
        HBASE-11310:Delete's copy constructor should copy the attributes also (ramkrishna: rev af9fa42e1b20531bbbd2776c86f55f7d71a57773)

        • hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/client/Delete.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5195 (See https://builds.apache.org/job/HBase-TRUNK/5195/ ) HBASE-11310 :Delete's copy constructor should copy the attributes also (ramkrishna: rev af9fa42e1b20531bbbd2776c86f55f7d71a57773) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/Delete.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #312 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/312/)
        HBASE-11310:Delete's copy constructor should copy the attributes also (ramkrishna: rev 9b94c14fa3989a1d170749ab51f14703a1f3bd1e)

        • hbase-client/src/main/java/org/apache/hadoop/hbase/client/Delete.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #312 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/312/ ) HBASE-11310 :Delete's copy constructor should copy the attributes also (ramkrishna: rev 9b94c14fa3989a1d170749ab51f14703a1f3bd1e) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Delete.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
        Hide
        Ted Yu added a comment -

        Addendum fixes compilation error

        Show
        Ted Yu added a comment - Addendum fixes compilation error
        Hide
        Jimmy Xiang added a comment -

        +1 for the addendum

        Show
        Jimmy Xiang added a comment - +1 for the addendum
        Hide
        Ted Yu added a comment -

        Addendum integrated to 0.98 and trunk.

        Show
        Ted Yu added a comment - Addendum integrated to 0.98 and trunk.
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK #5196 (See https://builds.apache.org/job/HBase-TRUNK/5196/)
        HBASE-11310 Addendum fixes compilation error (tedyu: rev aa916b81ceb0554ad88a7b076ef0b9a1c10d5dd0)

        • hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #5196 (See https://builds.apache.org/job/HBase-TRUNK/5196/ ) HBASE-11310 Addendum fixes compilation error (tedyu: rev aa916b81ceb0554ad88a7b076ef0b9a1c10d5dd0) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98 #331 (See https://builds.apache.org/job/HBase-0.98/331/)
        HBASE-11310 Addendum fixes compilation error (tedyu: rev 3d3e7eb228d035cc447734d8bcaa18b5621325b8)

        • hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #331 (See https://builds.apache.org/job/HBase-0.98/331/ ) HBASE-11310 Addendum fixes compilation error (tedyu: rev 3d3e7eb228d035cc447734d8bcaa18b5621325b8) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #313 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/313/)
        HBASE-11310 Addendum fixes compilation error (tedyu: rev 3d3e7eb228d035cc447734d8bcaa18b5621325b8)

        • hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #313 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/313/ ) HBASE-11310 Addendum fixes compilation error (tedyu: rev 3d3e7eb228d035cc447734d8bcaa18b5621325b8) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
        Hide
        ramkrishna.s.vasudevan added a comment -

        Thanks for the addendum Ted.

        Show
        ramkrishna.s.vasudevan added a comment - Thanks for the addendum Ted.
        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

          People

          • Assignee:
            ramkrishna.s.vasudevan
            Reporter:
            ramkrishna.s.vasudevan
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development