HBase
  1. HBase
  2. HBASE-11186

Improve TestExportSnapshot verifications

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.99.0
    • Fix Version/s: 0.99.0
    • Component/s: snapshots
    • Labels:
      None

      Description

      • Remove some code by using the utils that we already have in SnapshotTestingUtil
      • Add an Export with references for both v1 and v2 format
      • add the verification on the actual number of files exported
      1. HBASE-11186-v0.patch
        12 kB
        Matteo Bertozzi

        Issue Links

          Activity

          Hide
          stack added a comment -

          Took a quick look. LGTM. I applied the patch to trunk locally and the refactored test failed with this:

          Tests run: 9, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 303.551 sec <<< FAILURE!
          testSnapshotWithRefsExportFileSystemState(org.apache.hadoop.hbase.snapshot.TestExportSnapshot)  Time elapsed: 23.841 sec  <<< FAILURE!
          java.lang.AssertionError: expected:<0> but was:<1>
                  at org.junit.Assert.fail(Assert.java:88)
                  at org.junit.Assert.failNotEquals(Assert.java:743)
                  at org.junit.Assert.assertEquals(Assert.java:118)
                  at org.junit.Assert.assertEquals(Assert.java:555)
                  at org.junit.Assert.assertEquals(Assert.java:542)
                  at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:288)
                  at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:260)
                  at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testSnapshotWithRefsExportFileSystemState(TestExportSnapshot.java:254)
                  at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testSnapshotWithRefsExportFileSystemState(TestExportSnapshot.java:234)
          ...
          
          

          Did I do something wrong?

          Show
          stack added a comment - Took a quick look. LGTM. I applied the patch to trunk locally and the refactored test failed with this: Tests run: 9, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 303.551 sec <<< FAILURE! testSnapshotWithRefsExportFileSystemState(org.apache.hadoop.hbase.snapshot.TestExportSnapshot) Time elapsed: 23.841 sec <<< FAILURE! java.lang.AssertionError: expected:<0> but was:<1> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:288) at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:260) at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testSnapshotWithRefsExportFileSystemState(TestExportSnapshot.java:254) at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testSnapshotWithRefsExportFileSystemState(TestExportSnapshot.java:234) ... Did I do something wrong?
          Hide
          Matteo Bertozzi added a comment -

          I applied the patch to trunk locally and the refactored test failed with this... Did I do something wrong?

          No, my fault. Forgot to mention that this patch depends on HBASE-11185 (that's the reason I didn't press "submit patch")

          Show
          Matteo Bertozzi added a comment - I applied the patch to trunk locally and the refactored test failed with this... Did I do something wrong? No, my fault. Forgot to mention that this patch depends on HBASE-11185 (that's the reason I didn't press "submit patch")
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-TRUNK #5135 (See https://builds.apache.org/job/HBase-TRUNK/5135/)
          HBASE-11186 Improve TestExportSnapshot verifications (mbertozzi: rev 1596172)

          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #5135 (See https://builds.apache.org/job/HBase-TRUNK/5135/ ) HBASE-11186 Improve TestExportSnapshot verifications (mbertozzi: rev 1596172) /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java
          Hide
          Enis Soztutar added a comment -

          Closing this issue after 0.99.0 release.

          Show
          Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

            People

            • Assignee:
              Matteo Bertozzi
              Reporter:
              Matteo Bertozzi
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development