HBase
  1. HBase
  2. HBASE-11158

bin/hbase upgrade -check should also check compression codecs

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 0.99.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      When upgrading insitu from 0.94 to 0.96 or 0.98 codecs are usually already there in the servers so it's all fine.

      But when doing an upgrade by moving the data from one cluster to a brand new one, compression codecs might be missing.

      bin/hbase upgrade -check will not report any missing codec, but HBase will not be able to start after the upgrade because the codes are missing.

      I think bin/hbase upgrade -check should check the compression codecs configured on the tables and make sure they are available on the new cluster. f not, it should be reported.

        Activity

        Hide
        stack added a comment -

        It can't check the whole cluster though JMS, right? And checking for libs is orthogonal to upgrade? Thanks.

        Show
        stack added a comment - It can't check the whole cluster though JMS, right? And checking for libs is orthogonal to upgrade? Thanks.
        Hide
        Jean-Marc Spaggiari added a comment - - edited

        It can't check the whole cluster though JMS, right?

        I agree. Just trying to find a way to bring the alert back to the user without having to check the whole cluster. I have not found any good idea to achieve that for now. But I got caught already twice because of that, so trying to figure if there is anything doable to alert user about it. Maybe with another command line? Still thinking about it.

        Show
        Jean-Marc Spaggiari added a comment - - edited It can't check the whole cluster though JMS, right? I agree. Just trying to find a way to bring the alert back to the user without having to check the whole cluster. I have not found any good idea to achieve that for now. But I got caught already twice because of that, so trying to figure if there is anything doable to alert user about it. Maybe with another command line? Still thinking about it.
        Hide
        Jean-Marc Spaggiari added a comment -

        Ok. I thought about it a bit and it's not the best way to solve this. There is already a command to validate compression codecs. So I think a better way to inform user about this is to list the codes used when checking the upgrade, and document in the upgrade process to recommend to check the available codecs when upgrade to a new cluster by pointing to the right documentation. If you are fine with this approach I will close this JIRA, open one to add the codecs dump in the -check portion, and another to update the documentation.

        Show
        Jean-Marc Spaggiari added a comment - Ok. I thought about it a bit and it's not the best way to solve this. There is already a command to validate compression codecs. So I think a better way to inform user about this is to list the codes used when checking the upgrade, and document in the upgrade process to recommend to check the available codecs when upgrade to a new cluster by pointing to the right documentation. If you are fine with this approach I will close this JIRA, open one to add the codecs dump in the -check portion, and another to update the documentation.
        Hide
        stack added a comment -

        I like your proposal.

        Later we could add:

        ./bin/hbase codecs

        And it would take optional codec name. It'd run http://hbase.apache.org/book.html#compression.test across the cluster and return ERROR if a regionserver was missing a codec or just list codecs if no arg supplied?

        Show
        stack added a comment - I like your proposal. Later we could add: ./bin/hbase codecs And it would take optional codec name. It'd run http://hbase.apache.org/book.html#compression.test across the cluster and return ERROR if a regionserver was missing a codec or just list codecs if no arg supplied?

          People

          • Assignee:
            Unassigned
            Reporter:
            Jean-Marc Spaggiari
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Development