[HBASE-11109] flush region sequence id may not be larger than all edits flushed

• Type: Sub-task
• Status: Closed
• Priority: Critical
• Resolution: Invalid
• Affects Version/s: 0.99.0
• Fix Version/s: 0.99.0
• Component/s: wal
• Assignee: Michael Stack
• Reporter: Michael Stack
• Created: 02/May/14 04:20
• Updated: 21/Feb/15 23:31
• Resolved: 13/May/14 19:39

Description

This was found by jeffreyz See parent issue. We have this issue since we put the ring buffer/disrupter into the WAL (HBASE-10156).

An edits region sequence id is set only after the edit has traversed the ring buffer. Flushing, we just up whatever the current region sequence id is. Crossing the ring buffer may take some time and is done by background threads. The flusher may be taking the region sequence id though edits have not yet made it across the ringbuffer: i.e. edits that are actually scoped by the flush may have region sequence ids in excess of that of the flush sequence id reported.

The consequences are not exactly clear. Would rather not have to find out so lets fix this here.

Issue Links

• is superceded by: HBASE-11135 Change region sequenceid generation so happens earlier in the append cycle rather than just before added to file