[HBASE-11099] Two situations where we could open a region with smaller sequence number

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.0, 0.99.1, 2.0.0
• Fix Version/s: 0.98.9, 0.99.2
• Component/s: regionserver
• Hadoop Flags: Reviewed
• Assignee: Stephen Yuan Jiang
• Reporter: Jeffrey Zhong
• Created: 30/Apr/14 01:45
• Updated: 06/Apr/18 17:55
• Resolved: 03/Dec/14 04:17

Description

Recently I happened to run into code where we potentially could open region with smaller sequence number:

1) Inside function: HRegion#internalFlushcache. This is due to we change the way WAL Sync where we use late binding(assign sequence number right before wal sync).
The flushSeqId may less than the change sequence number included in the flush which may cause later region opening code to use a smaller than expected sequence number when we reopen the region.

flushSeqId = this.sequenceId.incrementAndGet();
...
mvcc.waitForRead(w);

2) HRegion#replayRecoveredEdits where we have following code:

...
          if (coprocessorHost != null) {
            status.setStatus("Running pre-WAL-restore hook in coprocessors");
            if (coprocessorHost.preWALRestore(this.getRegionInfo(), key, val)) {
              // if bypass this log entry, ignore it ...
              continue;
            }
          }
...
          currentEditSeqId = key.getLogSeqNum();

If coprocessor skip some tail WALEdits, then the function will return smaller currentEditSeqId. In the end, a region may also open with a smaller sequence number. This may cause data loss because Master may record a larger flushed sequence Id and some WALEdits maybe skipped during recovery if the region fail again.

Issue Links

• is related to: HBASE-11135 Change region sequenceid generation so happens earlier in the append cycle rather than just before added to file
• relates to: HBASE-12782 ITBLL fails for me if generator does anything but 5M per maptask