[HBASE-11030] HBaseTestingUtility.getMiniHBaseCluster should be able to return null

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.99.0, 0.94.19, 0.98.2, 0.96.3
• Hadoop Flags: Reviewed
• Assignee: Lars Hofhansl
• Reporter: Lars Hofhansl
• Created: 18/Apr/14 18:52
• Updated: 28/Apr/14 22:29
• Resolved: 19/Apr/14 05:30

Description

Right now we have this logic:

  public MiniHBaseCluster getMiniHBaseCluster() {
    if (this.hbaseCluster instanceof MiniHBaseCluster) {
      return (MiniHBaseCluster)this.hbaseCluster;
    }
    throw new RuntimeException(hbaseCluster + " not an instance of " +
                               MiniHBaseCluster.class.getName());
  }

Since null is not actually an instance of MiniHBaseCluster we'll throw the RuntimeException rather than returning null.
Some tests call this method and check for null, which is pointless.