[HBASE-11007] BLOCKCACHE in schema descriptor seems not aptly named

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.94.19
• Fix Version/s: 0.99.0
• Assignee: Varun Sharma
• Reporter: Varun Sharma
• Created: 16/Apr/14 23:05
• Updated: 21/Feb/15 23:30
• Resolved: 19/May/14 15:54

Description

Hi,

It seems that setting BLOCKCACHE key to false will disable the Data blocks from being cached but will continue to cache bloom and index blocks. This same property seems to be called cacheDataOnRead inside CacheConfig.

Should this be called CACHE_DATA_ON_READ instead of BLOCKCACHE similar to the other CACHE_DATA_ON_WRITE/CACHE_INDEX_ON_WRITE. We got quite confused and ended up adding our own property CACHE_DATA_ON_READ - we also added some unit tests for the same.

What do folks think about this ?

Thanks
Varun