HBase
  1. HBase
  2. HBASE-10987

Increase timeout in TestZKLeaderManager.testLeaderSelection

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.19
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In 0.94 we wait 2s find the current leader. In 0.96 and later we wait for 10s.
      The test just failed:

      Error Message
      
      Leader should exist
      
      Stacktrace
      
      java.lang.AssertionError: Leader should exist
      	at org.junit.Assert.fail(Assert.java:88)
      	at org.junit.Assert.assertTrue(Assert.java:41)
      	at org.junit.Assert.assertNotNull(Assert.java:621)
      	at org.apache.hadoop.hbase.zookeeper.TestZKLeaderManager.testLeaderSelection(TestZKLeaderManager.java:148)
      
      1. 10987.txt
        0.7 kB
        Lars Hofhansl

        Activity

        Lars Hofhansl created issue -
        Hide
        Lars Hofhansl added a comment -

        Used all my software development powers to create this one-of-a-kind patch.

        Show
        Lars Hofhansl added a comment - Used all my software development powers to create this one-of-a-kind patch.
        Lars Hofhansl made changes -
        Field Original Value New Value
        Attachment 10987.txt [ 12640312 ]
        Hide
        Lars Hofhansl added a comment -

        Simple timeout change. Going to commit.

        Show
        Lars Hofhansl added a comment - Simple timeout change. Going to commit.
        Lars Hofhansl made changes -
        Fix Version/s 0.94.19 [ 12326287 ]
        Hide
        stack added a comment -

        +1

        Show
        stack added a comment - +1
        Hide
        stack added a comment -

        I think you should just commit these test fixups when they are so small (though powerful)

        Show
        stack added a comment - I think you should just commit these test fixups when they are so small (though powerful)
        Hide
        Lars Hofhansl added a comment - - edited

        Thanks stack

        Show
        Lars Hofhansl added a comment - - edited Thanks stack
        Lars Hofhansl made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.94-security #466 (See https://builds.apache.org/job/HBase-0.94-security/466/)
        HBASE-10987 Increase timeout in TestZKLeaderManager.testLeaderSelection. (larsh: rev 1587696)

        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKLeaderManager.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.94-security #466 (See https://builds.apache.org/job/HBase-0.94-security/466/ ) HBASE-10987 Increase timeout in TestZKLeaderManager.testLeaderSelection. (larsh: rev 1587696) /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKLeaderManager.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.94 #1347 (See https://builds.apache.org/job/HBase-0.94/1347/)
        HBASE-10987 Increase timeout in TestZKLeaderManager.testLeaderSelection. (larsh: rev 1587696)

        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKLeaderManager.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.94 #1347 (See https://builds.apache.org/job/HBase-0.94/1347/ ) HBASE-10987 Increase timeout in TestZKLeaderManager.testLeaderSelection. (larsh: rev 1587696) /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKLeaderManager.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.94-JDK7 #113 (See https://builds.apache.org/job/HBase-0.94-JDK7/113/)
        HBASE-10987 Increase timeout in TestZKLeaderManager.testLeaderSelection. (larsh: rev 1587696)

        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKLeaderManager.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.94-JDK7 #113 (See https://builds.apache.org/job/HBase-0.94-JDK7/113/ ) HBASE-10987 Increase timeout in TestZKLeaderManager.testLeaderSelection. (larsh: rev 1587696) /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKLeaderManager.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.94-on-Hadoop-2 #71 (See https://builds.apache.org/job/HBase-0.94-on-Hadoop-2/71/)
        HBASE-10987 Increase timeout in TestZKLeaderManager.testLeaderSelection. (larsh: rev 1587696)

        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKLeaderManager.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.94-on-Hadoop-2 #71 (See https://builds.apache.org/job/HBase-0.94-on-Hadoop-2/71/ ) HBASE-10987 Increase timeout in TestZKLeaderManager.testLeaderSelection. (larsh: rev 1587696) /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKLeaderManager.java
        Lars Hofhansl made changes -
        Issue Type Bug [ 1 ] Test [ 6 ]
        Lars Hofhansl made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        22m 31s 1 Lars Hofhansl 15/Apr/14 20:15
        Resolved Resolved Closed Closed
        13d 3h 13m 1 Lars Hofhansl 28/Apr/14 23:29

          People

          • Assignee:
            Lars Hofhansl
            Reporter:
            Lars Hofhansl
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development