[HBASE-10968] Null check in TableSnapshotInputFormat#TableSnapshotRegionRecordReader#initialize() is redundant

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.99.0
• Hadoop Flags: Reviewed
• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 12/Apr/14 01:10
• Updated: 21/Feb/15 23:30
• Resolved: 12/Apr/14 01:56

Description

Here is related code:

    public void initialize(InputSplit split, TaskAttemptContext context) throws IOException,
        InterruptedException {

      Configuration conf = context.getConfiguration();
...
      if (context != null) {
        this.context = context;
        getCounter = TableRecordReaderImpl.retrieveGetCounterWithStringsParams(context);
      }

context was dereferenced first, leaving the null check ineffective.