Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.99.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      We should really be more careful about spelling qualifier

        Activity

        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK #5050 (See https://builds.apache.org/job/HBase-TRUNK/5050/)
        HBASE-10864 Spelling nit (Alex Newman) (stack: rev 1582946)

        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/TablePermission.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/package.html
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWildcardColumnTracker.java
        • /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/get.rb
        • /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/scan.rb
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #5050 (See https://builds.apache.org/job/HBase-TRUNK/5050/ ) HBASE-10864 Spelling nit (Alex Newman) (stack: rev 1582946) /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/TablePermission.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/package.html /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWildcardColumnTracker.java /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/get.rb /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/scan.rb
        Hide
        stack added a comment -

        Committed to trunk. Thanks Alex.

        Show
        stack added a comment - Committed to trunk. Thanks Alex.
        Hide
        Alex Newman added a comment -

        Oh dear, i realized what the problem was, I plopped the wrong patch file in. The other one fixes something like 30 spelling mistakes. It may still be too minor

        Show
        Alex Newman added a comment - Oh dear, i realized what the problem was, I plopped the wrong patch file in. The other one fixes something like 30 spelling mistakes. It may still be too minor
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12637456/0001-HBASE-10715.-TimeRange-has-a-poorly-formatted-error-.patch
        against trunk revision .
        ATTACHMENT ID: 12637456

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9129//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12637456/0001-HBASE-10715.-TimeRange-has-a-poorly-formatted-error-.patch against trunk revision . ATTACHMENT ID: 12637456 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9129//console This message is automatically generated.
        Hide
        stack added a comment -

        Well, it is something to fix....

        Show
        stack added a comment - Well, it is something to fix....
        Hide
        Alex Newman added a comment -

        Ah no problem! Close her out. Sorry for the spam.

        Show
        Alex Newman added a comment - Ah no problem! Close her out. Sorry for the spam.
        Hide
        stack added a comment -

        Or, do a bunch at a time rather than piecemeal them in?

        Show
        stack added a comment - Or, do a bunch at a time rather than piecemeal them in?
        Hide
        stack added a comment -

        Alex, this and the next issue are too trivial to warrant issues. Contrib something more substantial like moving our pb to protostuff in a critical location.

        Show
        stack added a comment - Alex, this and the next issue are too trivial to warrant issues. Contrib something more substantial like moving our pb to protostuff in a critical location.

          People

          • Assignee:
            Alex Newman
            Reporter:
            Alex Newman
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development