Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.99.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      6 warnings
      [WARNING] Javadoc Warnings
      [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:338: warning - Tag @link: can't find isa in org.apache.hadoop.hbase.regionserver.HRegionServer
      [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServerInterface.java:45: warning - Tag @link: can't find openServer() in org.apache.hadoop.hbase.ipc.RpcServerInterface
      [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServerInterface.java:45: warning - Tag @link: can't find startThreads() in org.apache.hadoop.hbase.ipc.RpcServerInterface
      [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServerInterface.java:45: warning - Tag @link: can't find openServer() in org.apache.hadoop.hbase.ipc.RpcServerInterface
      [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServerInterface.java:45: warning - Tag @link: can't find startThreads() in org.apache.hadoop.hbase.ipc.RpcServerInterface
      [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java:721: warning - @param argument "controller" is not a parameter name.
      
      1. HBASE-10849.patch
        2 kB
        Anoop Sam John

        Activity

        Anoop Sam John created issue -
        Anoop Sam John made changes -
        Field Original Value New Value
        Attachment HBASE-10849.patch [ 12637123 ]
        Anoop Sam John made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Jonathan Hsieh added a comment -

        instead of deleting all the comments, can you fix the links or make them generic and not java doc links so that this design info is not lost?

        Show
        Jonathan Hsieh added a comment - instead of deleting all the comments, can you fix the links or make them generic and not java doc links so that this design info is not lost?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12637123/HBASE-10849.patch
        against trunk revision .
        ATTACHMENT ID: 12637123

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.master.TestMasterNoCluster
        org.apache.hadoop.hbase.snapshot.TestExportSnapshot

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9110//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9110//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9110//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9110//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9110//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9110//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9110//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9110//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9110//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9110//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9110//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12637123/HBASE-10849.patch against trunk revision . ATTACHMENT ID: 12637123 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.master.TestMasterNoCluster org.apache.hadoop.hbase.snapshot.TestExportSnapshot Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9110//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9110//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9110//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9110//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9110//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9110//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9110//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9110//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9110//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9110//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9110//console This message is automatically generated.
        Hide
        Anoop Sam John added a comment -

        RpcServerInterface

        -/**
        - * RpcServer Interface.
        - * Start calls {@link #openServer()} and then {@link #startThreads()}.  Prefer {@link #start()}
        - * and {@link #stop()}.  Only use {@link #openServer()} and {@link #startThreads()} if in a
        - * situation where you could start getting requests though the server not up and fully
        - * initiaalized.
        - */
        

        This is the doc deletion. Here we speak abt calling openServer() and then startThreads() instead of start in certain situation. Now I can see these 2 methods removed.. There is only start() and stop. So I thought there is no relevance for the doc description.. Correct me if I am wrong.

        Ping Jimmy Xiang

        Show
        Anoop Sam John added a comment - RpcServerInterface -/** - * RpcServer Interface. - * Start calls {@link #openServer()} and then {@link #startThreads()}. Prefer {@link #start()} - * and {@link #stop()}. Only use {@link #openServer()} and {@link #startThreads()} if in a - * situation where you could start getting requests though the server not up and fully - * initiaalized. - */ This is the doc deletion. Here we speak abt calling openServer() and then startThreads() instead of start in certain situation. Now I can see these 2 methods removed.. There is only start() and stop. So I thought there is no relevance for the doc description.. Correct me if I am wrong. Ping Jimmy Xiang
        Hide
        Jimmy Xiang added a comment -

        Anoop Sam John, you are right. The doc should be updated. Thanks.

        Show
        Jimmy Xiang added a comment - Anoop Sam John , you are right. The doc should be updated. Thanks.
        Hide
        Jimmy Xiang added a comment -

        +1

        Show
        Jimmy Xiang added a comment - +1
        Hide
        Anoop Sam John added a comment -

        Jonathan Hsieh you fine about above explanation? If so we can commit.

        Show
        Anoop Sam John added a comment - Jonathan Hsieh you fine about above explanation? If so we can commit.
        Hide
        Jonathan Hsieh added a comment -

        ok, sounds good. I didn't realize the methods were actually removed – I thought it was deletion just to get ride of javadoc warns,

        Show
        Jonathan Hsieh added a comment - ok, sounds good. I didn't realize the methods were actually removed – I thought it was deletion just to get ride of javadoc warns,
        Hide
        Anoop Sam John added a comment -

        Committed to Trunk. Thanks for the reviews

        Show
        Anoop Sam John added a comment - Committed to Trunk. Thanks for the reviews
        Anoop Sam John made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Assignee Anoop Sam John [ anoop.hbase ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #5048 (See https://builds.apache.org/job/HBase-TRUNK/5048/)
        HBASE-10849 Fix increased javadoc warns.(Anoop) (anoopsamjohn: rev 1582832)

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServerInterface.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5048 (See https://builds.apache.org/job/HBase-TRUNK/5048/ ) HBASE-10849 Fix increased javadoc warns.(Anoop) (anoopsamjohn: rev 1582832) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServerInterface.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.
        Enis Soztutar made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        2m 22s 1 Anoop Sam John 27/Mar/14 10:52
        Patch Available Patch Available Resolved Resolved
        1d 6h 17m 1 Anoop Sam John 28/Mar/14 17:09
        Resolved Resolved Closed Closed
        330d 6h 22m 1 Enis Soztutar 21/Feb/15 23:31

          People

          • Assignee:
            Anoop Sam John
            Reporter:
            Anoop Sam John
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development