[HBASE-1083] Will keep scheduling major compactions if last time one ran, we didn't.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.19.0
• Assignee: Michael Stack
• Reporter: Michael Stack
• Created: 22/Dec/08 18:51
• Updated: 13/Sep/09 22:26
• Resolved: 05/Jan/09 22:34

Description

Excerpt below has major compactions scheduled ever few hours but nothing to compact each time through – last run was a major compaction – and times are off. Need to touch files if nothing to compact so major doesn't get scheduled again.

2008-12-20 02:41:03,933 DEBUG org.apache.hadoop.hbase.regionserver.HStore: Major compaction triggered on store: 170018656/content. Time since last major compaction: 249999 seconds
2008-12-20 05:27:43,933 DEBUG org.apache.hadoop.hbase.regionserver.HStore: Major compaction triggered on store: 170018656/content. Time since last major compaction: 259999 seconds
2008-12-20 08:14:23,932 DEBUG org.apache.hadoop.hbase.regionserver.HStore: Major compaction triggered on store: 170018656/content. Time since last major compaction: 269999 seconds
2008-12-20 11:01:03,932 DEBUG org.apache.hadoop.hbase.regionserver.HStore: Major compaction triggered on store: 170018656/content. Time since last major compaction: 279999 seconds
2008-12-20 13:47:43,932 DEBUG org.apache.hadoop.hbase.regionserver.HStore: Major compaction triggered on store: 170018656/content. Time since last major compaction: 289999 seconds
2008-12-20 16:34:23,932 DEBUG org.apache.hadoop.hbase.regionserver.HStore: Major compaction triggered on store: 170018656/content. Time since last major compaction: 299999 seconds
2008-12-20 19:21:03,933 DEBUG org.apache.hadoop.hbase.regionserver.HStore: Major compaction triggered on store: 170018656/content. Time since last major compaction: 309999 seconds
2008-12-20 22:07:43,932 DEBUG org.apache.hadoop.hbase.regionserver.HStore: Major compaction triggered on store: 170018656/content. Time since last major compaction: 319999 seconds

Then it says:

2008-12-20 13:47:43,935 DEBUG org.apache.hadoop.hbase.regionserver.HStore: Skipping major compaction because only one (major) compacted file only and elapsedTime 289999825 is < ttl=-1

I think whats happening is that we're not compacting because we just did but major compactions keep getting triggered because we are not updating the file timestamp. Look into it. At least fix up logging so its clearer whats happening.. Here is snippet:

2008-12-20 11:01:04,026 DEBUG org.apache.hadoop.hbase.regionserver.HStore: Skipping major compaction because only one (major) compacted file only and elapsedTime 149999850 is < ttl=-1
2008-12-20 11:01:04,026 INFO org.apache.hadoop.hbase.regionserver.HRegion: compaction completed on region assigners,,1229364037757 in 0sec
2008-12-20 13:47:43,932 DEBUG org.apache.hadoop.hbase.regionserver.HStore: Major compaction triggered on store: 170018656/content. Time since last major compaction: 289999 seconds
2008-12-20 13:47:43,932 DEBUG org.apache.hadoop.hbase.regionserver.CompactSplitThread: Compaction requested for region streamitems,^@^@^@^@^C�r�,1229427582771 because: regionserver/0:0:0:0:0:0:0:0:60020.majorCompactionChecker requests major compaction
2008-12-20 13:47:43,932 INFO org.apache.hadoop.hbase.regionserver.HRegion: starting compaction on region streamitems,^@^@^@^@^C�r�,1229427582771
2008-12-20 13:47:43,934 DEBUG org.apache.hadoop.hbase.regionserver.HStore: Major compaction triggered on store: 65151897/content. Time since last major compaction: 259999 seconds
2008-12-20 13:47:43,934 DEBUG org.apache.hadoop.hbase.regionserver.CompactSplitThread: Compaction requested for region streamitems,^@^@^@^@^C3=�,1229459727659 because: regionserver/0:0:0:0:0:0:0:0:60020.majorCompactionChecker requests major compaction
2008-12-20 13:47:43,935 DEBUG org.apache.hadoop.hbase.regionserver.HStore: Major compaction triggered on store: 1579534353/content. Time since last major compaction: 259983 seconds
2008-12-20 13:47:43,935 DEBUG org.apache.hadoop.hbase.regionserver.CompactSplitThread: Compaction requested for region streamitems,^@^@^@^@^AV^Ds,1229459695202 because: regionserver/0:0:0:0:0:0:0:0:60020.majorCompactionChecker requests major compaction
2008-12-20 13:47:43,935 DEBUG org.apache.hadoop.hbase.regionserver.HStore: Skipping major compaction because only one (major) compacted file only and elapsedTime 289999825 is < ttl=-1
2008-12-20 13:47:43,936 DEBUG org.apache.hadoop.hbase.regionserver.HStore: Major compaction triggered on store: 1277711984/content. Time since last major compaction: 339999 seconds
...