[HBASE-10824] Enhance detection of protobuf generated code in line length check

• Type: Task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.99.0
• Hadoop Flags: Reviewed
• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 25/Mar/14 03:34
• Updated: 21/Feb/15 23:30
• Resolved: 25/Mar/14 14:50

Description

In review of HBASE-5175, Anoop found that long line detection wasn't very effective for protobuf generated code.
Here is one example:

-1 lineLengths. The patch introduces the following lines longer than 100:
+ private DoubleMsg(boolean noInit)
{ this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }

This is current filter:

  lines=`cat $PATCH_DIR/patch | grep "^+" | grep -v "^@@" | grep -v "^+++" | grep -v "import" | grep -v "hbase.protobuf.generated" | awk -v len="$MAX_LINE_LENGTH_PATCH"    'length ($0) > len' | head -n 10`

'com.google.protobuf.' should be considered as well.