[HBASE-10749] CellComparator.compareStatic() compares type wrongly

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.98.1, 0.99.0, 0.96.1.1
• Fix Version/s: 0.96.2, 0.98.1, 0.99.0
• Hadoop Flags: Reviewed
• Assignee: ramkrishna.s.vasudevan
• Reporter: ramkrishna.s.vasudevan
• Created: 14/Mar/14 10:29
• Updated: 21/Feb/15 23:32
• Resolved: 15/Mar/14 00:09

Description

CellComparator.compareStatic(Cell a, Cell b) compares type wrongly.

    //type
    c = (0xff & a.getTypeByte()) - (0xff & b.getTypeByte());
    if (c != 0) return c;

In the normal case it should be the other way

      // Compare types. Let the delete types sort ahead of puts; i.e. types
      // of higher numbers sort before those of lesser numbers. Maximum (255)
      // appears ahead of everything, and minimum (0) appears after
      // everything.
      return (0xff & rtype) - (0xff & ltype);

Found this issue while replacing KVComparator to use CellComparator.
mcorgan
Could you confirm this once? Currently PrefixTree code path uses this compareStatic method.