Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.98.0, 0.96.0, 0.99.0
    • Fix Version/s: 0.96.2, 0.98.1, 0.99.0
    • Component/s: Client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      HTablePool and HTableFactory are relics and are going away. See HConnection#getTable instead.

      Description

      Per parent ticket, deprecate these ways to retrieve an HTable instance.

      1. HBASE-10741.01.patch
        2 kB
        Nick Dimiduk
      2. HBASE-10741.00.patch
        1 kB
        Nick Dimiduk

        Activity

        Hide
        Nick Dimiduk added a comment -

        Andrew Purtell I wouldn't mind sneaking this into 0.98.1 if you haven't spun the RC yet.

        Show
        Nick Dimiduk added a comment - Andrew Purtell I wouldn't mind sneaking this into 0.98.1 if you haven't spun the RC yet.
        Hide
        stack added a comment -

        lgtm

        On commit add 'since 0.98.1' to the javadoc deprecation tag.

        Show
        stack added a comment - lgtm On commit add 'since 0.98.1' to the javadoc deprecation tag.
        Hide
        Andrew Purtell added a comment -

        Go for it!

        Show
        Andrew Purtell added a comment - Go for it!
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12634539/HBASE-10741.00.patch
        against trunk revision .
        ATTACHMENT ID: 12634539

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:

        -1 core zombie tests. There are 1 zombie test(s): at org.apache.hadoop.hbase.regionserver.wal.TestLogRolling.testLogRollOnDatanodeDeath(TestLogRolling.java:368)

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8977//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8977//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8977//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8977//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8977//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8977//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8977//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8977//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8977//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8977//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8977//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12634539/HBASE-10741.00.patch against trunk revision . ATTACHMENT ID: 12634539 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: -1 core zombie tests . There are 1 zombie test(s): at org.apache.hadoop.hbase.regionserver.wal.TestLogRolling.testLogRollOnDatanodeDeath(TestLogRolling.java:368) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8977//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8977//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8977//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8977//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8977//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8977//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8977//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8977//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8977//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8977//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8977//console This message is automatically generated.
        Hide
        stack added a comment -

        The failures cannot be related...

        Show
        stack added a comment - The failures cannot be related...
        Hide
        Nick Dimiduk added a comment -

        I don't want to confuse with the @since annotation (http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html#@since). Will instead use:

        @deprecated as of 0.98.1. See HConnectionManager#createConnection
        
        Show
        Nick Dimiduk added a comment - I don't want to confuse with the @since annotation ( http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html#@since ). Will instead use: @deprecated as of 0.98.1. See HConnectionManager#createConnection
        Hide
        Nick Dimiduk added a comment -

        Committed to three branches. Thanks for the review.

        Show
        Nick Dimiduk added a comment - Committed to three branches. Thanks for the review.
        Hide
        Nick Dimiduk added a comment -

        Attaching what was committed.

        Show
        Nick Dimiduk added a comment - Attaching what was committed.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #5011 (See https://builds.apache.org/job/HBase-TRUNK/5011/)
        HBASE-10741 Deprecate HTablePool and HTableFactory (ndimiduk: rev 1577624)

        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableFactory.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5011 (See https://builds.apache.org/job/HBase-TRUNK/5011/ ) HBASE-10741 Deprecate HTablePool and HTableFactory (ndimiduk: rev 1577624) /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableFactory.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in hbase-0.96-hadoop2 #239 (See https://builds.apache.org/job/hbase-0.96-hadoop2/239/)
        HBASE-10741 Deprecate HTablePool and HTableFactory (ndimiduk: rev 1577631)

        • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableFactory.java
        • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
        Show
        Hudson added a comment - FAILURE: Integrated in hbase-0.96-hadoop2 #239 (See https://builds.apache.org/job/hbase-0.96-hadoop2/239/ ) HBASE-10741 Deprecate HTablePool and HTableFactory (ndimiduk: rev 1577631) /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableFactory.java /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in hbase-0.96 #349 (See https://builds.apache.org/job/hbase-0.96/349/)
        HBASE-10741 Deprecate HTablePool and HTableFactory (ndimiduk: rev 1577631)

        • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableFactory.java
        • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
        Show
        Hudson added a comment - FAILURE: Integrated in hbase-0.96 #349 (See https://builds.apache.org/job/hbase-0.96/349/ ) HBASE-10741 Deprecate HTablePool and HTableFactory (ndimiduk: rev 1577631) /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableFactory.java /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.98 #232 (See https://builds.apache.org/job/HBase-0.98/232/)
        HBASE-10741 Deprecate HTablePool and HTableFactory (ndimiduk: rev 1577629)

        • /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableFactory.java
        • /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.98 #232 (See https://builds.apache.org/job/HBase-0.98/232/ ) HBASE-10741 Deprecate HTablePool and HTableFactory (ndimiduk: rev 1577629) /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableFactory.java /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #217 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/217/)
        HBASE-10741 Deprecate HTablePool and HTableFactory (ndimiduk: rev 1577629)

        • /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableFactory.java
        • /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #217 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/217/ ) HBASE-10741 Deprecate HTablePool and HTableFactory (ndimiduk: rev 1577629) /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableFactory.java /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #118 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/118/)
        HBASE-10741 Deprecate HTablePool and HTableFactory (ndimiduk: rev 1577624)

        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableFactory.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #118 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/118/ ) HBASE-10741 Deprecate HTablePool and HTableFactory (ndimiduk: rev 1577624) /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableFactory.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

          People

          • Assignee:
            Nick Dimiduk
            Reporter:
            Nick Dimiduk
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development