Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-10738

AssignmentManager should shut down executors on stop

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.96.2, 0.98.1, 0.99.0, 0.94.18
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This won't cause any issue in live cluster. However, in unit tests, it could leak threads and slow down tests.

      1. hbase-10738.patch
        0.6 kB
        Jimmy Xiang

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12634458/hbase-10738.patch
        against trunk revision .
        ATTACHMENT ID: 12634458

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8972//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8972//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8972//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8972//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8972//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8972//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8972//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8972//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8972//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8972//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8972//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12634458/hbase-10738.patch against trunk revision . ATTACHMENT ID: 12634458 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8972//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8972//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8972//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8972//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8972//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8972//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8972//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8972//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8972//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8972//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8972//console This message is automatically generated.
        Hide
        stack stack added a comment -

        +1

        Show
        stack stack added a comment - +1
        Hide
        jxiang Jimmy Xiang added a comment -

        Integrated into 0.96, 0.98, and trunk. Thanks Stack for the review.

        Show
        jxiang Jimmy Xiang added a comment - Integrated into 0.96, 0.98, and trunk. Thanks Stack for the review.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in hbase-0.96-hadoop2 #237 (See https://builds.apache.org/job/hbase-0.96-hadoop2/237/)
        HBASE-10738 AssignmentManager should shut down executors on stop (jxiang: rev 1577359)

        • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in hbase-0.96-hadoop2 #237 (See https://builds.apache.org/job/hbase-0.96-hadoop2/237/ ) HBASE-10738 AssignmentManager should shut down executors on stop (jxiang: rev 1577359) /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
        Hide
        lhofhansl Lars Hofhansl added a comment -

        Looks like this would be good for 0.94 too. Jimmy Xiang, any reason this shouldn't be in 0.94?

        Show
        lhofhansl Lars Hofhansl added a comment - Looks like this would be good for 0.94 too. Jimmy Xiang , any reason this shouldn't be in 0.94?
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #5007 (See https://builds.apache.org/job/HBase-TRUNK/5007/)
        HBASE-10738 AssignmentManager should shut down executors on stop (jxiang: rev 1577357)

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5007 (See https://builds.apache.org/job/HBase-TRUNK/5007/ ) HBASE-10738 AssignmentManager should shut down executors on stop (jxiang: rev 1577357) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98 #227 (See https://builds.apache.org/job/HBase-0.98/227/)
        HBASE-10738 AssignmentManager should shut down executors on stop (jxiang: rev 1577358)

        • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #227 (See https://builds.apache.org/job/HBase-0.98/227/ ) HBASE-10738 AssignmentManager should shut down executors on stop (jxiang: rev 1577358) /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
        Hide
        jxiang Jimmy Xiang added a comment -

        Yes, it is good for 0.94 too. Checked into 0.94 as well. Thanks for reminding me.

        Show
        jxiang Jimmy Xiang added a comment - Yes, it is good for 0.94 too. Checked into 0.94 as well. Thanks for reminding me.
        Hide
        lhofhansl Lars Hofhansl added a comment -

        Thanks Jimmy Xiang!

        Show
        lhofhansl Lars Hofhansl added a comment - Thanks Jimmy Xiang !
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in hbase-0.96 #345 (See https://builds.apache.org/job/hbase-0.96/345/)
        HBASE-10738 AssignmentManager should shut down executors on stop (jxiang: rev 1577359)

        • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in hbase-0.96 #345 (See https://builds.apache.org/job/hbase-0.96/345/ ) HBASE-10738 AssignmentManager should shut down executors on stop (jxiang: rev 1577359) /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in HBase-0.94-on-Hadoop-2 #51 (See https://builds.apache.org/job/HBase-0.94-on-Hadoop-2/51/)
        HBASE-10738 AssignmentManager should shut down executors on stop (jxiang: rev 1577407)

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in HBase-0.94-on-Hadoop-2 #51 (See https://builds.apache.org/job/HBase-0.94-on-Hadoop-2/51/ ) HBASE-10738 AssignmentManager should shut down executors on stop (jxiang: rev 1577407) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in HBase-0.94-security #441 (See https://builds.apache.org/job/HBase-0.94-security/441/)
        HBASE-10738 AssignmentManager should shut down executors on stop (jxiang: rev 1577407)

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in HBase-0.94-security #441 (See https://builds.apache.org/job/HBase-0.94-security/441/ ) HBASE-10738 AssignmentManager should shut down executors on stop (jxiang: rev 1577407) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #213 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/213/)
        HBASE-10738 AssignmentManager should shut down executors on stop (jxiang: rev 1577358)

        • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #213 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/213/ ) HBASE-10738 AssignmentManager should shut down executors on stop (jxiang: rev 1577358) /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in HBase-0.94 #1322 (See https://builds.apache.org/job/HBase-0.94/1322/)
        HBASE-10738 AssignmentManager should shut down executors on stop (jxiang: rev 1577407)

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in HBase-0.94 #1322 (See https://builds.apache.org/job/HBase-0.94/1322/ ) HBASE-10738 AssignmentManager should shut down executors on stop (jxiang: rev 1577407) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in HBase-0.94-JDK7 #85 (See https://builds.apache.org/job/HBase-0.94-JDK7/85/)
        HBASE-10738 AssignmentManager should shut down executors on stop (jxiang: rev 1577407)

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in HBase-0.94-JDK7 #85 (See https://builds.apache.org/job/HBase-0.94-JDK7/85/ ) HBASE-10738 AssignmentManager should shut down executors on stop (jxiang: rev 1577407) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #117 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/117/)
        HBASE-10738 AssignmentManager should shut down executors on stop (jxiang: rev 1577357)

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #117 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/117/ ) HBASE-10738 AssignmentManager should shut down executors on stop (jxiang: rev 1577357) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java

          People

          • Assignee:
            jxiang Jimmy Xiang
            Reporter:
            jxiang Jimmy Xiang
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development