Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.1, 0.99.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      TestExplicitColumnTracker previously extends HBaseTestCase.

      This task converts it to junit4 test.

      1. 10723-v2.txt
        3 kB
        Ted Yu
      2. 10723-v1.txt
        2 kB
        Ted Yu

        Activity

        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.
        Hide
        Ted Yu added a comment -

        HBASE-10514 converts some tests to junit4.

        I can do bigger patch for the remaining tests.

        Show
        Ted Yu added a comment - HBASE-10514 converts some tests to junit4. I can do bigger patch for the remaining tests.
        Hide
        stack added a comment -

        Ted Yu Are you going to open an issue for each convertion? Why not do a big batch in one go?

        Show
        stack added a comment - Ted Yu Are you going to open an issue for each convertion? Why not do a big batch in one go?
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #114 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/114/)
        HBASE-10723 Convert TestExplicitColumnTracker to junit4 test (tedyu: rev 1576542)

        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestExplicitColumnTracker.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #114 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/114/ ) HBASE-10723 Convert TestExplicitColumnTracker to junit4 test (tedyu: rev 1576542) /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestExplicitColumnTracker.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98 #221 (See https://builds.apache.org/job/HBase-0.98/221/)
        HBASE-10723 Convert TestExplicitColumnTracker to junit4 test (tedyu: rev 1576541)

        • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestExplicitColumnTracker.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #221 (See https://builds.apache.org/job/HBase-0.98/221/ ) HBASE-10723 Convert TestExplicitColumnTracker to junit4 test (tedyu: rev 1576541) /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestExplicitColumnTracker.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK #4999 (See https://builds.apache.org/job/HBase-TRUNK/4999/)
        HBASE-10723 Convert TestExplicitColumnTracker to junit4 test (tedyu: rev 1576542)

        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestExplicitColumnTracker.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4999 (See https://builds.apache.org/job/HBase-TRUNK/4999/ ) HBASE-10723 Convert TestExplicitColumnTracker to junit4 test (tedyu: rev 1576542) /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestExplicitColumnTracker.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #207 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/207/)
        HBASE-10723 Convert TestExplicitColumnTracker to junit4 test (tedyu: rev 1576541)

        • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestExplicitColumnTracker.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #207 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/207/ ) HBASE-10723 Convert TestExplicitColumnTracker to junit4 test (tedyu: rev 1576541) /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestExplicitColumnTracker.java
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12634019/10723-v2.txt
        against trunk revision .
        ATTACHMENT ID: 12634019

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8952//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8952//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8952//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8952//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8952//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8952//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8952//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8952//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8952//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8952//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8952//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12634019/10723-v2.txt against trunk revision . ATTACHMENT ID: 12634019 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8952//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8952//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8952//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8952//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8952//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8952//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8952//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8952//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8952//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8952//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8952//console This message is automatically generated.
        Hide
        Nick Dimiduk added a comment -

        Thanks, another +1

        Show
        Nick Dimiduk added a comment - Thanks, another +1
        Hide
        Nick Dimiduk added a comment -

        +1

        While you're in there, mind getting rid of that ugly PRINT business? It doesn't appear to add any value.

        Show
        Nick Dimiduk added a comment - +1 While you're in there, mind getting rid of that ugly PRINT business? It doesn't appear to add any value.

          People

          • Assignee:
            Ted Yu
            Reporter:
            Ted Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development