Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.99.0
    • Component/s: regionserver, Replication
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Activity

      Hide
      Honghua Feng added a comment -

      patch attached

      Show
      Honghua Feng added a comment - patch attached
      Hide
      Honghua Feng added a comment -

      Strictly speaking the previous implementation is correct in logic since the loop is terminated by setting running to false and interrupting the hosting thread concurrently, but it's still better to align with the standard handling idiom here.

      Show
      Honghua Feng added a comment - Strictly speaking the previous implementation is correct in logic since the loop is terminated by setting running to false and interrupting the hosting thread concurrently, but it's still better to align with the standard handling idiom here.
      Hide
      Nicolas Liochon added a comment -

      Yeah, not necessary but more consistent. +1. Will commit tomorrow if nobody disagrees.

      Show
      Nicolas Liochon added a comment - Yeah, not necessary but more consistent. +1. Will commit tomorrow if nobody disagrees.
      Hide
      stack added a comment -

      lgtm

      Show
      stack added a comment - lgtm
      Hide
      Honghua Feng added a comment -

      Thank Nicolas Liochon and stack for the prompt review!

      Show
      Honghua Feng added a comment - Thank Nicolas Liochon and stack for the prompt review!
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12632008/HBASE-10652-trunk_v1.patch
      against trunk revision .
      ATTACHMENT ID: 12632008

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

      +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 lineLengths. The patch does not introduce lines longer than 100

      +1 site. The mvn site goal succeeds with this patch.

      +1 core tests. The patch passed unit tests in .

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8870//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8870//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8870//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8870//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8870//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8870//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8870//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8870//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8870//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8870//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8870//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12632008/HBASE-10652-trunk_v1.patch against trunk revision . ATTACHMENT ID: 12632008 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8870//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8870//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8870//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8870//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8870//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8870//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8870//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8870//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8870//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8870//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8870//console This message is automatically generated.
      Hide
      Nicolas Liochon added a comment -

      Committed to trunk, thanks for the patch!

      Show
      Nicolas Liochon added a comment - Committed to trunk, thanks for the patch!
      Hide
      Hudson added a comment -

      SUCCESS: Integrated in HBase-TRUNK #4975 (See https://builds.apache.org/job/HBase-TRUNK/4975/)
      HBASE-10652 Fix incorrect handling of IE that restores current thread's interrupt status within while/for loops in rpc (Feng Honghua) (nkeywal: rev 1573937)

      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java
      Show
      Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4975 (See https://builds.apache.org/job/HBase-TRUNK/4975/ ) HBASE-10652 Fix incorrect handling of IE that restores current thread's interrupt status within while/for loops in rpc (Feng Honghua) (nkeywal: rev 1573937) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java
      Hide
      Hudson added a comment -

      FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #107 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/107/)
      HBASE-10652 Fix incorrect handling of IE that restores current thread's interrupt status within while/for loops in rpc (Feng Honghua) (nkeywal: rev 1573937)

      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java
      Show
      Hudson added a comment - FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #107 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/107/ ) HBASE-10652 Fix incorrect handling of IE that restores current thread's interrupt status within while/for loops in rpc (Feng Honghua) (nkeywal: rev 1573937) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java
      Hide
      Enis Soztutar added a comment -

      Closing this issue after 0.99.0 release.

      Show
      Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

        People

        • Assignee:
          Honghua Feng
          Reporter:
          Honghua Feng
        • Votes:
          0 Vote for this issue
          Watchers:
          6 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development