Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-10611

Description for hbase:acl table is wrong on master-status#catalogTables

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.96.0
    • Fix Version/s: 0.99.0, 0.98.2
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      On master-status#catalogTables, I see:

      hbase:acl The .NAMESPACE. table holds information about namespaces.

      In MasterStatusTmpl.jamon, we have:

              if (tableName.equals(TableName.META_TABLE_NAME)){
                  description = "The hbase:meta table holds references to all User Table regions";
              } else {
                  description = "The .NAMESPACE. table holds information about namespaces.";
              }
      

      The above check doesn't cover hbase:acl table.

      1. HBASE-10611.1.patch
        2 kB
        Rekha Joshi
      2. HBASE-10611.1.patch
        2 kB
        Rekha Joshi
      3. HBASE-10611.2.patch
        1 kB
        Rekha Joshi

        Activity

        Hide
        anoop.hbase Anoop Sam John added a comment -

        The above check doesn't cover hbase:acl table.

        Yes. Visibility labels table too.

        Show
        anoop.hbase Anoop Sam John added a comment - The above check doesn't cover hbase:acl table. Yes. Visibility labels table too.
        Hide
        rekhajoshm Rekha Joshi added a comment -

        Attached patch on 0.96

        Show
        rekhajoshm Rekha Joshi added a comment - Attached patch on 0.96
        Hide
        rekhajoshm Rekha Joshi added a comment -

        Attached patch on 0.96
        (Anoop - Hi. Visibility label is on latest, 0.98.facing some issues on latest build)

        Show
        rekhajoshm Rekha Joshi added a comment - Attached patch on 0.96 (Anoop - Hi. Visibility label is on latest, 0.98.facing some issues on latest build)
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12636668/HBASE-10611.1.patch
        against trunk revision .
        ATTACHMENT ID: 12636668

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9088//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9088//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9088//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9088//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9088//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9088//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9088//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9088//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9088//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9088//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9088//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12636668/HBASE-10611.1.patch against trunk revision . ATTACHMENT ID: 12636668 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9088//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9088//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9088//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9088//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9088//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9088//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9088//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9088//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9088//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9088//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9088//console This message is automatically generated.
        Hide
        yuzhihong@gmail.com Ted Yu added a comment -

        @Rekha:
        Can you handle visibility labels table as well ?

        Thanks

        Show
        yuzhihong@gmail.com Ted Yu added a comment - @Rekha: Can you handle visibility labels table as well ? Thanks
        Hide
        rekhajoshm Rekha Joshi added a comment -

        Attached patch with visibility label.

        Show
        rekhajoshm Rekha Joshi added a comment - Attached patch with visibility label.
        Hide
        rekhajoshm Rekha Joshi added a comment -

        Attached patch with visibility label.Thanks

        Show
        rekhajoshm Rekha Joshi added a comment - Attached patch with visibility label.Thanks
        Hide
        yuzhihong@gmail.com Ted Yu added a comment -

        Patch is not integrated yet

        Show
        yuzhihong@gmail.com Ted Yu added a comment - Patch is not integrated yet
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12642203/HBASE-10611.1.patch
        against trunk revision .
        ATTACHMENT ID: 12642203

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9412//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12642203/HBASE-10611.1.patch against trunk revision . ATTACHMENT ID: 12642203 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9412//console This message is automatically generated.
        Hide
        yuzhihong@gmail.com Ted Yu added a comment -

        acl has been renamed hbase:acl

        You can utilize the following constant in hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java for labels table :

          public static final TableName LABELS_TABLE_NAME = TableName.valueOf(
              NamespaceDescriptor.SYSTEM_NAMESPACE_NAME_STR, "labels");
        
        Show
        yuzhihong@gmail.com Ted Yu added a comment - acl has been renamed hbase:acl You can utilize the following constant in hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java for labels table : public static final TableName LABELS_TABLE_NAME = TableName.valueOf( NamespaceDescriptor.SYSTEM_NAMESPACE_NAME_STR, "labels" );
        Hide
        anoop.hbase Anoop Sam John added a comment -

        For acl table also no need to add the constant
        Refer to constant in AccessControlLists

        public static final TableName ACL_TABLE_NAME =
              TableName.valueOf(NamespaceDescriptor.SYSTEM_NAMESPACE_NAME_STR, "acl");
        
        Show
        anoop.hbase Anoop Sam John added a comment - For acl table also no need to add the constant Refer to constant in AccessControlLists public static final TableName ACL_TABLE_NAME = TableName.valueOf(NamespaceDescriptor.SYSTEM_NAMESPACE_NAME_STR, "acl" );
        Hide
        rekhajoshm Rekha Joshi added a comment -

        Attached patch.Thanks.

        Show
        rekhajoshm Rekha Joshi added a comment - Attached patch.Thanks.
        Hide
        anoop.hbase Anoop Sam John added a comment -

        Wait ! This is generated file
        // Autogenerated Jamon proxy
        // C:/Code/HBase/_trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon

        Show
        anoop.hbase Anoop Sam John added a comment - Wait ! This is generated file // Autogenerated Jamon proxy // C:/Code/HBase/_trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
        Hide
        rekhajoshm Rekha Joshi added a comment -

        Anoop Sam John - not sure i understand.think i modified the correct file - /hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon

        Show
        rekhajoshm Rekha Joshi added a comment - Anoop Sam John - not sure i understand.think i modified the correct file - /hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
        Hide
        anoop.hbase Anoop Sam John added a comment -

        Oh! I misread.. I thought u changed .java file.. Yes looks good to me

        Show
        anoop.hbase Anoop Sam John added a comment - Oh! I misread.. I thought u changed .java file.. Yes looks good to me
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12642413/HBASE-10611.2.patch
        against trunk revision .
        ATTACHMENT ID: 12642413

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9422//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9422//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9422//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9422//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9422//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9422//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9422//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9422//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9422//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9422//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9422//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12642413/HBASE-10611.2.patch against trunk revision . ATTACHMENT ID: 12642413 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9422//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9422//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9422//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9422//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9422//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9422//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9422//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9422//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9422//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9422//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9422//console This message is automatically generated.
        Hide
        stack stack added a comment -

        +1

        Show
        stack stack added a comment - +1
        Hide
        yuzhihong@gmail.com Ted Yu added a comment -

        Integrated to 0.98 and trunk.

        Thanks for the patch, Rekha.

        Show
        yuzhihong@gmail.com Ted Yu added a comment - Integrated to 0.98 and trunk. Thanks for the patch, Rekha.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98 #300 (See https://builds.apache.org/job/HBase-0.98/300/)
        HBASE-10611 Description for hbase:acl table is wrong on master-status#catalogTables (Rekha Joshi) (tedyu: rev 1591069)

        • /hbase/branches/0.98/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #300 (See https://builds.apache.org/job/HBase-0.98/300/ ) HBASE-10611 Description for hbase:acl table is wrong on master-status#catalogTables (Rekha Joshi) (tedyu: rev 1591069) /hbase/branches/0.98/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in HBase-0.98-on-Hadoop-1.1 #285 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/285/)
        HBASE-10611 Description for hbase:acl table is wrong on master-status#catalogTables (Rekha Joshi) (tedyu: rev 1591069)

        • /hbase/branches/0.98/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
        Show
        hudson Hudson added a comment - ABORTED: Integrated in HBase-0.98-on-Hadoop-1.1 #285 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/285/ ) HBASE-10611 Description for hbase:acl table is wrong on master-status#catalogTables (Rekha Joshi) (tedyu: rev 1591069) /hbase/branches/0.98/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in HBase-TRUNK #5125 (See https://builds.apache.org/job/HBase-TRUNK/5125/)
        HBASE-10611 Description for hbase:acl table is wrong on master-status#catalogTables (Rekha Joshi) (tedyu: rev 1591070)

        • /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
        Show
        hudson Hudson added a comment - ABORTED: Integrated in HBase-TRUNK #5125 (See https://builds.apache.org/job/HBase-TRUNK/5125/ ) HBASE-10611 Description for hbase:acl table is wrong on master-status#catalogTables (Rekha Joshi) (tedyu: rev 1591070) /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
        Hide
        enis Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        enis Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

          People

          • Assignee:
            rekhajoshm Rekha Joshi
            Reporter:
            yuzhihong@gmail.com Ted Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development