HBase
  1. HBase
  2. HBASE-10578

For the same row key, the KV in the newest StoreFile should be returned

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 0.89-fb, 0.99.0, 0.98.2
    • Fix Version/s: 0.89-fb
    • Component/s: Scanners
    • Labels:
      None

      Description

      When multiple scanners have the same KV, HBase should pick the "newest" one.
      i.e. pick the KV from the store file with the largest seq id.

      In the KeyValueHeap generalizedSeek implementation, we seem to prefer the "current"
      scanner over the scanners in the heap – THIS IS WRONG.

      The diff adds a unit test to make sure that bulk loads correctly. And fixes the issue.

      1. HBASE-10578-v2.patch
        10 kB
        Amitanand Aiyer
      2. HBASE-10578.patch
        9 kB
        Amitanand Aiyer

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        2m 25s 1 Amitanand Aiyer 20/Feb/14 21:33
        Patch Available Patch Available Resolved Resolved
        515d 21h 33m 1 Elliott Clark 21/Jul/15 20:06
        Elliott Clark made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Won't Fix [ 2 ]
        Andrew Purtell made changes -
        Affects Version/s 0.99.0 [ 12325675 ]
        Affects Version/s 0.98.2 [ 12326505 ]
        Affects Version/s 0.98.1 [ 12325664 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12630192/HBASE-10578-v2.patch
        against trunk revision .
        ATTACHMENT ID: 12630192

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 4 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8761//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12630192/HBASE-10578-v2.patch against trunk revision . ATTACHMENT ID: 12630192 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8761//console This message is automatically generated.
        Hide
        stack added a comment -

        We have this issue in trunk too. The patch looks like it'll apply too...

        Show
        stack added a comment - We have this issue in trunk too. The patch looks like it'll apply too...
        Hide
        stack added a comment -

        Amitanand Aiyer Yeah, our little hadoopqa bot just runs whatever is posted against trunk... just ignore.

        Show
        stack added a comment - Amitanand Aiyer Yeah, our little hadoopqa bot just runs whatever is posted against trunk... just ignore.
        Amitanand Aiyer made changes -
        Attachment HBASE-10578-v2.patch [ 12630192 ]
        Hide
        Amitanand Aiyer added a comment -

        This file is intended to be applied over 0.89-fb.

        Not sure why HadoopQA tries to apply this over opensource trunk, and complain about it.

        Show
        Amitanand Aiyer added a comment - This file is intended to be applied over 0.89-fb. Not sure why HadoopQA tries to apply this over opensource trunk, and complain about it.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12630159/HBASE-10578.patch
        against trunk revision .
        ATTACHMENT ID: 12630159

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 4 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8759//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12630159/HBASE-10578.patch against trunk revision . ATTACHMENT ID: 12630159 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8759//console This message is automatically generated.
        Hide
        Liyin Tang added a comment -

        Nice finding !

        Show
        Liyin Tang added a comment - Nice finding !
        Amitanand Aiyer made changes -
        Attachment HBASE-10578.patch [ 12630159 ]
        Amitanand Aiyer made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Assignee Amitanand Aiyer [ amitanand ]
        Fix Version/s 0.89-fb [ 12320178 ]
        Amitanand Aiyer made changes -
        Field Original Value New Value
        Description When multiple scanners have the same KV, HBase should pick the "newest" one.
        i.e. pick the KV from the store file with the largest seq id.

        In the KeyValueHeap generalizedSeek implementation, we seem to prefer the "current"
        scanner over the scanners in the heap -- THIS IS WRONG.

        The diff adds a unit test to make sure that bulk loads correctly. And fixes the issue.
        Amitanand Aiyer created issue -

          People

          • Assignee:
            Amitanand Aiyer
            Reporter:
            Amitanand Aiyer
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development