HBase
  1. HBase
  2. HBASE-10548

Correct commons-math dependency version

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.96.2, 0.98.1, 0.99.0
    • Fix Version/s: 0.96.2, 0.98.1, 0.99.0, hbase-10070
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Downgrades HBase's dependency on commons-math to 2.1, which is consistent with all stable releases of Hadoop.

      Description

      From my comment on HBASE-10511:

      I have hadoop-1.2.1 installed from tgz, which packages commons-math-2.1. This is different from the listed maven dependency, 2.2.

      $ tar tvf hadoop-1.2.1.tar.gz | grep commons-math
      -rw-rw-r--  0 0      0      832410 Jul 22  2013 hadoop-1.2.1/lib/commons-math-2.1.jar
      $ mvn -f pom.xml.hadoop1 dependency:tree | grep commons-math
      [INFO] |  +- org.apache.commons:commons-math:jar:2.2:compile (version managed from 2.1)
      [INFO] |  +- org.apache.commons:commons-math:jar:2.2:compile (version managed from 2.1)
      [INFO] |  +- org.apache.commons:commons-math:jar:2.2:compile (version managed from 2.1)
      [INFO] |  +- org.apache.commons:commons-math:jar:2.2:compile (version managed from 2.1)
      [INFO] +- org.apache.commons:commons-math:jar:2.2:compile
      [INFO] |  +- org.apache.commons:commons-math:jar:2.2:compile
      [INFO] +- org.apache.commons:commons-math:jar:2.2:compile
      [INFO] |  +- org.apache.commons:commons-math:jar:2.2:compile
      [INFO] +- org.apache.commons:commons-math:jar:2.2:compile
      [INFO] |  +- org.apache.commons:commons-math:jar:2.2:compile
      [INFO] |  +- org.apache.commons:commons-math:jar:2.2:compile
      

      This is a problem because the 2.1 version of DescriptiveStatistics doesn't have a double[] constructor. Running the MR job, mappers fail:

      java.lang.NoSuchMethodError: org.apache.commons.math.stat.descriptive.DescriptiveStatistics.<init>([D)V
      	at org.apache.hadoop.hbase.PerformanceEvaluation$RandomReadTest.testTakedown(PerformanceEvaluation.java:1163)
      	at org.apache.hadoop.hbase.PerformanceEvaluation$Test.test(PerformanceEvaluation.java:984)
      	at org.apache.hadoop.hbase.PerformanceEvaluation.runOneClient(PerformanceEvaluation.java:1401)
      	at org.apache.hadoop.hbase.PerformanceEvaluation$EvaluationMapTask.map(PerformanceEvaluation.java:522)
      	at org.apache.hadoop.hbase.PerformanceEvaluation$EvaluationMapTask.map(PerformanceEvaluation.java:474)
      	at org.apache.hadoop.mapreduce.Mapper.run(Mapper.java:145)
      
      1. HBASE-10548.00.patch
        1 kB
        Nick Dimiduk
      2. HBASE-10548.01.patch
        2 kB
        Nick Dimiduk
      3. HBASE-10548.01-0.96.patch
        2 kB
        Nick Dimiduk
      4. HBASE-10548.01-0.98.patch
        2 kB
        Nick Dimiduk

        Issue Links

          Activity

          Nick Dimiduk created issue -
          Nick Dimiduk made changes -
          Field Original Value New Value
          Link This issue relates to HBASE-10511 [ HBASE-10511 ]
          Hide
          Nick Dimiduk added a comment -

          ping Nicolas Liochon Jean-Marc Spaggiari. Either of you guys able to repro this?

          Show
          Nick Dimiduk added a comment - ping Nicolas Liochon Jean-Marc Spaggiari . Either of you guys able to repro this?
          Nick Dimiduk made changes -
          Attachment HBASE-10548.00.patch [ 12629186 ]
          Nick Dimiduk made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Nick Dimiduk made changes -
          Priority Major [ 3 ] Minor [ 4 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12629186/HBASE-10548.00.patch
          against trunk revision .
          ATTACHMENT ID: 12629186

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 site. The patch appears to cause mvn site goal to fail.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8715//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8715//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12629186/HBASE-10548.00.patch against trunk revision . ATTACHMENT ID: 12629186 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8715//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8715//console This message is automatically generated.
          Hide
          stack added a comment -

          +1

          Show
          stack added a comment - +1
          Hide
          Jean-Marc Spaggiari added a comment -

          I have one cluster with hadoop 1.2.1, one with hadoop 1.0.3 and one with 2.2.0.

          On 1.0.3:
          hadoop@node3:~$ find . -name "commons-math*"
          ./hadoop-1.0.3/lib/commons-math-2.1.jar

          On 1.2.1:
          hadoop@hbasetest1:~$ find . -name "commons-math*"
          ./hadoop-1.2.1/lib/commons-math-2.1.jar

          On 2.2.0:
          hadoop@hbasetest1:~$ find . -name "commons-math*"
          ./share/hadoop/common/lib/commons-math-2.1.jar

          So I agree that we should "stick" with the 2.1 signature.

          Dependency on 2.2.0:
          jmspaggiari@t430s:~/test/hadoop-2.2.0$ mvn -f pom.xml dependency:tree | grep math
          [INFO] +- org.apache.commons:commons-math:jar:2.1:compile

          Show
          Jean-Marc Spaggiari added a comment - I have one cluster with hadoop 1.2.1, one with hadoop 1.0.3 and one with 2.2.0. On 1.0.3: hadoop@node3:~$ find . -name "commons-math*" ./hadoop-1.0.3/lib/commons-math-2.1.jar On 1.2.1: hadoop@hbasetest1:~$ find . -name "commons-math*" ./hadoop-1.2.1/lib/commons-math-2.1.jar On 2.2.0: hadoop@hbasetest1:~$ find . -name "commons-math*" ./share/hadoop/common/lib/commons-math-2.1.jar So I agree that we should "stick" with the 2.1 signature. Dependency on 2.2.0: jmspaggiari@t430s:~/test/hadoop-2.2.0$ mvn -f pom.xml dependency:tree | grep math [INFO] +- org.apache.commons:commons-math:jar:2.1:compile
          Hide
          Andrew Purtell added a comment -

          +1, the patch looks good. Anyway the change happens after teardown so is likely to at worst add a bit of (imperceptible) delay to end of run reporting.

          Show
          Andrew Purtell added a comment - +1, the patch looks good. Anyway the change happens after teardown so is likely to at worst add a bit of (imperceptible) delay to end of run reporting.
          Hide
          Nicolas Liochon added a comment -

          We can commit the change, but there is something I don't get, at least for trunk (I haven't checked 0.98 & 0.96): hbase pom seems clean, and does require common:math:2.2, whatever the hadoop version. How comes we're finally installed with the 2.1 version?

          I mean, we don't care for this specific case, but if HBase requires the 2.2 version, it should not be deployed with an older one. Here the error message is clear and it's in the test code, but it could be less clear and in the production code...

          Show
          Nicolas Liochon added a comment - We can commit the change, but there is something I don't get, at least for trunk (I haven't checked 0.98 & 0.96): hbase pom seems clean, and does require common:math:2.2, whatever the hadoop version. How comes we're finally installed with the 2.1 version? I mean, we don't care for this specific case, but if HBase requires the 2.2 version, it should not be deployed with an older one. Here the error message is clear and it's in the test code, but it could be less clear and in the production code...
          Hide
          Jean-Marc Spaggiari added a comment -

          jmspaggiari@t430s:~/test/hbase-0.94$ mvn -f pom.xml dependency:tree | grep math
          [INFO] +- org.apache.commons:commons-math:jar:2.1:test (scope not updated to compile)

          jmspaggiari@t430s:~/test/hbase-0.96$ mvn -f pom.xml dependency:tree | grep math
          [INFO] | +- org.apache.commons:commons-math:jar:2.2:compile (version managed from 2.1)

          jmspaggiari@t430s:~/test/hbase-0.98$ mvn -f pom.xml dependency:tree | grep math
          [INFO] | +- org.apache.commons:commons-math:jar:2.2:compile (version managed from 2.1)

          jmspaggiari@t430s:~/test/hbase-trunk$ mvn -f pom.xml dependency:tree | grep math
          [INFO] | +- org.apache.commons:commons-math:jar:2.2:compile (version managed from 2.1)
          [INFO] | +- org.apache.commons:commons-math:jar:2.2:compile (version managed from 2.1)
          [INFO] | +- org.apache.commons:commons-math:jar:2.2:compile (version managed from 2.1)
          [INFO] | +- org.apache.commons:commons-math:jar:2.2:compile (version managed from 2.1)
          [INFO] +- org.apache.commons:commons-math:jar:2.2:compile
          [INFO] | +- org.apache.commons:commons-math:jar:2.2:compile (version managed from 2.1)
          [INFO] +- org.apache.commons:commons-math:jar:2.2:compile
          [INFO] | +- org.apache.commons:commons-math:jar:2.2:compile (version managed from 2.1)
          [INFO] +- org.apache.commons:commons-math:jar:2.2:compile
          [INFO] | +- org.apache.commons:commons-math:jar:2.2:compile
          [INFO] | | +- org.apache.commons:commons-math:jar:2.2:compile (version managed from 2.1)

          So. For 0.94 it's just normal to have 2.1. On the others, we should have 2.2 but the comment is "version managed from 2.1", no sure what it means...

          Show
          Jean-Marc Spaggiari added a comment - jmspaggiari@t430s:~/test/hbase-0.94$ mvn -f pom.xml dependency:tree | grep math [INFO] +- org.apache.commons:commons-math:jar:2.1:test (scope not updated to compile) jmspaggiari@t430s:~/test/hbase-0.96$ mvn -f pom.xml dependency:tree | grep math [INFO] | +- org.apache.commons:commons-math:jar:2.2:compile (version managed from 2.1) jmspaggiari@t430s:~/test/hbase-0.98$ mvn -f pom.xml dependency:tree | grep math [INFO] | +- org.apache.commons:commons-math:jar:2.2:compile (version managed from 2.1) jmspaggiari@t430s:~/test/hbase-trunk$ mvn -f pom.xml dependency:tree | grep math [INFO] | +- org.apache.commons:commons-math:jar:2.2:compile (version managed from 2.1) [INFO] | +- org.apache.commons:commons-math:jar:2.2:compile (version managed from 2.1) [INFO] | +- org.apache.commons:commons-math:jar:2.2:compile (version managed from 2.1) [INFO] | +- org.apache.commons:commons-math:jar:2.2:compile (version managed from 2.1) [INFO] +- org.apache.commons:commons-math:jar:2.2:compile [INFO] | +- org.apache.commons:commons-math:jar:2.2:compile (version managed from 2.1) [INFO] +- org.apache.commons:commons-math:jar:2.2:compile [INFO] | +- org.apache.commons:commons-math:jar:2.2:compile (version managed from 2.1) [INFO] +- org.apache.commons:commons-math:jar:2.2:compile [INFO] | +- org.apache.commons:commons-math:jar:2.2:compile [INFO] | | +- org.apache.commons:commons-math:jar:2.2:compile (version managed from 2.1) So. For 0.94 it's just normal to have 2.1. On the others, we should have 2.2 but the comment is "version managed from 2.1", no sure what it means...
          Hide
          Nicolas Liochon added a comment -

          no sure what it means

          maven sees that hadoop asks for 2.1 while hbase asks for 2.2, so it builds with 2.2 (the newest version). That's maven doing its job. So we should have the 2.2 when we deploy. If we don't have this, it means that we don't use the expected versions of our third parties when they are different than the hadoop ones.

          Show
          Nicolas Liochon added a comment - no sure what it means maven sees that hadoop asks for 2.1 while hbase asks for 2.2, so it builds with 2.2 (the newest version). That's maven doing its job. So we should have the 2.2 when we deploy. If we don't have this, it means that we don't use the expected versions of our third parties when they are different than the hadoop ones.
          Hide
          Nick Dimiduk added a comment -

          Here's an updated patch. it drops our dependency version to 2.1.

          Ideally we'd be able to catch this kind of thing at compile time. To that end, I experimented a little with the enforcer plugin. More experimentation necessary, so I'll open a new ticket for that if I make any progress.

          Show
          Nick Dimiduk added a comment - Here's an updated patch. it drops our dependency version to 2.1. Ideally we'd be able to catch this kind of thing at compile time. To that end, I experimented a little with the enforcer plugin. More experimentation necessary, so I'll open a new ticket for that if I make any progress.
          Nick Dimiduk made changes -
          Attachment HBASE-10548.01.patch [ 12629610 ]
          Hide
          Nick Dimiduk added a comment -

          I should add, here's the output with this patch applied, no more version management reported:

          $ mvn dependency:tree | grep commons-math
          [INFO] |  +- org.apache.commons:commons-math:jar:2.1:compile
          [INFO] |  +- org.apache.commons:commons-math:jar:2.1:compile
          [INFO] |  +- org.apache.commons:commons-math:jar:2.1:compile
          [INFO] |  +- org.apache.commons:commons-math:jar:2.1:compile
          [INFO] +- org.apache.commons:commons-math:jar:2.1:compile
          [INFO] |  +- org.apache.commons:commons-math:jar:2.1:compile
          [INFO] +- org.apache.commons:commons-math:jar:2.1:compile
          [INFO] |  +- org.apache.commons:commons-math:jar:2.1:compile
          [INFO] +- org.apache.commons:commons-math:jar:2.1:compile
          [INFO] |  +- org.apache.commons:commons-math:jar:2.1:compile
          [INFO] |  +- org.apache.commons:commons-math:jar:2.1:compile
          
          Show
          Nick Dimiduk added a comment - I should add, here's the output with this patch applied, no more version management reported: $ mvn dependency:tree | grep commons-math [INFO] | +- org.apache.commons:commons-math:jar:2.1:compile [INFO] | +- org.apache.commons:commons-math:jar:2.1:compile [INFO] | +- org.apache.commons:commons-math:jar:2.1:compile [INFO] | +- org.apache.commons:commons-math:jar:2.1:compile [INFO] +- org.apache.commons:commons-math:jar:2.1:compile [INFO] | +- org.apache.commons:commons-math:jar:2.1:compile [INFO] +- org.apache.commons:commons-math:jar:2.1:compile [INFO] | +- org.apache.commons:commons-math:jar:2.1:compile [INFO] +- org.apache.commons:commons-math:jar:2.1:compile [INFO] | +- org.apache.commons:commons-math:jar:2.1:compile [INFO] | +- org.apache.commons:commons-math:jar:2.1:compile
          Nick Dimiduk made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Nick Dimiduk made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12629610/HBASE-10548.01.patch
          against trunk revision .
          ATTACHMENT ID: 12629610

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8736//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8736//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8736//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8736//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8736//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8736//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8736//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8736//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8736//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8736//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8736//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12629610/HBASE-10548.01.patch against trunk revision . ATTACHMENT ID: 12629610 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8736//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8736//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8736//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8736//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8736//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8736//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8736//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8736//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8736//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8736//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8736//console This message is automatically generated.
          Hide
          Nick Dimiduk added a comment -

          Build passes. This is the patch I'd like to apply to trunk.

          stack Andrew Purtell what's your preference re: the pom change for your respective release lines? I think it would be "unusual" to downgrade a dependency on a patch release, however from everything I can tell, the production mapreduce runtimes are using 2.1. Anyone using commons-math in their MR jobs will have encoutered this incompatibility on their own. I'm thinking of folks running the client outside of a MR runtime.

          Show
          Nick Dimiduk added a comment - Build passes. This is the patch I'd like to apply to trunk. stack Andrew Purtell what's your preference re: the pom change for your respective release lines? I think it would be "unusual" to downgrade a dependency on a patch release, however from everything I can tell, the production mapreduce runtimes are using 2.1. Anyone using commons-math in their MR jobs will have encoutered this incompatibility on their own. I'm thinking of folks running the client outside of a MR runtime.
          Hide
          Andrew Purtell added a comment - - edited

          I think the change is needed to rectify the issue for both Hadoop 1 and Hadoop 2 (at least 2.2.x is also affected). There is no reason for us to diverge from Hadoop on the version of this dependency.

          Show
          Andrew Purtell added a comment - - edited I think the change is needed to rectify the issue for both Hadoop 1 and Hadoop 2 (at least 2.2.x is also affected). There is no reason for us to diverge from Hadoop on the version of this dependency.
          Hide
          stack added a comment -

          I'm good for 0.96

          Show
          stack added a comment - I'm good for 0.96
          Nick Dimiduk made changes -
          Summary PerfEval work around wrong runtime dependency version Correct commons-math dependency version
          Hide
          Nick Dimiduk added a comment -

          Committed to all 3 branches. Thanks for the reviews folks!

          Show
          Nick Dimiduk added a comment - Committed to all 3 branches. Thanks for the reviews folks!
          Nick Dimiduk made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Release Note Downgrades HBase's dependency on commons-math to 2.1, which is consistent with all stable releases of Hadoop.
          Fix Version/s 0.96.2 [ 12325658 ]
          Fix Version/s 0.98.1 [ 12325664 ]
          Fix Version/s 0.99.0 [ 12325675 ]
          Resolution Fixed [ 1 ]
          Hide
          Nick Dimiduk added a comment -

          Attaching patches for what was committed to 0.96 and 0.98 since the trunk patch did not apply to the pom cleanly.

          Show
          Nick Dimiduk added a comment - Attaching patches for what was committed to 0.96 and 0.98 since the trunk patch did not apply to the pom cleanly.
          Nick Dimiduk made changes -
          Attachment HBASE-10548.01-0.96.patch [ 12629685 ]
          Attachment HBASE-10548.01-0.98.patch [ 12629686 ]
          Hide
          Hudson added a comment -

          FAILURE: Integrated in hbase-0.96-hadoop2 #208 (See https://builds.apache.org/job/hbase-0.96-hadoop2/208/)
          HBASE-10548 Correct commons-math dependency version (ndimiduk: rev 1569569)

          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
          • /hbase/branches/0.96/pom.xml
          Show
          Hudson added a comment - FAILURE: Integrated in hbase-0.96-hadoop2 #208 (See https://builds.apache.org/job/hbase-0.96-hadoop2/208/ ) HBASE-10548 Correct commons-math dependency version (ndimiduk: rev 1569569) /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java /hbase/branches/0.96/pom.xml
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #94 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/94/)
          HBASE-10548 Correct commons-math dependency version (ndimiduk: rev 1569565)

          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
          • /hbase/trunk/pom.xml
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #94 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/94/ ) HBASE-10548 Correct commons-math dependency version (ndimiduk: rev 1569565) /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java /hbase/trunk/pom.xml
          Nick Dimiduk made changes -
          Link This issue is depended upon by HBASE-10791 [ HBASE-10791 ]
          Nicolas Liochon made changes -
          Fix Version/s hbase-10070 [ 12326176 ]
          Hide
          Nicolas Liochon added a comment -

          Committed to the 10070 branch as well.

          Show
          Nicolas Liochon added a comment - Committed to the 10070 branch as well.
          Hide
          Enis Soztutar added a comment -

          Closing this issue after 0.99.0 release.

          Show
          Enis Soztutar added a comment - Closing this issue after 0.99.0 release.
          Enis Soztutar made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Nick Dimiduk
              Reporter:
              Nick Dimiduk
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development