[HBASE-10542] ConcurrentModificationException in TestHTraceHooks

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Cannot Reproduce
• Assignee: Unassigned
• Reporter: Enis Soztutar
• Created: 14/Feb/14 20:16
• Updated: 17/Jun/22 05:06
• Resolved: 09/Sep/14 05:19

Description

I got this in one of my test runs:

<error type="java.util.ConcurrentModificationException">java.util.ConcurrentModificationException
        at java.util.HashMap$HashIterator.nextEntry(HashMap.java:894)
        at java.util.HashMap$KeyIterator.next(HashMap.java:928)
        at org.cloudera.htrace.TraceTree.&lt;init&gt;(TraceTree.java:48)
        at org.apache.hadoop.hbase.trace.TestHTraceHooks.testTraceCreateTable(TestHTraceHooks.java:118)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:601)
        at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
        at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
        at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)

It looks like TraceTree ctor, clones the spans collection, but iterates over the original argument, rather than cloned.

I don't know enough of HTrace to fix it, so just reporting it here. eclark FYI.