HBase
  1. HBase
  2. HBASE-10456

Balancer should not run if it's just turned off.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.0, 0.99.0
    • Component/s: Balancer, hbck
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      TestHBaseFsck failed recently because the balancer ran one more time even after it's turned off. Balancer should double-check if it is on before each run.

        Activity

        Hide
        Jimmy Xiang added a comment -

        Here is the log:

        2014-02-02 22:42:01,850 INFO  [RpcServer.handler=0,port=39732] master.HMaster(1547): Client=jenkins//172.29.121.237 set balanceSwitch=false
        2014-02-02 22:42:01,857 INFO  [Thread-3540] zookeeper.RecoverableZooKeeper(120): Process identifier=hbase Fsck connecting to ZooKeeper ensemble=localhost:55828
        2014-02-02 22:42:01,900 DEBUG [Thread-3540-EventThread] zookeeper.ZooKeeperWatcher(310): hbase Fsck, quorum=localhost:55828, baseZNode=/hbase Received ZooKeeper Event, type=None, state=SyncConnected, path=null
        2014-02-02 22:42:01,903 DEBUG [Thread-3540-EventThread] zookeeper.ZooKeeperWatcher(387): hbase Fsck-0x143f676c5ca0267 connected
        2014-02-02 22:42:01,916 INFO  [Thread-3540] util.HBaseFsck(431): Loading regionsinfo from the hbase:meta table
        2014-02-02 22:42:01,925 INFO  [Thread-3540] util.HBaseFsck(2521): getHTableDescriptors == tableNames => [hbase:namespace, tableBadMetaAssign]
        2014-02-02 22:42:01,937 DEBUG [Thread-3540] util.HBaseFsck(1334): Loading region dirs from hdfs://localhost.localdomain:53175/user/jenkins/hbase/data/default/tableBadMetaAssign
        2014-02-02 22:42:01,938 DEBUG [Thread-3540] util.HBaseFsck(1334): Loading region dirs from hdfs://localhost.localdomain:53175/user/jenkins/hbase/data/default/testMissingFirstRegion
        2014-02-02 22:42:01,938 DEBUG [Thread-3540] util.HBaseFsck(1334): Loading region dirs from hdfs://localhost.localdomain:53175/user/jenkins/hbase/data/hbase/meta
        2014-02-02 22:42:01,938 DEBUG [Thread-3540] util.HBaseFsck(1334): Loading region dirs from hdfs://localhost.localdomain:53175/user/jenkins/hbase/data/hbase/namespace
        2014-02-02 22:42:02,125 INFO  [Thread-3540] zookeeper.RecoverableZooKeeper(120): Process identifier=hbase Fsck connecting to ZooKeeper ensemble=localhost:55828
        2014-02-02 22:42:02,241 DEBUG [pool-1-thread-1-EventThread] zookeeper.ZooKeeperWatcher(310): master:39732-0x143f676c5ca0000, quorum=localhost:55828, baseZNode=/hbase Received ZooKeeper Event, type=NodeChildrenChanged, state=SyncConnected, path=/hbase/region-in-transition
        2014-02-02 22:42:02,407 DEBUG [Thread-3540-EventThread] zookeeper.ZooKeeperWatcher(310): hbase Fsck, quorum=localhost:55828, baseZNode=/hbase Received ZooKeeper Event, type=None, state=SyncConnected, path=null
        2014-02-02 22:42:02,408 INFO  [p0117.mtv.cloudera.com,39732,1391409416331-BalancerChore] master.RegionStates(316): Transitioned {4a1ce2972ae1f80d207500d1c60ddf51 state=OPEN, ts=1391409422614, server=p0117.mtv.cloudera.com,60376,1391409417115} to {4a1ce2972ae1f80d207500d1c60ddf51 state=PENDING_CLOSE, ts=1391409722408, server=p0117.mtv.cloudera.com,60376,1391409417115}
        2014-02-02 22:42:02,408 INFO  [Priority.RpcServer.handler=1,port=60376] regionserver.HRegionServer(3633): Close 4a1ce2972ae1f80d207500d1c60ddf51, via zk=yes, znode version=0, on p0117.mtv.cloudera.com,35218,1391409416993
        
        Show
        Jimmy Xiang added a comment - Here is the log: 2014-02-02 22:42:01,850 INFO [RpcServer.handler=0,port=39732] master.HMaster(1547): Client=jenkins//172.29.121.237 set balanceSwitch=false 2014-02-02 22:42:01,857 INFO [Thread-3540] zookeeper.RecoverableZooKeeper(120): Process identifier=hbase Fsck connecting to ZooKeeper ensemble=localhost:55828 2014-02-02 22:42:01,900 DEBUG [Thread-3540-EventThread] zookeeper.ZooKeeperWatcher(310): hbase Fsck, quorum=localhost:55828, baseZNode=/hbase Received ZooKeeper Event, type=None, state=SyncConnected, path=null 2014-02-02 22:42:01,903 DEBUG [Thread-3540-EventThread] zookeeper.ZooKeeperWatcher(387): hbase Fsck-0x143f676c5ca0267 connected 2014-02-02 22:42:01,916 INFO [Thread-3540] util.HBaseFsck(431): Loading regionsinfo from the hbase:meta table 2014-02-02 22:42:01,925 INFO [Thread-3540] util.HBaseFsck(2521): getHTableDescriptors == tableNames => [hbase:namespace, tableBadMetaAssign] 2014-02-02 22:42:01,937 DEBUG [Thread-3540] util.HBaseFsck(1334): Loading region dirs from hdfs://localhost.localdomain:53175/user/jenkins/hbase/data/default/tableBadMetaAssign 2014-02-02 22:42:01,938 DEBUG [Thread-3540] util.HBaseFsck(1334): Loading region dirs from hdfs://localhost.localdomain:53175/user/jenkins/hbase/data/default/testMissingFirstRegion 2014-02-02 22:42:01,938 DEBUG [Thread-3540] util.HBaseFsck(1334): Loading region dirs from hdfs://localhost.localdomain:53175/user/jenkins/hbase/data/hbase/meta 2014-02-02 22:42:01,938 DEBUG [Thread-3540] util.HBaseFsck(1334): Loading region dirs from hdfs://localhost.localdomain:53175/user/jenkins/hbase/data/hbase/namespace 2014-02-02 22:42:02,125 INFO [Thread-3540] zookeeper.RecoverableZooKeeper(120): Process identifier=hbase Fsck connecting to ZooKeeper ensemble=localhost:55828 2014-02-02 22:42:02,241 DEBUG [pool-1-thread-1-EventThread] zookeeper.ZooKeeperWatcher(310): master:39732-0x143f676c5ca0000, quorum=localhost:55828, baseZNode=/hbase Received ZooKeeper Event, type=NodeChildrenChanged, state=SyncConnected, path=/hbase/region-in-transition 2014-02-02 22:42:02,407 DEBUG [Thread-3540-EventThread] zookeeper.ZooKeeperWatcher(310): hbase Fsck, quorum=localhost:55828, baseZNode=/hbase Received ZooKeeper Event, type=None, state=SyncConnected, path=null 2014-02-02 22:42:02,408 INFO [p0117.mtv.cloudera.com,39732,1391409416331-BalancerChore] master.RegionStates(316): Transitioned {4a1ce2972ae1f80d207500d1c60ddf51 state=OPEN, ts=1391409422614, server=p0117.mtv.cloudera.com,60376,1391409417115} to {4a1ce2972ae1f80d207500d1c60ddf51 state=PENDING_CLOSE, ts=1391409722408, server=p0117.mtv.cloudera.com,60376,1391409417115} 2014-02-02 22:42:02,408 INFO [Priority.RpcServer.handler=1,port=60376] regionserver.HRegionServer(3633): Close 4a1ce2972ae1f80d207500d1c60ddf51, via zk=yes, znode version=0, on p0117.mtv.cloudera.com,35218,1391409416993
        Hide
        Enis Soztutar added a comment -

        +1.

        Show
        Enis Soztutar added a comment - +1.
        Hide
        Andrew Purtell added a comment -

        +1 for trunk and 0.98

        Show
        Andrew Purtell added a comment - +1 for trunk and 0.98
        Hide
        Jonathan Hsieh added a comment -

        +1

        Show
        Jonathan Hsieh added a comment - +1
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12626707/hbase-10456.patch
        against trunk revision .
        ATTACHMENT ID: 12626707

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8577//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8577//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12626707/hbase-10456.patch against trunk revision . ATTACHMENT ID: 12626707 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8577//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8577//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8577//console This message is automatically generated.
        Hide
        Jimmy Xiang added a comment -

        Integrated into trunk and 0.98. Thanks.

        Show
        Jimmy Xiang added a comment - Integrated into trunk and 0.98. Thanks.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #76 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/76/)
        HBASE-10456 Balancer should not run if it's just turned off (jxiang: rev 1564047)

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #76 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/76/ ) HBASE-10456 Balancer should not run if it's just turned off (jxiang: rev 1564047) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #4876 (See https://builds.apache.org/job/HBase-TRUNK/4876/)
        HBASE-10456 Balancer should not run if it's just turned off (jxiang: rev 1564047)

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #4876 (See https://builds.apache.org/job/HBase-TRUNK/4876/ ) HBASE-10456 Balancer should not run if it's just turned off (jxiang: rev 1564047) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.98 #123 (See https://builds.apache.org/job/HBase-0.98/123/)
        HBASE-10456 Balancer should not run if it's just turned off (jxiang: rev 1564048)

        • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.98 #123 (See https://builds.apache.org/job/HBase-0.98/123/ ) HBASE-10456 Balancer should not run if it's just turned off (jxiang: rev 1564048) /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #114 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/114/)
        HBASE-10456 Balancer should not run if it's just turned off (jxiang: rev 1564048)

        • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #114 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/114/ ) HBASE-10456 Balancer should not run if it's just turned off (jxiang: rev 1564048) /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java

          People

          • Assignee:
            Jimmy Xiang
            Reporter:
            Jimmy Xiang
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development