[HBASE-10422] ZeroCopyLiteralByteString.zeroCopyGetBytes has an unusable prototype and conflicts with AsyncHBase

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.98.0, 0.96.1, 0.96.1.1
• Fix Version/s: 0.98.0, 0.96.2, 0.99.0
• Component/s: Client, Protobufs
• Hadoop Flags: Incompatible change, Reviewed
• Assignee: Benoit Sigoure
• Reporter: Benoit Sigoure
• Created: 27/Jan/14 02:33
• Updated: 21/Feb/15 23:34
• Resolved: 27/Jan/14 16:28

Description

In HBASE-9868 the trick that AsyncHBase uses to extract byte arrays from protobufs without copying them was ported, however the signature of zeroCopyGetBytes was changed for some reason. There are two problems with the changed signature:

1. It makes the helper function unusable since it refers to a package-private class.
2. It clashes with the signature AsyncHBase expects, thereby making user's life miserable for those who pull in both AsyncHBase and HBase on their classpath.