Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-10422

ZeroCopyLiteralByteString.zeroCopyGetBytes has an unusable prototype and conflicts with AsyncHBase

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.98.0, 0.96.1, 0.96.1.1
    • 0.98.0, 0.96.2, 0.99.0
    • Client, Protobufs
    • None
    • Incompatible change, Reviewed

    Description

      In HBASE-9868 the trick that AsyncHBase uses to extract byte arrays from protobufs without copying them was ported, however the signature of zeroCopyGetBytes was changed for some reason. There are two problems with the changed signature:

      1. It makes the helper function unusable since it refers to a package-private class.
      2. It clashes with the signature AsyncHBase expects, thereby making user's life miserable for those who pull in both AsyncHBase and HBase on their classpath.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            tsuna Benoit Sigoure
            tsuna Benoit Sigoure
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment