HBase
  1. HBase
  2. HBASE-10399

Add documentation for VerifyReplication to refguide

    Details

    • Type: Improvement Improvement
    • Status: Patch Available
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      HBase refguide currently doesn't document how VerifyReplication is used for comparing local table with remote table.

      Document for VerifyReplication should be added so that users know how to use it.

      1. HBASE-10399.patch
        6 kB
        Gustavo Anatoly

        Activity

        Hide
        stack added a comment -

        Ted Yu You going to do it? Else suggest closing this issue. If we had an issue for all that was undocumented we'd be at 100k issues.

        Show
        stack added a comment - Ted Yu You going to do it? Else suggest closing this issue. If we had an issue for all that was undocumented we'd be at 100k issues.
        Hide
        Gustavo Anatoly added a comment -

        I can do this task. This issue will remain open?

        Show
        Gustavo Anatoly added a comment - I can do this task. This issue will remain open?
        Hide
        stack added a comment -

        Gustavo Anatoly That is gracious of you.

        Wouldn't mind an answer to my question Ted Yu

        Show
        stack added a comment - Gustavo Anatoly That is gracious of you. Wouldn't mind an answer to my question Ted Yu
        Hide
        Ted Yu added a comment -

        You going to do it?

        I can do this if Gustavo don't have time.

        Show
        Ted Yu added a comment - You going to do it? I can do this if Gustavo don't have time.
        Hide
        Gustavo Anatoly added a comment -

        Ted,

        I found some documentation about VerifyReplication on:
        http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/replication/package-summary.html

        We could complement these descriptions and add to refguide. What do you think about it?

        Show
        Gustavo Anatoly added a comment - Ted, I found some documentation about VerifyReplication on: http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/replication/package-summary.html We could complement these descriptions and add to refguide. What do you think about it?
        Hide
        Ted Yu added a comment -

        Sounds good.

        Show
        Ted Yu added a comment - Sounds good.
        Hide
        Gustavo Anatoly added a comment -

        I will work on this.

        Show
        Gustavo Anatoly added a comment - I will work on this.
        Hide
        Ted Yu added a comment -

        Jean-Daniel Cryans:
        What do you think of Gustavo's patch ?

        Thanks

        Show
        Ted Yu added a comment - Jean-Daniel Cryans : What do you think of Gustavo's patch ? Thanks
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12629021/HBASE-10399.patch
        against trunk revision .
        ATTACHMENT ID: 12629021

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8703//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8703//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12629021/HBASE-10399.patch against trunk revision . ATTACHMENT ID: 12629021 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8703//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8703//console This message is automatically generated.
        Hide
        Jean-Daniel Cryans added a comment -
        +      This package is experimental quality software and is only meant to be a base
        +      for future developments. The current implementation offers the following
        +      features:
        

        We can stop saying that now, it's even enabled by default since 0.96.

        +          <property>
        +           <name>hbase.replication</name>
        +           <value>true</value>
        +          </property>
        

        Not necessary anymore.

        +      Considering 1 rs, with ratio 0.1
        +      Getting 1 rs from peer cluster # 0
        +      Choosing peer 10.10.1.49:62020
        

        Those log lines don't even exist anymore.

        +        $HBASE_HOME/bin/hbase org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication --help
        

        Looking at the current code, it expects -h or --h. Not sure if --help was ever true or when it was changed.

        So that documentation needs a complete revamp. I'm fine if we want to just document VerifyReplication in the ref guide but the right thing to do would be to rewrite it.

        Show
        Jean-Daniel Cryans added a comment - + This package is experimental quality software and is only meant to be a base + for future developments. The current implementation offers the following + features: We can stop saying that now, it's even enabled by default since 0.96. + <property> + <name>hbase.replication</name> + <value>true</value> + </property> Not necessary anymore. + Considering 1 rs, with ratio 0.1 + Getting 1 rs from peer cluster # 0 + Choosing peer 10.10.1.49:62020 Those log lines don't even exist anymore. + $HBASE_HOME/bin/hbase org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication --help Looking at the current code, it expects -h or --h. Not sure if --help was ever true or when it was changed. So that documentation needs a complete revamp. I'm fine if we want to just document VerifyReplication in the ref guide but the right thing to do would be to rewrite it.
        Hide
        Gustavo Anatoly added a comment -

        Hi, Jean-Daniel Cryans

        Thank you for review. An alternative we could do is fix the points listed above and publish it, while this, the documentation is being rewritten. Thus the users would have something to guide about verify replication.

        Ted Yu and Jean-Daniel Cryans what do you think about this alternative?

        Show
        Gustavo Anatoly added a comment - Hi, Jean-Daniel Cryans Thank you for review. An alternative we could do is fix the points listed above and publish it, while this, the documentation is being rewritten. Thus the users would have something to guide about verify replication. Ted Yu and Jean-Daniel Cryans what do you think about this alternative?
        Hide
        Jean-Daniel Cryans added a comment -

        It's fine if you want to do that, but it's going to be close to a revamp

        Show
        Jean-Daniel Cryans added a comment - It's fine if you want to do that, but it's going to be close to a revamp

          People

          • Assignee:
            Gustavo Anatoly
            Reporter:
            Ted Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:

              Development