Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-10395

endTime won't be set in VerifyReplication if startTime is not set

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.94.16
    • Fix Version/s: 0.98.0, 0.99.0
    • Component/s: mapreduce, Replication
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In VerifyReplication, we may set startTime and endTime to restrict the data to verfiy. However, the endTime won't be set in the program if we only pass endTime without startTime in command line argument. The reason is the following code:

              if (startTime != 0) {
                scan.setTimeRange(startTime,
                    endTime == 0 ? HConstants.LATEST_TIMESTAMP : endTime);
              }
      

      The code will ignore endTime setting when not passing startTime in command line argument. Another place needs to improvement is the help message as follows:

          System.err.println(" stoprow      end of the row");
      

      However, the program actually use "endrow" to parse the arguments:

              final String endTimeArgKey = "--endtime=";
              if (cmd.startsWith(endTimeArgKey)) {
                endTime = Long.parseLong(cmd.substring(endTimeArgKey.length()));
                continue;
              }
      

        Attachments

        1. HBASE-10395-0.94-v1.patch
          2 kB
          Jianwei Cui
        2. HBASE-10395-0.94-v2.patch
          2 kB
          Jianwei Cui
        3. HBASE-10395-0.94-v3.patch
          3 kB
          Jianwei Cui
        4. HBASE-10395-trunk-v1.patch
          2 kB
          Jianwei Cui
        5. HBASE-10395-trunk-v2.patch
          2 kB
          Jianwei Cui
        6. HBASE-10395-trunk-v3.patch
          3 kB
          Jianwei Cui

          Activity

            People

            • Assignee:
              cuijianwei Jianwei Cui
              Reporter:
              cuijianwei Jianwei Cui
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: