[HBASE-10322] Strip tags from KV while sending back to client on reads

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 0.98.0
• Fix Version/s: 0.98.0, 0.99.0
• Hadoop Flags: Reviewed

Release Note

Added a new config hbase.replication.rpc.codec, using which one can specify the codec to be used by the replication. This config don't have a default value. When it is not specified, the codec specified by hbase.client.rpc.codec config will be used for replication.(For which org.apache.hadoop.hbase.codec.KeyValueCodec is the default value)

Note : When using tags directly or indirectly (ie. Usage of cell level visibility labels or per cell ACL) make sure to configure hbase.replication.rpc.codec with a Codec which supports shipping of tags. We have org.apache.hadoop.hbase.codec.KeyValueCodecWithTags and org.apache.hadoop.hbase.codec.CellCodecWithTags, which can handle tags.

• Assignee: Anoop Sam John
• Reporter: Anoop Sam John
• Created: 12/Jan/14 06:59
• Updated: 06/Apr/18 17:51
• Resolved: 22/Jan/14 07:32

Description

Right now we have some inconsistency wrt sending back tags on read. We do this in scan when using Java client(Codec based cell block encoding). But during a Get operation or when a pure PB based Scan comes we are not sending back the tags. So any of the below fix we have to do
1. Send back tags in missing cases also. But sending back visibility expression/ cell ACL is not correct.
2. Don't send back tags in any case. This will a problem when a tool like ExportTool use the scan to export the table data. We will miss exporting the cell visibility/ACL.
3. Send back tags based on some condition. It has to be per scan basis. Simplest way is pass some kind of attribute in Scan which says whether to send back tags or not. But believing some thing what scan specifies might not be correct IMO. Then comes the way of checking the user who is doing the scan. When a HBase super user doing the scan then only send back tags. So when a case comes like Export Tool's the execution should happen from a super user.

So IMO we should go with #3.
Patch coming soon.

Issue Links

• incorporates: HBASE-10398 HBase book updates for Replication after HBASE-10322
• relates to: HBASE-10326 Super user should be able scan all the cells irrespective of the visibility labels
• relates to: HBASE-12470 Way to determine which labels are applied to a cell in a table
• relates to: HBASE-12441 Export and CopyTable need to be able to keep tags/labels in cells