HBase
  1. HBase
  2. HBASE-10282

We can't assure that the first ZK server is active server in MiniZooKeeperCluster

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 0.94.3
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Thanks to HBASE-3052, we're able to run multiple zk servers in minicluster. However, It's confusing to keep the variable activeZKServerIndex as zero and assure the first zk server is always the active one. I think returning the first sever's client port is for testing and it seems that we can directly return the first item of the list. Anyway, the concept of "active" here is not the same as zk's.

      It's confusing when I read the code so I think we should fix it.

        Activity

        Hide
        chendihao added a comment -

        patch for 0.94

        Show
        chendihao added a comment - patch for 0.94
        Hide
        stack added a comment -

        Do as you see fit chendihao. Thanks for working on this.

        Show
        stack added a comment - Do as you see fit chendihao . Thanks for working on this.
        Hide
        chendihao added a comment -

        Thank stack and we(Xiaomi) will make a patch to eliminate the confusion. Can we reduce those two function into a killRandomZooKeeperServer() because they seem to have the same effect? Before doing that, we have to fix HBASE-10283 otherwise killing the first one will occur other problems.

        Show
        chendihao added a comment - Thank stack and we(Xiaomi) will make a patch to eliminate the confusion. Can we reduce those two function into a killRandomZooKeeperServer() because they seem to have the same effect? Before doing that, we have to fix HBASE-10283 otherwise killing the first one will occur other problems.
        Hide
        stack added a comment -

        What you say makes sense chendihao

        Show
        stack added a comment - What you say makes sense chendihao
        Hide
        chendihao added a comment -

        The function killCurrentActiveZooKeeperServer() and killOneBackupZooKeeperServer() are nonsense because of this. I think Liyin Tang treated the first zk server as the leader but we can't make sure of that. So should we rename activeZKServerIndex into firstZKServerIndex and combining these two functions into killFirstZooKeeperServer()(hard to know which one is actual leader)?

        Need more people to discuss it. Enis Soztutar stack

        Show
        chendihao added a comment - The function killCurrentActiveZooKeeperServer() and killOneBackupZooKeeperServer() are nonsense because of this. I think Liyin Tang treated the first zk server as the leader but we can't make sure of that. So should we rename activeZKServerIndex into firstZKServerIndex and combining these two functions into killFirstZooKeeperServer() (hard to know which one is actual leader)? Need more people to discuss it. Enis Soztutar stack
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.94 #1257 (See https://builds.apache.org/job/HBase-0.94/1257/)
        HBASE-10282 TestMultiParallel.testFlushCommitsNoAbort fails frequently in 0.94 (larsh: rev 1557003)

        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.94 #1257 (See https://builds.apache.org/job/HBase-0.94/1257/ ) HBASE-10282 TestMultiParallel.testFlushCommitsNoAbort fails frequently in 0.94 (larsh: rev 1557003) /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.94-JDK7 #24 (See https://builds.apache.org/job/HBase-0.94-JDK7/24/)
        HBASE-10282 TestMultiParallel.testFlushCommitsNoAbort fails frequently in 0.94 (larsh: rev 1557003)

        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.94-JDK7 #24 (See https://builds.apache.org/job/HBase-0.94-JDK7/24/ ) HBASE-10282 TestMultiParallel.testFlushCommitsNoAbort fails frequently in 0.94 (larsh: rev 1557003) /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.94-security #385 (See https://builds.apache.org/job/HBase-0.94-security/385/)
        HBASE-10282 TestMultiParallel.testFlushCommitsNoAbort fails frequently in 0.94 (larsh: rev 1557003)

        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.94-security #385 (See https://builds.apache.org/job/HBase-0.94-security/385/ ) HBASE-10282 TestMultiParallel.testFlushCommitsNoAbort fails frequently in 0.94 (larsh: rev 1557003) /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
        Hide
        chendihao added a comment -

        Looking for your replay. stack Liyin Tang Jonathan Gray

        Show
        chendihao added a comment - Looking for your replay. stack Liyin Tang Jonathan Gray

          People

          • Assignee:
            chendihao
            Reporter:
            chendihao
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:

              Development