Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.99.0
    • Fix Version/s: 0.99.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Per HADOOP-10147 and HDFS-5678, through we didn't observe any deadlock due to common-logging in HBase, to me, it's still worth to bump the version.

        Activity

        Liang Xie created issue -
        Liang Xie made changes -
        Field Original Value New Value
        Attachment HBASE-10265.txt [ 12621075 ]
        Liang Xie made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        stack added a comment -

        +1

        Show
        stack added a comment - +1
        Hide
        stack added a comment -

        Here is list of changes since 1.1.1: http://commons.apache.org/proper/commons-logging/changes-report.html Looks like good stuff only.

        Show
        stack added a comment - Here is list of changes since 1.1.1: http://commons.apache.org/proper/commons-logging/changes-report.html Looks like good stuff only.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12621075/HBASE-10265.txt
        against trunk revision .
        ATTACHMENT ID: 12621075

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8313//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8313//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12621075/HBASE-10265.txt against trunk revision . ATTACHMENT ID: 12621075 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8313//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8313//console This message is automatically generated.
        Hide
        Liang Xie added a comment -

        Integrated into trunk and 0.98. Thanks for review, stack

        Show
        Liang Xie added a comment - Integrated into trunk and 0.98. Thanks for review, stack
        Liang Xie made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 0.98.0 [ 12323143 ]
        Fix Version/s 0.99.0 [ 12325675 ]
        Resolution Fixed [ 1 ]
        Hide
        Andrew Purtell added a comment -

        Ping me before putting changes that affect code into 0.98 please Liang Xie until we have the first RC.

        Show
        Andrew Purtell added a comment - Ping me before putting changes that affect code into 0.98 please Liang Xie until we have the first RC.
        Hide
        Liang Xie added a comment -

        sorry for the trouble, let me revert it right now from 0.98.

        Show
        Liang Xie added a comment - sorry for the trouble, let me revert it right now from 0.98.
        Liang Xie made changes -
        Fix Version/s 0.98.0 [ 12323143 ]
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #65 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/65/)
        HBASE-10265 Upgrade to commons-logging 1.1.3 (liangxie: rev 1557300)

        • /hbase/branches/0.98/pom.xml
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #65 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/65/ ) HBASE-10265 Upgrade to commons-logging 1.1.3 (liangxie: rev 1557300) /hbase/branches/0.98/pom.xml
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.98 #70 (See https://builds.apache.org/job/HBase-0.98/70/)
        HBASE-10265 Upgrade to commons-logging 1.1.3 (liangxie: rev 1557300)

        • /hbase/branches/0.98/pom.xml
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.98 #70 (See https://builds.apache.org/job/HBase-0.98/70/ ) HBASE-10265 Upgrade to commons-logging 1.1.3 (liangxie: rev 1557300) /hbase/branches/0.98/pom.xml
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK #4807 (See https://builds.apache.org/job/HBase-TRUNK/4807/)
        HBASE-10265 Upgrade to commons-logging 1.1.3 (liangxie: rev 1557299)

        • /hbase/trunk/pom.xml
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4807 (See https://builds.apache.org/job/HBase-TRUNK/4807/ ) HBASE-10265 Upgrade to commons-logging 1.1.3 (liangxie: rev 1557299) /hbase/trunk/pom.xml
        Hide
        Andrew Purtell added a comment -

        Thanks for reverting this from 0.98. It's best not to change dependencies at this point unless we need to.

        Show
        Andrew Purtell added a comment - Thanks for reverting this from 0.98. It's best not to change dependencies at this point unless we need to.
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #66 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/66/)
        revert HBASE-10265 (liangxie: rev 1557306)

        • /hbase/branches/0.98/pom.xml
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #66 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/66/ ) revert HBASE-10265 (liangxie: rev 1557306) /hbase/branches/0.98/pom.xml
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98 #71 (See https://builds.apache.org/job/HBase-0.98/71/)
        revert HBASE-10265 (liangxie: rev 1557306)

        • /hbase/branches/0.98/pom.xml
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #71 (See https://builds.apache.org/job/HBase-0.98/71/ ) revert HBASE-10265 (liangxie: rev 1557306) /hbase/branches/0.98/pom.xml
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #50 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/50/)
        HBASE-10265 Upgrade to commons-logging 1.1.3 (liangxie: rev 1557299)

        • /hbase/trunk/pom.xml
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #50 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/50/ ) HBASE-10265 Upgrade to commons-logging 1.1.3 (liangxie: rev 1557299) /hbase/trunk/pom.xml
        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.
        Enis Soztutar made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Liang Xie
            Reporter:
            Liang Xie
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development