Details
-
Improvement
-
Status: Closed
-
Major
-
Resolution: Fixed
-
None
-
None
-
Reviewed
Description
When user calls Increment by providing amount=0, we don't write the original value to WAL or memstore : adding 0 yields a 'new' value just with the same value as the original one.
1. user provides 0 amount for query rather than for update, this fix is ok; this intention is the most possible case;
2. user provides 0 amount for an update, this fix is also ok : no need to touch back-end value if that value isn't changed;
3. either case we both return correct value, and keep subsequent query results correct : if the 0 amount Increment is the first update, the query is the same for retrieving a 0 value or retrieving nothing;