HBase
  1. HBase
  2. HBASE-10232

Remove native profile from hbase-shell

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.98.0, 0.99.0, 0.96.1.1
    • Fix Version/s: 0.98.0, 0.96.2, 0.99.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HBase shell module has no native source it shouldn't have a native profile. I think I copied that over by mistake.

        Activity

        Hide
        Elliott Clark added a comment -

        Just removals.

        mvn clean package -DskipTests -Pnative
        

        now runs to completion.

        Show
        Elliott Clark added a comment - Just removals. mvn clean package -DskipTests -Pnative now runs to completion.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12620252/HBASE-10232-0.patch
        against trunk revision .
        ATTACHMENT ID: 12620252

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8270//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8270//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8270//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8270//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8270//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8270//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8270//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8270//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8270//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8270//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8270//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12620252/HBASE-10232-0.patch against trunk revision . ATTACHMENT ID: 12620252 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8270//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8270//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8270//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8270//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8270//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8270//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8270//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8270//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8270//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8270//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8270//console This message is automatically generated.
        Hide
        stack added a comment -

        +1

        Show
        stack added a comment - +1
        Hide
        Liang Xie added a comment -

        +1

        Show
        Liang Xie added a comment - +1
        Hide
        Liang Xie added a comment -

        will commit it into 0.96,0.98,trunk shortly.

        Show
        Liang Xie added a comment - will commit it into 0.96,0.98,trunk shortly.
        Hide
        Liang Xie added a comment -

        I've verified manually:
        before patch, ran "mvn clean package -DskipTests -Pnative" got:

        [exec] CMake Error: The source directory "/home/xieliang/workspace/hbase_writable/hbase-shell/src/main/native" does not exist.
        [exec] Specify --help for usage, or press the help button on the CMake GUI.
        [INFO] ------------------------------------------------------------------------
        [INFO] BUILD FAILURE

        after applied patch, reran then got:

        [INFO] BUILD SUCCESS
        [INFO] ------------------------------------------------------------------------
        [INFO] Total time: 8.715s
        [INFO] Finished at: Tue Dec 24 16:50:07 CST 2013
        [INFO] Final Memory: 38M/743M
        [INFO] ------------------------------------------------------------------------
        [WARNING] The requested profile "native" could not be activated because it does not exist.

        I've integrated it into 0.96/0.98/trunk. Thanks Elliott Clark's patch and Stack's review.

        Show
        Liang Xie added a comment - I've verified manually: before patch, ran "mvn clean package -DskipTests -Pnative" got: [exec] CMake Error: The source directory "/home/xieliang/workspace/hbase_writable/hbase-shell/src/main/native" does not exist. [exec] Specify --help for usage, or press the help button on the CMake GUI. [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE after applied patch, reran then got: [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 8.715s [INFO] Finished at: Tue Dec 24 16:50:07 CST 2013 [INFO] Final Memory: 38M/743M [INFO] ------------------------------------------------------------------------ [WARNING] The requested profile "native" could not be activated because it does not exist. I've integrated it into 0.96/0.98/trunk. Thanks Elliott Clark 's patch and Stack 's review.
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK #4750 (See https://builds.apache.org/job/HBase-TRUNK/4750/)
        HBASE-10232 Remove native profile from hbase-shell (Elliot Clark) (liangxie: rev 1553260)

        • /hbase/trunk/hbase-shell/pom.xml
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4750 (See https://builds.apache.org/job/HBase-TRUNK/4750/ ) HBASE-10232 Remove native profile from hbase-shell (Elliot Clark) (liangxie: rev 1553260) /hbase/trunk/hbase-shell/pom.xml
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in hbase-0.96 #243 (See https://builds.apache.org/job/hbase-0.96/243/)
        HBASE-10232 Remove native profile from hbase-shell (Elliot Clark) (liangxie: rev 1553258)

        • /hbase/branches/0.96/hbase-shell/pom.xml
        Show
        Hudson added a comment - SUCCESS: Integrated in hbase-0.96 #243 (See https://builds.apache.org/job/hbase-0.96/243/ ) HBASE-10232 Remove native profile from hbase-shell (Elliot Clark) (liangxie: rev 1553258) /hbase/branches/0.96/hbase-shell/pom.xml
        Hide
        Hudson added a comment -

        FAILURE: Integrated in hbase-0.96-hadoop2 #162 (See https://builds.apache.org/job/hbase-0.96-hadoop2/162/)
        HBASE-10232 Remove native profile from hbase-shell (Elliot Clark) (liangxie: rev 1553258)

        • /hbase/branches/0.96/hbase-shell/pom.xml
        Show
        Hudson added a comment - FAILURE: Integrated in hbase-0.96-hadoop2 #162 (See https://builds.apache.org/job/hbase-0.96-hadoop2/162/ ) HBASE-10232 Remove native profile from hbase-shell (Elliot Clark) (liangxie: rev 1553258) /hbase/branches/0.96/hbase-shell/pom.xml
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #28 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/28/)
        HBASE-10232 Remove native profile from hbase-shell (Elliot Clark) (liangxie: rev 1553259)

        • /hbase/branches/0.98/hbase-shell/pom.xml
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #28 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/28/ ) HBASE-10232 Remove native profile from hbase-shell (Elliot Clark) (liangxie: rev 1553259) /hbase/branches/0.98/hbase-shell/pom.xml
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #21 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/21/)
        HBASE-10232 Remove native profile from hbase-shell (Elliot Clark) (liangxie: rev 1553260)

        • /hbase/trunk/hbase-shell/pom.xml
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #21 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/21/ ) HBASE-10232 Remove native profile from hbase-shell (Elliot Clark) (liangxie: rev 1553260) /hbase/trunk/hbase-shell/pom.xml
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98 #32 (See https://builds.apache.org/job/HBase-0.98/32/)
        HBASE-10232 Remove native profile from hbase-shell (Elliot Clark) (liangxie: rev 1553259)

        • /hbase/branches/0.98/hbase-shell/pom.xml
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #32 (See https://builds.apache.org/job/HBase-0.98/32/ ) HBASE-10232 Remove native profile from hbase-shell (Elliot Clark) (liangxie: rev 1553259) /hbase/branches/0.98/hbase-shell/pom.xml
        Hide
        Elliott Clark added a comment -

        Thanks for the help Liang Xie. I can commit stuff next time.

        Show
        Elliott Clark added a comment - Thanks for the help Liang Xie . I can commit stuff next time.

          People

          • Assignee:
            Elliott Clark
            Reporter:
            Elliott Clark
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development