HBase
  1. HBase
  2. HBASE-10229

Support OperationAttributes in Increment and Append in Shell

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.98.0
    • Fix Version/s: 0.98.0, 0.99.0
    • Component/s: shell
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. HBASE-10229_1.patch
      6 kB
      ramkrishna.s.vasudevan

      Activity

      Hide
      Hudson added a comment -

      SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #27 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/27/)
      HBASE-10229-Support OperationAttributes in Increment and Append in Shell (Ram) (ramkrishna: rev 1553623)

      • /hbase/trunk/hbase-shell/src/main/ruby/hbase/table.rb
      • /hbase/trunk/hbase-shell/src/main/ruby/shell.rb
      • /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/append.rb
      • /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/incr.rb
      • /hbase/trunk/hbase-shell/src/test/ruby/hbase/table_test.rb
      Show
      Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #27 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/27/ ) HBASE-10229 -Support OperationAttributes in Increment and Append in Shell (Ram) (ramkrishna: rev 1553623) /hbase/trunk/hbase-shell/src/main/ruby/hbase/table.rb /hbase/trunk/hbase-shell/src/main/ruby/shell.rb /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/append.rb /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/incr.rb /hbase/trunk/hbase-shell/src/test/ruby/hbase/table_test.rb
      Hide
      Hudson added a comment -

      FAILURE: Integrated in HBase-0.98 #40 (See https://builds.apache.org/job/HBase-0.98/40/)
      HBASE-10229. Support OperationAttributes in Increment and Append in Shell (Ramkrishna. S. Vasudevan) (apurtell: rev 1553716)

      • /hbase/branches/0.98/hbase-shell/src/main/ruby/hbase/table.rb
      • /hbase/branches/0.98/hbase-shell/src/main/ruby/shell.rb
      • /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/append.rb
      • /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/incr.rb
      • /hbase/branches/0.98/hbase-shell/src/test/ruby/hbase/table_test.rb
      Show
      Hudson added a comment - FAILURE: Integrated in HBase-0.98 #40 (See https://builds.apache.org/job/HBase-0.98/40/ ) HBASE-10229 . Support OperationAttributes in Increment and Append in Shell (Ramkrishna. S. Vasudevan) (apurtell: rev 1553716) /hbase/branches/0.98/hbase-shell/src/main/ruby/hbase/table.rb /hbase/branches/0.98/hbase-shell/src/main/ruby/shell.rb /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/append.rb /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/incr.rb /hbase/branches/0.98/hbase-shell/src/test/ruby/hbase/table_test.rb
      Hide
      Hudson added a comment -

      FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #38 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/38/)
      HBASE-10229. Support OperationAttributes in Increment and Append in Shell (Ramkrishna. S. Vasudevan) (apurtell: rev 1553716)

      • /hbase/branches/0.98/hbase-shell/src/main/ruby/hbase/table.rb
      • /hbase/branches/0.98/hbase-shell/src/main/ruby/shell.rb
      • /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/append.rb
      • /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/incr.rb
      • /hbase/branches/0.98/hbase-shell/src/test/ruby/hbase/table_test.rb
      Show
      Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #38 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/38/ ) HBASE-10229 . Support OperationAttributes in Increment and Append in Shell (Ramkrishna. S. Vasudevan) (apurtell: rev 1553716) /hbase/branches/0.98/hbase-shell/src/main/ruby/hbase/table.rb /hbase/branches/0.98/hbase-shell/src/main/ruby/shell.rb /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/append.rb /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/incr.rb /hbase/branches/0.98/hbase-shell/src/test/ruby/hbase/table_test.rb
      Hide
      Andrew Purtell added a comment -

      Committed to 0.98 branch.

      Show
      Andrew Purtell added a comment - Committed to 0.98 branch.
      Hide
      Hudson added a comment -

      SUCCESS: Integrated in HBase-TRUNK #4765 (See https://builds.apache.org/job/HBase-TRUNK/4765/)
      HBASE-10229-Support OperationAttributes in Increment and Append in Shell (Ram) (ramkrishna: rev 1553623)

      • /hbase/trunk/hbase-shell/src/main/ruby/hbase/table.rb
      • /hbase/trunk/hbase-shell/src/main/ruby/shell.rb
      • /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/append.rb
      • /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/incr.rb
      • /hbase/trunk/hbase-shell/src/test/ruby/hbase/table_test.rb
      Show
      Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4765 (See https://builds.apache.org/job/HBase-TRUNK/4765/ ) HBASE-10229 -Support OperationAttributes in Increment and Append in Shell (Ram) (ramkrishna: rev 1553623) /hbase/trunk/hbase-shell/src/main/ruby/hbase/table.rb /hbase/trunk/hbase-shell/src/main/ruby/shell.rb /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/append.rb /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/incr.rb /hbase/trunk/hbase-shell/src/test/ruby/hbase/table_test.rb
      Hide
      ramkrishna.s.vasudevan added a comment -

      Committed to trunk. I tried committing thro svn tool to 0.98. I still get permission denied. Andrew Purtell,Anoop Sam John - could you commit to 0.98.

      Show
      ramkrishna.s.vasudevan added a comment - Committed to trunk. I tried committing thro svn tool to 0.98. I still get permission denied. Andrew Purtell , Anoop Sam John - could you commit to 0.98.
      Hide
      Andrew Purtell added a comment -

      +1, looks good to me

      Show
      Andrew Purtell added a comment - +1, looks good to me
      Hide
      ramkrishna.s.vasudevan added a comment -

      I plan to commit this if all are fine with this. This would help me to give the final patch for HBASE-10228. I have it but thought it would be better if I update it after this goes in.

      Show
      ramkrishna.s.vasudevan added a comment - I plan to commit this if all are fine with this. This would help me to give the final patch for HBASE-10228 . I have it but thought it would be better if I update it after this goes in.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12620373/HBASE-10229_1.patch
      against trunk revision .
      ATTACHMENT ID: 12620373

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified tests.

      +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

      +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 lineLengths. The patch does not introduce lines longer than 100

      -1 site. The patch appears to cause mvn site goal to fail.

      +1 core tests. The patch passed unit tests in .

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8280//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8280//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12620373/HBASE-10229_1.patch against trunk revision . ATTACHMENT ID: 12620373 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8280//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8280//console This message is automatically generated.
      Hide
      ramkrishna.s.vasudevan added a comment -

      Test Shell passes with the patch. Added a testcase for append.
      One thing I noticed is that in put.rb it is not possible to specify values as long based on which the incr can operate. We can provide that support in another JIRA.

      Show
      ramkrishna.s.vasudevan added a comment - Test Shell passes with the patch. Added a testcase for append. One thing I noticed is that in put.rb it is not possible to specify values as long based on which the incr can operate. We can provide that support in another JIRA.
      Hide
      ramkrishna.s.vasudevan added a comment -

      To add on, there is no append support in shell. Will include that also.

      Show
      ramkrishna.s.vasudevan added a comment - To add on, there is no append support in shell. Will include that also.
      Hide
      ramkrishna.s.vasudevan added a comment -

      The patch that am working on changes to using an Increment object. Will post a patch after testing.

      Show
      ramkrishna.s.vasudevan added a comment - The patch that am working on changes to using an Increment object. Will post a patch after testing.
      Hide
      Anoop Sam John added a comment -

      We can change inc.rb to pass the increment info within the Increment Mutation object right Ram. So u can support op attr, cell visibility etc also.

      Show
      Anoop Sam John added a comment - We can change inc.rb to pass the increment info within the Increment Mutation object right Ram. So u can support op attr, cell visibility etc also.
      Hide
      stack added a comment -

      Can we change incr.rb so it uses something other than incrementColumnValue then?

      Show
      stack added a comment - Can we change incr.rb so it uses something other than incrementColumnValue then?
      Hide
      ramkrishna.s.vasudevan added a comment -

      The incr.rb uses table.incrementColumnValue. Infact using HTable.incrementColumnValue() we cannot use Operation Attributes itself because it does not build increment directly as an mutation object.

      Show
      ramkrishna.s.vasudevan added a comment - The incr.rb uses table.incrementColumnValue. Infact using HTable.incrementColumnValue() we cannot use Operation Attributes itself because it does not build increment directly as an mutation object.

        People

        • Assignee:
          ramkrishna.s.vasudevan
          Reporter:
          ramkrishna.s.vasudevan
        • Votes:
          0 Vote for this issue
          Watchers:
          9 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development