HBase
  1. HBase
  2. HBASE-10228

Support setCellVisibility and setAuthorizations in Shell

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.98.0
    • Fix Version/s: 0.98.0, 0.99.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently the shell scripts supports attributes but not the new apis in the Query class. So this JIRA is to support them thro shell.

      1. HBASE-10228.patch
        7 kB
        ramkrishna.s.vasudevan
      2. HBASE-10228_2.patch
        13 kB
        ramkrishna.s.vasudevan
      3. HBASE-10228_1.patch
        13 kB
        ramkrishna.s.vasudevan

        Activity

        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK #4770 (See https://builds.apache.org/job/HBase-TRUNK/4770/)
        HBASE-10228-Support setCellVisibility and setAuthorizations in Shell (Ram) (ramkrishna: rev 1554159)

        • /hbase/trunk/hbase-shell/src/main/ruby/hbase.rb
        • /hbase/trunk/hbase-shell/src/main/ruby/hbase/table.rb
        • /hbase/trunk/hbase-shell/src/main/ruby/hbase/visibility_labels.rb
        • /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/append.rb
        • /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/get.rb
        • /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/incr.rb
        • /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/put.rb
        • /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/scan.rb
        • /hbase/trunk/hbase-shell/src/test/ruby/hbase/table_test.rb
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4770 (See https://builds.apache.org/job/HBase-TRUNK/4770/ ) HBASE-10228 -Support setCellVisibility and setAuthorizations in Shell (Ram) (ramkrishna: rev 1554159) /hbase/trunk/hbase-shell/src/main/ruby/hbase.rb /hbase/trunk/hbase-shell/src/main/ruby/hbase/table.rb /hbase/trunk/hbase-shell/src/main/ruby/hbase/visibility_labels.rb /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/append.rb /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/get.rb /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/incr.rb /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/put.rb /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/scan.rb /hbase/trunk/hbase-shell/src/test/ruby/hbase/table_test.rb
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #29 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/29/)
        HBASE-10228-Support setCellVisibility and setAuthorizations in Shell (Ram) (ramkrishna: rev 1554159)

        • /hbase/trunk/hbase-shell/src/main/ruby/hbase.rb
        • /hbase/trunk/hbase-shell/src/main/ruby/hbase/table.rb
        • /hbase/trunk/hbase-shell/src/main/ruby/hbase/visibility_labels.rb
        • /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/append.rb
        • /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/get.rb
        • /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/incr.rb
        • /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/put.rb
        • /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/scan.rb
        • /hbase/trunk/hbase-shell/src/test/ruby/hbase/table_test.rb
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #29 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/29/ ) HBASE-10228 -Support setCellVisibility and setAuthorizations in Shell (Ram) (ramkrishna: rev 1554159) /hbase/trunk/hbase-shell/src/main/ruby/hbase.rb /hbase/trunk/hbase-shell/src/main/ruby/hbase/table.rb /hbase/trunk/hbase-shell/src/main/ruby/hbase/visibility_labels.rb /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/append.rb /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/get.rb /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/incr.rb /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/put.rb /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/scan.rb /hbase/trunk/hbase-shell/src/test/ruby/hbase/table_test.rb
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #40 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/40/)
        HBASE-10228 Support setCellVisibility and setAuthorizations in Shell(Ram) (anoopsamjohn: rev 1554160)

        • /hbase/branches/0.98/hbase-shell/src/main/ruby/hbase.rb
        • /hbase/branches/0.98/hbase-shell/src/main/ruby/hbase/table.rb
        • /hbase/branches/0.98/hbase-shell/src/main/ruby/hbase/visibility_labels.rb
        • /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/append.rb
        • /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/get.rb
        • /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/incr.rb
        • /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/put.rb
        • /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/scan.rb
        • /hbase/branches/0.98/hbase-shell/src/test/ruby/hbase/table_test.rb
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #40 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/40/ ) HBASE-10228 Support setCellVisibility and setAuthorizations in Shell(Ram) (anoopsamjohn: rev 1554160) /hbase/branches/0.98/hbase-shell/src/main/ruby/hbase.rb /hbase/branches/0.98/hbase-shell/src/main/ruby/hbase/table.rb /hbase/branches/0.98/hbase-shell/src/main/ruby/hbase/visibility_labels.rb /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/append.rb /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/get.rb /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/incr.rb /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/put.rb /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/scan.rb /hbase/branches/0.98/hbase-shell/src/test/ruby/hbase/table_test.rb
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.98 #43 (See https://builds.apache.org/job/HBase-0.98/43/)
        HBASE-10228 Support setCellVisibility and setAuthorizations in Shell(Ram) (anoopsamjohn: rev 1554160)

        • /hbase/branches/0.98/hbase-shell/src/main/ruby/hbase.rb
        • /hbase/branches/0.98/hbase-shell/src/main/ruby/hbase/table.rb
        • /hbase/branches/0.98/hbase-shell/src/main/ruby/hbase/visibility_labels.rb
        • /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/append.rb
        • /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/get.rb
        • /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/incr.rb
        • /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/put.rb
        • /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/scan.rb
        • /hbase/branches/0.98/hbase-shell/src/test/ruby/hbase/table_test.rb
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.98 #43 (See https://builds.apache.org/job/HBase-0.98/43/ ) HBASE-10228 Support setCellVisibility and setAuthorizations in Shell(Ram) (anoopsamjohn: rev 1554160) /hbase/branches/0.98/hbase-shell/src/main/ruby/hbase.rb /hbase/branches/0.98/hbase-shell/src/main/ruby/hbase/table.rb /hbase/branches/0.98/hbase-shell/src/main/ruby/hbase/visibility_labels.rb /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/append.rb /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/get.rb /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/incr.rb /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/put.rb /hbase/branches/0.98/hbase-shell/src/main/ruby/shell/commands/scan.rb /hbase/branches/0.98/hbase-shell/src/test/ruby/hbase/table_test.rb
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12620808/HBASE-10228_2.patch
        against trunk revision .
        ATTACHMENT ID: 12620808

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8302//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8302//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12620808/HBASE-10228_2.patch against trunk revision . ATTACHMENT ID: 12620808 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8302//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8302//console This message is automatically generated.
        Hide
        Anoop Sam John added a comment -

        Committed to 0.98 also. You can close issue Ram.. Thanks..

        Show
        Anoop Sam John added a comment - Committed to 0.98 also. You can close issue Ram.. Thanks..
        Hide
        ramkrishna.s.vasudevan added a comment -

        Committed to trunk. Yet to commit to 0.98.
        Anoop Sam John
        Could you commit to 0.98?

        Show
        ramkrishna.s.vasudevan added a comment - Committed to trunk. Yet to commit to 0.98. Anoop Sam John Could you commit to 0.98?
        Hide
        Anoop Sam John added a comment -

        LGTM.
        +1 if you have tested all the cases in shell.

        Show
        Anoop Sam John added a comment - LGTM. +1 if you have tested all the cases in shell.
        Hide
        ramkrishna.s.vasudevan added a comment -

        Removed the redundant if condition. The elsif condition is fine in that place. Tested with attributes and with authorizations combined. Corrected the test case comemnt.
        Also the reason for removing the incr testcase added in HBASE-10229 (already stated in previous comments) is that eventually the logs throw an exception saying that the value inserted thro puts are not 64 bit long. We need to support long value in puts before adding incr testcases.
        Should be good to go.

        Show
        ramkrishna.s.vasudevan added a comment - Removed the redundant if condition. The elsif condition is fine in that place. Tested with attributes and with authorizations combined. Corrected the test case comemnt. Also the reason for removing the incr testcase added in HBASE-10229 (already stated in previous comments) is that eventually the logs throw an exception saying that the value inserted thro puts are not 64 bit long. We need to support long value in puts before adding incr testcases. Should be good to go.
        Hide
        Anoop Sam John added a comment - - edited
        +          elsif authorizations
        +          	 set_authorizations(get, authorizations) if authorizations
        

        Looks like typo. You want if? Why 2 ifs? Above with attributes also.

        table_test.rb

        +    define_test "put should work with attribute" do
        +       @test_table.put("123", "x:a", 4, {VISIBILITY=>'mykey'})
        +    end
        

        Say "put should work with visibility" ?

        Why some tests are removed from this?

        Show
        Anoop Sam John added a comment - - edited + elsif authorizations + set_authorizations(get, authorizations) if authorizations Looks like typo. You want if? Why 2 ifs? Above with attributes also. table_test.rb + define_test "put should work with attribute" do + @test_table.put( "123" , "x:a" , 4, {VISIBILITY=>'mykey'}) + end Say "put should work with visibility" ? Why some tests are removed from this?
        Hide
        ramkrishna.s.vasudevan added a comment -

        Ping? Will commit this unless objections.

        Show
        ramkrishna.s.vasudevan added a comment - Ping? Will commit this unless objections.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12620600/HBASE-10228_1.patch
        against trunk revision .
        ATTACHMENT ID: 12620600

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8289//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8289//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8289//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8289//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8289//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8289//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8289//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8289//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8289//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8289//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8289//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12620600/HBASE-10228_1.patch against trunk revision . ATTACHMENT ID: 12620600 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8289//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8289//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8289//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8289//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8289//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8289//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8289//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8289//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8289//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8289//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8289//console This message is automatically generated.
        Hide
        ramkrishna.s.vasudevan added a comment -

        Latest patch after HBASE-10229 went in. I removed the incr testcase because though the testcase passes wrt syntax internally the incr would throw error saying cannot increment as the value is not a 64bit format value. Tested all commands. Works fine.

        Show
        ramkrishna.s.vasudevan added a comment - Latest patch after HBASE-10229 went in. I removed the incr testcase because though the testcase passes wrt syntax internally the incr would throw error saying cannot increment as the value is not a 64bit format value. Tested all commands. Works fine.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12620520/HBASE-10228.patch
        against trunk revision .
        ATTACHMENT ID: 12620520

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.util.TestHBaseFsck

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8285//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8285//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8285//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8285//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8285//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8285//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8285//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8285//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8285//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8285//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8285//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12620520/HBASE-10228.patch against trunk revision . ATTACHMENT ID: 12620520 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.util.TestHBaseFsck Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8285//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8285//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8285//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8285//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8285//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8285//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8285//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8285//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8285//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8285//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8285//console This message is automatically generated.
        Hide
        ramkrishna.s.vasudevan added a comment -

        Attaching the patch here. After HBASE-10229 gets committed will update this patch once again.

        Show
        ramkrishna.s.vasudevan added a comment - Attaching the patch here. After HBASE-10229 gets committed will update this patch once again.
        Hide
        ramkrishna.s.vasudevan added a comment -

        Yes exactly.

        Show
        ramkrishna.s.vasudevan added a comment - Yes exactly.
        Hide
        Anoop Sam John added a comment -

        In put, append, increment we should be able to specify cellVisibility
        In scan , get we should be able to specify authorizations

        Show
        Anoop Sam John added a comment - In put, append, increment we should be able to specify cellVisibility In scan , get we should be able to specify authorizations

          People

          • Assignee:
            ramkrishna.s.vasudevan
            Reporter:
            ramkrishna.s.vasudevan
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development