HBase
  1. HBase
  2. HBASE-10211

Improve AccessControl documentation in hbase book

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.98.0
    • Fix Version/s: 0.99.0
    • Component/s: documentation
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The AccessControl documentation is bit old in the hbase book. Update that to the latest describing cell level ACLs with HFileV3.

      1. HBASE-10211.patch
        3 kB
        ramkrishna.s.vasudevan
      2. HBASE-10211_2.patch
        3 kB
        ramkrishna.s.vasudevan
      3. HBASE-10211_1.patch
        3 kB
        ramkrishna.s.vasudevan

        Activity

        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #23 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/23/)
        HBASE-10211 - Improve AccessControl documentation in hbase book (Ram) (ramkrishna: rev 1553366)

        • /hbase/trunk/src/main/docbkx/security.xml
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #23 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/23/ ) HBASE-10211 - Improve AccessControl documentation in hbase book (Ram) (ramkrishna: rev 1553366) /hbase/trunk/src/main/docbkx/security.xml
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #4757 (See https://builds.apache.org/job/HBase-TRUNK/4757/)
        HBASE-10211 - Improve AccessControl documentation in hbase book (Ram) (ramkrishna: rev 1553366)

        • /hbase/trunk/src/main/docbkx/security.xml
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #4757 (See https://builds.apache.org/job/HBase-TRUNK/4757/ ) HBASE-10211 - Improve AccessControl documentation in hbase book (Ram) (ramkrishna: rev 1553366) /hbase/trunk/src/main/docbkx/security.xml
        Hide
        ramkrishna.s.vasudevan added a comment -

        Committed to trunk.

        Show
        ramkrishna.s.vasudevan added a comment - Committed to trunk.
        Hide
        ramkrishna.s.vasudevan added a comment -

        This is the patch that I would be committing.

        Show
        ramkrishna.s.vasudevan added a comment - This is the patch that I would be committing.
        Hide
        ramkrishna.s.vasudevan added a comment -

        Updated patch. Will commit this unless objection.

        Show
        ramkrishna.s.vasudevan added a comment - Updated patch. Will commit this unless objection.
        Hide
        Anoop Sam John added a comment -

        +1 apart from above 2 nits Ram.
        Andrew Purtell Want to have a look at it?

        Show
        Anoop Sam John added a comment - +1 apart from above 2 nits Ram. Andrew Purtell Want to have a look at it?
        Hide
        Anoop Sam John added a comment -

        Generally the ACL applied on the table and CF takes precedence.

        say precedence over cell level ACLs ?

        + <para>
        + Please note that inorder to use this feature, HFile V3 version should be turned on.
        + </para>
        + <programlisting><![CDATA[
        + Mutation. setACLStrategy(boolean cellFirstStrategy)
        + ]]></programlisting>
        

        Mutation. setACLStrategy... this is not needed here. Looks to be copy paste issue

        Avoid unwanted white spaces

        Show
        Anoop Sam John added a comment - Generally the ACL applied on the table and CF takes precedence. say precedence over cell level ACLs ? + <para> + Please note that inorder to use this feature, HFile V3 version should be turned on. + </para> + <programlisting><![CDATA[ + Mutation. setACLStrategy( boolean cellFirstStrategy) + ]]></programlisting> Mutation. setACLStrategy... this is not needed here. Looks to be copy paste issue Avoid unwanted white spaces
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12620223/HBASE-10211.patch
        against trunk revision .
        ATTACHMENT ID: 12620223

        +1 @author. The patch does not contain any @author tags.

        +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8268//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8268//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8268//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8268//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8268//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8268//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8268//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8268//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8268//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8268//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8268//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12620223/HBASE-10211.patch against trunk revision . ATTACHMENT ID: 12620223 +1 @author . The patch does not contain any @author tags. +0 tests included . The patch appears to be a documentation patch that doesn't require tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8268//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8268//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8268//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8268//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8268//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8268//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8268//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8268//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8268//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8268//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8268//console This message is automatically generated.
        Hide
        ramkrishna.s.vasudevan added a comment -

        Patch for trunk.

        Show
        ramkrishna.s.vasudevan added a comment - Patch for trunk.

          People

          • Assignee:
            ramkrishna.s.vasudevan
            Reporter:
            ramkrishna.s.vasudevan
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development