HBase
  1. HBase
  2. HBASE-10208

Add split keys and region location related API in HTable to HTableInterface as well

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Invalid
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Client
    • Labels:
      None

      Description

      These are APIs related to split keys avaiable in HTable same can be to HTI
      getStartKeys()
      getEndKeys()
      getStartEndKeys()
      getSplitKeys() - New
      and 3 more APIs related to find region location when we specify row also can be added to HTI
      getRegionLocation(final String row)
      getRegionLocation(final byte [] row)
      getRegionLocation(final byte [] row, boolean reload)

        Issue Links

          Activity

          Hide
          Nick Dimiduk added a comment -

          Is there an API design reason why these region details are omitted from the HTableInterface in the first place?

          Show
          Nick Dimiduk added a comment - Is there an API design reason why these region details are omitted from the HTableInterface in the first place?
          Hide
          stack added a comment -

          High-level we want to hide notion of 'region' from clients. Does this change go against such an axiom?

          Show
          stack added a comment - High-level we want to hide notion of 'region' from clients. Does this change go against such an axiom?
          Hide
          Nick Dimiduk added a comment -

          Appears that way, Boss.

          Show
          Nick Dimiduk added a comment - Appears that way, Boss.
          Hide
          Lars Hofhansl added a comment -

          Came here to say what Stack said.

          Code requiring these special methods could check whether an HTI is an HTable and cast accordingly. That way we won't tie the interface to implementation details. Would that work for you rajeshbabu?

          Show
          Lars Hofhansl added a comment - Came here to say what Stack said. Code requiring these special methods could check whether an HTI is an HTable and cast accordingly. That way we won't tie the interface to implementation details. Would that work for you rajeshbabu ?
          Hide
          Andrew Purtell added a comment -

          Unscheduling from 0.98

          Show
          Andrew Purtell added a comment - Unscheduling from 0.98
          Hide
          rajeshbabu added a comment -

          High-level we want to hide notion of 'region' from clients. Does this change go against such an axiom?

          Yes Its looks like against to that.

          Code requiring these special methods could check whether an HTI is an HTable and cast accordingly. That way we won't tie the interface to implementation details. Would that work for you rajeshbabu?

          That works for me.

          Sorry for the mess. Closing this issue as invalid.
          Thanks.

          Show
          rajeshbabu added a comment - High-level we want to hide notion of 'region' from clients. Does this change go against such an axiom? Yes Its looks like against to that. Code requiring these special methods could check whether an HTI is an HTable and cast accordingly. That way we won't tie the interface to implementation details. Would that work for you rajeshbabu? That works for me. Sorry for the mess. Closing this issue as invalid. Thanks.
          Hide
          Anoop Sam John added a comment -

          Reopening and closing this issue as 'Invalid'

          Show
          Anoop Sam John added a comment - Reopening and closing this issue as 'Invalid'
          Hide
          Lars Hofhansl added a comment -

          rajeshbabu, it's a good discussion.
          If you're good with the casting approach, maybe we can add some Javadocs to HTI and HTable to describe to which level we want to expose HBase internals there.

          Show
          Lars Hofhansl added a comment - rajeshbabu , it's a good discussion. If you're good with the casting approach, maybe we can add some Javadocs to HTI and HTable to describe to which level we want to expose HBase internals there.
          Hide
          stack added a comment -

          I like what Andrew Purtell says

          Show
          stack added a comment - I like what Andrew Purtell says
          Hide
          Lars Hofhansl added a comment -

          Let's add some documentation so that this does not come up every release. I'll see whip something up.

          Show
          Lars Hofhansl added a comment - Let's add some documentation so that this does not come up every release. I'll see whip something up.

            People

            • Assignee:
              rajeshbabu
              Reporter:
              rajeshbabu
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development