[HBASE-10186] region_mover.rb broken because ServerName constructor is changed to private

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.96.1
• Fix Version/s: 0.98.0, 0.96.2, 0.99.0
• Component/s: scripts

Environment

x86_64 GNU/Linux

• Hadoop Flags: Reviewed
• Assignee: Samir Ahmic
• Reporter: Samir Ahmic
• Created: 17/Dec/13 08:44
• Updated: 21/Feb/15 23:34
• Resolved: 17/Dec/13 13:05

Description

After upgrading to 0.96.1 (from 0.96.0) i have tried rolling restart with ./rolling-restart.sh --graceful but region_mover.rb throws error:

TypeError: no public constructors for Java::OrgApacheHadoopHbase::ServerName
     getRegions at ./region_mover.rb:257
  unloadRegions at ./region_mover.rb:318
         (root) at ./region_mover.rb:461

After checking region_mover.rb i believe this line:

return ProtobufUtil::getOnlineRegions(connection.getAdmin(ServerName.new(servername)));

should be changed to

return ProtobufUtil::getOnlineRegions(connection.getAdmin(ServerName.valueOf(servername)));

After making this change region_mover.rb is working again. I will attach patch shortly.

Issue Links

• is broken by: HBASE-10012 Hide ServerName constructor