HBase
  1. HBase
  2. HBASE-10175

2-thread ChaosMonkey steps on its own toes

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.0, 0.99.0
    • Component/s: test
    • Labels:
      None

      Description

      ChaosMonkey with one destructive and one volatility (flush-compact-split-etc.) threads steps on its own toes and logs a lot of exceptions.
      A simple solution would be to catch most (or all), like NotServingRegionException, and log less (not a full callstack for example, it's not very useful anyway).
      A more complicated/complementary one would be to keep track which regions the destructive thread affects and use other regions for volatile one.

      1. HBASE-10175.patch
        7 kB
        Sergey Shelukhin

        Activity

        Hide
        Sergey Shelukhin added a comment -

        The first option; simple patch.

        ChaosMonkey is now so abstract that I wouldn't venture to spend the time needed to make the actions talk to each other...

        Show
        Sergey Shelukhin added a comment - The first option; simple patch. ChaosMonkey is now so abstract that I wouldn't venture to spend the time needed to make the actions talk to each other...
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12619725/HBASE-10175.patch
        against trunk revision .
        ATTACHMENT ID: 12619725

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 21 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.security.access.TestAccessController

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8239//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8239//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12619725/HBASE-10175.patch against trunk revision . ATTACHMENT ID: 12619725 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 21 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.security.access.TestAccessController Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8239//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8239//console This message is automatically generated.
        Hide
        Sergey Shelukhin added a comment -

        I don't think test failure can be related. Enis Soztutar you want to review?

        Show
        Sergey Shelukhin added a comment - I don't think test failure can be related. Enis Soztutar you want to review?
        Hide
        Enis Soztutar added a comment -

        +1.

        Show
        Enis Soztutar added a comment - +1.
        Hide
        Sergey Shelukhin added a comment -

        will commit today if no objections

        Show
        Sergey Shelukhin added a comment - will commit today if no objections
        Hide
        Sergey Shelukhin added a comment -

        committed to trunk

        Show
        Sergey Shelukhin added a comment - committed to trunk
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK #4765 (See https://builds.apache.org/job/HBase-TRUNK/4765/)
        HBASE-10175 2-thread ChaosMonkey steps on its own toes (sershe: rev 1553634)

        • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactRandomRegionOfTableAction.java
        • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactTableAction.java
        • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/FlushRandomRegionOfTableAction.java
        • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/FlushTableAction.java
        • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MergeRandomAdjacentRegionsOfTableAction.java
        • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MoveRegionsOfTableAction.java
        • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SplitRandomRegionOfTableAction.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4765 (See https://builds.apache.org/job/HBase-TRUNK/4765/ ) HBASE-10175 2-thread ChaosMonkey steps on its own toes (sershe: rev 1553634) /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactRandomRegionOfTableAction.java /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactTableAction.java /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/FlushRandomRegionOfTableAction.java /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/FlushTableAction.java /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MergeRandomAdjacentRegionsOfTableAction.java /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MoveRegionsOfTableAction.java /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SplitRandomRegionOfTableAction.java
        Hide
        Andrew Purtell added a comment -

        Committed test improvement to 0.98 branch also.

        Show
        Andrew Purtell added a comment - Committed test improvement to 0.98 branch also.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #38 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/38/)
        HBASE-10175. 2-thread ChaosMonkey steps on its own toes (Sergey Shelukhin) (apurtell: rev 1553717)

        • /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactRandomRegionOfTableAction.java
        • /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactTableAction.java
        • /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/FlushRandomRegionOfTableAction.java
        • /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/FlushTableAction.java
        • /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MergeRandomAdjacentRegionsOfTableAction.java
        • /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MoveRegionsOfTableAction.java
        • /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SplitRandomRegionOfTableAction.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #38 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/38/ ) HBASE-10175 . 2-thread ChaosMonkey steps on its own toes (Sergey Shelukhin) (apurtell: rev 1553717) /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactRandomRegionOfTableAction.java /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactTableAction.java /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/FlushRandomRegionOfTableAction.java /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/FlushTableAction.java /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MergeRandomAdjacentRegionsOfTableAction.java /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MoveRegionsOfTableAction.java /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SplitRandomRegionOfTableAction.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.98 #40 (See https://builds.apache.org/job/HBase-0.98/40/)
        HBASE-10175. 2-thread ChaosMonkey steps on its own toes (Sergey Shelukhin) (apurtell: rev 1553717)

        • /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactRandomRegionOfTableAction.java
        • /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactTableAction.java
        • /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/FlushRandomRegionOfTableAction.java
        • /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/FlushTableAction.java
        • /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MergeRandomAdjacentRegionsOfTableAction.java
        • /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MoveRegionsOfTableAction.java
        • /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SplitRandomRegionOfTableAction.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.98 #40 (See https://builds.apache.org/job/HBase-0.98/40/ ) HBASE-10175 . 2-thread ChaosMonkey steps on its own toes (Sergey Shelukhin) (apurtell: rev 1553717) /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactRandomRegionOfTableAction.java /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactTableAction.java /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/FlushRandomRegionOfTableAction.java /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/FlushTableAction.java /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MergeRandomAdjacentRegionsOfTableAction.java /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MoveRegionsOfTableAction.java /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SplitRandomRegionOfTableAction.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #27 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/27/)
        HBASE-10175 2-thread ChaosMonkey steps on its own toes (sershe: rev 1553634)

        • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactRandomRegionOfTableAction.java
        • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactTableAction.java
        • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/FlushRandomRegionOfTableAction.java
        • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/FlushTableAction.java
        • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MergeRandomAdjacentRegionsOfTableAction.java
        • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MoveRegionsOfTableAction.java
        • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SplitRandomRegionOfTableAction.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #27 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/27/ ) HBASE-10175 2-thread ChaosMonkey steps on its own toes (sershe: rev 1553634) /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactRandomRegionOfTableAction.java /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactTableAction.java /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/FlushRandomRegionOfTableAction.java /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/FlushTableAction.java /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MergeRandomAdjacentRegionsOfTableAction.java /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MoveRegionsOfTableAction.java /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SplitRandomRegionOfTableAction.java
        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

          People

          • Assignee:
            Sergey Shelukhin
            Reporter:
            Sergey Shelukhin
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development